Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Mon, 8 Aug 2022 06:30:46 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     sunliming <sunliming@kylinos.cn>
Cc:     wim@linux-watchdog.org, arnd@arndb.de,
        linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
        kelulanainsley@gmail.com, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] watchdog: sa1100: make variable sa1100dog_driver static
Message-ID: <20220808133046.GA2347272@roeck-us.net>
References: <20220802020819.1226454-1-sunliming@kylinos.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220802020819.1226454-1-sunliming@kylinos.cn>
Precedence: bulk

On Tue, Aug 02, 2022 at 10:08:19AM +0800, sunliming wrote:
> This symbol is not used outside of sa1100_wdt.c, so marks it static.
> 
> Fixes the following warning:
> 
> >> drivers/watchdog/sa1100_wdt.c:241:24: sparse: sparse: symbol 'sa1100dog_driver'
> was not declared. Should it be static?
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: sunliming <sunliming@kylinos.cn>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/sa1100_wdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/sa1100_wdt.c b/drivers/watchdog/sa1100_wdt.c
> index 2d0a06a158a8..82ac5d19f519 100644
> --- a/drivers/watchdog/sa1100_wdt.c
> +++ b/drivers/watchdog/sa1100_wdt.c
> @@ -238,7 +238,7 @@ static int sa1100dog_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -struct platform_driver sa1100dog_driver = {
> +static struct platform_driver sa1100dog_driver = {
>  	.driver.name = "sa1100_wdt",
>  	.probe	  = sa1100dog_probe,
>  	.remove	  = sa1100dog_remove,
> -- 
> 2.25.1
>