Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 8 Aug 2022 14:48:23 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Aidan MacDonald <aidanmacdonald.0x0@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v1 1/5] regmap: mmio: Don't unprepare attached clock
Message-ID: <YvEUJ12TmgRaR4Ub@sirena.org.uk>
References: <20220805205321.19452-1-andriy.shevchenko@linux.intel.com>
 <YvEKgkhRWCKtXdD4@sirena.org.uk>
 <CAHp75VeeZAgKdZhJffNouFh26rwGzmqGuJX7bcObSVV+dFS-tA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ZxuxQCJ31s+QoHqV"
Content-Disposition: inline
In-Reply-To: <CAHp75VeeZAgKdZhJffNouFh26rwGzmqGuJX7bcObSVV+dFS-tA@mail.gmail.com>
Precedence: bulk


--ZxuxQCJ31s+QoHqV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Aug 08, 2022 at 03:41:48PM +0200, Andy Shevchenko wrote:
> On Mon, Aug 8, 2022 at 3:19 PM Mark Brown <broonie@kernel.org> wrote:

> > regmap_mmio_attach_clk() prepares the clock that's passed in, we should
> > undo that when detaching otherwise we're leaking a prepare (as we do in
> > the explicit detach).

> Why do we allow the user to avoid explicit detach? What is the point
> of having that API in the case we take care of it?

I think just for symmetry so it's obvious that error handling is
happening if people want it to be.

--ZxuxQCJ31s+QoHqV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLxFCYACgkQJNaLcl1U
h9BdvQf+OJJbTrFaHiI8cc4lrDovCbKsQ559BIfDzBz+m8Kt7j/yaQHHzcjBBn0c
0HyvJKLRNDSwcM/sKIxMWSOxqNH9qi7edMnqJd+tKwjUJZOtJfGuDjNoT3eaYNuL
TBpCMPhH4mAyipt1NkcwnGKLELyKQJ7ltiiLtSlqTOmQ9DUA6P342nbdVyvGmxM0
aZ9gmhjZ9gKi51kcsjtjCnwNKwq6TIaJENDBvwLn75WlPhTgQBWyx2ALHU/6ER0y
q+IC8cTebkB6MA9oH+6fbFNy7WXdkCj1uA910lAyPg/SqyuVsY9r2csro8IMuGR1
70bd5D1V7CAyBlcZMwaLDDiISTIYww==
=e58/
-----END PGP SIGNATURE-----

--ZxuxQCJ31s+QoHqV--