Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Ondrej Mosnacek <omosnace@redhat.com>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Minchan Kim <minchan@kernel.org>,
        "Christian Brauner (Microsoft)" <brauner@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Hridya Valsaraju <hridya@google.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        Martijn Coenen <maco@android.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Todd Kjos <tkjos@android.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Linux kernel mailing list <linux-kernel@vger.kernel.org>,
        =?iso-8859-1?Q?Arve_Hj=F8nnev=E5g?= <arve@android.com>,
        Carlos Llamas <cmllamas@google.com>
Subject: Re: Binder regression caused by commit a43cfc87caaf
Thread-Topic: Binder regression caused by commit a43cfc87caaf
Thread-Index: AQHYqw+ISmpRZPmLpkiane2Iritf5K2lGuGA
Date:   Mon, 8 Aug 2022 15:07:05 +0000
Message-ID: <20220808150657.liop7yf5hsutbpp3@revolver>
References: <CAFqZXNtNjQLpzu4CFiMawfkKeVFULw4ti3MdZL1QejPrzeJv8Q@mail.gmail.com>
In-Reply-To: <CAFqZXNtNjQLpzu4CFiMawfkKeVFULw4ti3MdZL1QejPrzeJv8Q@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?DoGCxBGBOXDBHeKqha7uXg8T14lSVRdy0HWMGvvjMQdSadU7pgISKaVO4a?=
 =?iso-8859-1?Q?nMzhjtTMZSRyq/W3MlTzufdB1v++UMwFiyQRerdfO/EZahTTxubffq9Qeo?=
 =?iso-8859-1?Q?EUo2XZ4gbWzkWzDnJtW7C/8FdKtRCoqtWi4ZUwbB/Zr2eOFvA+q5nEFj+l?=
 =?iso-8859-1?Q?K9+H1Q780mwKGxFYiRsr50tmKjvXObOVWItieWankvfBh1GUHR5YQuNDWW?=
 =?iso-8859-1?Q?Jg62HiQNZ0gnBJspgHnrtMSMFUmsBvEV3TjOt+7POH6YU2Lceyj3WvNGQo?=
 =?iso-8859-1?Q?cWeKusdFlve5KuHD2Ij9Yup0BNtzlYRUpS7sVaBTSiAEFtdzg1ZwIthC38?=
 =?iso-8859-1?Q?JFz8tMTYM6/5X9y+FfEvuon6mIIYONmyTAlfcFXhdMgevZpf5ZIQvmSsVX?=
 =?iso-8859-1?Q?czBBL8PvYjE7+D38kSxJFszRcogILvQCapqVKycDN9kD8pheaofOrnoZ4B?=
 =?iso-8859-1?Q?PucF9Sy+ankM3p70qcgayvAcB2FKx75cxZWg080rmrjzhaiisr8+tJkEWu?=
 =?iso-8859-1?Q?KT6+4ioOJu82fzwF4e9i6t9Z1dOHzGRIn3IgrwyEnHnhcrYpztShAGOY/O?=
 =?iso-8859-1?Q?0FPaUStjaXjEWRPg3rit0LWdMvrv12Zt4750nvysBBZgoDA1C7BMa3/77c?=
 =?iso-8859-1?Q?r8Oze3XhLImeGalmSo/Fybx/Qy4R08bGEyQiPEVHtUSlaUsCgfe64k7qmG?=
 =?iso-8859-1?Q?+axXTEo89zqXz5syn0Z5sg/l/7vIWR/T4TeSFblYGXruv/h0TZv45JmUL1?=
 =?iso-8859-1?Q?zdtb7Dh7zCcIHmFiWtsJj0LSsiJSibLDlnvqU15Km/EKABMCVuFlocGlcB?=
 =?iso-8859-1?Q?U9XOcr0YObyOoBbow72F6V4DQ18YoKCaZUvytt5nTeRp2050eBz+SAgmuY?=
 =?iso-8859-1?Q?GNHAdeVXa5gZPTVeeMt77S/A1csceQxJYF0hbogMnsrLk+ZXpdzDwuq+fk?=
 =?iso-8859-1?Q?wrHkDLrsxALwN66bvSa54nktvPXxxq8btN7789vK/u+rvSBxS3ua9zoNH3?=
 =?iso-8859-1?Q?LTDeWiMmv25sftxPqdVTgskjlglGatpfdxIdDHNNl/QQH9K937JjtQwtck?=
 =?iso-8859-1?Q?2FK+p8TGUEO/FKjTj7yUi4FGCzBlp1GRmNBSSAN9gGKol6xEQVUuIeqsBj?=
 =?iso-8859-1?Q?I43YBOlJJ/laxSJyT1GHgeWxHEIs49vbBNL8eSBHID8HcDndlTzE4A5BOc?=
 =?iso-8859-1?Q?Sm6vWezu88HzOUxl0MVz714ttXgV1PXBocDaFJA9oGMy0p3JpuG/YROVJ1?=
 =?iso-8859-1?Q?3R/wNpJkuadqwKuOVLnkhp6WyE8YrH8t3KI9tDfA91weyu7bi+F4sI4Qui?=
 =?iso-8859-1?Q?Zpjl42j+ck1BlupA5OlpGGra1TC1o33GAyHaPTPgn29WIT1adDqpnANFGa?=
 =?iso-8859-1?Q?DXjys/GLBg2BRQ+8zuKOhsrPUAAHqlmUzfm/b3mHDwa92Qw/JcW5J7YGz+?=
 =?iso-8859-1?Q?Rk2sONAOxQoJhN1RV8L4weX0vhnxUmv3vRJiyZ4544I8D6tcV+bbMxnpCu?=
 =?iso-8859-1?Q?u6VLjmX9eR3v12OwrY9xN23HdpqpSaKyd1N9WHSMeTTOrycRZddQXOaNnL?=
 =?iso-8859-1?Q?wIL6tlbFbezKVKAkDqgFgQS1MLyNdfcvPhJbOq5wrR5B/sCfqMbaFCbKPT?=
 =?iso-8859-1?Q?VWhkyeUR3stB9iVmCaCv8/ZTA8JRcU02gP8GQeFeEfqdTnOjsxFYjthA?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <2A66C9C8B2206F46A4B3EF2536041487@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2573777c-60db-48f5-f46f-08da794fa822
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Aug 2022 15:07:05.6430
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Rrh1RrJeiKKQ0aC/UTj9cycrfrSqTKABPPjnWmiatAG6cUTsm/bqs387IGZNJK44OA9zezViP/gNrzEDWDxZXg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4556
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-08_10,2022-08-08_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 mlxlogscore=999
 spamscore=0 suspectscore=0 adultscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2208080073
X-Proofpoint-ORIG-GUID: NTUsi82EKfXh3Siwk9xJJEpsuUGGPehU
X-Proofpoint-GUID: NTUsi82EKfXh3Siwk9xJJEpsuUGGPehU
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Ondrej Mosnacek <omosnace@redhat.com> [220808 06:13]:
> Hello,
>=20
> FYI, since commit a43cfc87caaf ("android: binder: stop saving a
> pointer to the VMA") (found by git bisect) the binder test in
> selinux-testsuite [1] started to trigger a lockdep assert BUG() in
> find_vma() - see the end of [2] for an example.
>=20
> A minimal reproducer is:
> ```
> git clone https://github.com/SELinuxProject/selinux-testsuite.git
> cd selinux-testsuite/tests/binder
> make
> setenforce 0  # if SELinux is enabled
> ./init_binder.sh || true
> ./manager -n -v & sleep 2
> ./service_provider -n -v
> ```
> Requires the equivalent of libselinux-devel, make, gcc, and git-core
> Fedora packages.
> The last command will trigger the BUG; on good kernels it will
> successfully enter the ioctl loop.
>=20
> [1] https://github.com/SELinuxProject/selinux-testsuite/
> [2] https://s3.us-east-1.amazonaws.com/arr-cki-prod-datawarehouse-public/=
datawarehouse-public/2022/08/07/redhat:606549366/build_x86_64_redhat:606549=
366_x86_64/tests/5/results_0001/console.log/console.log
>=20

Thanks.  It looks like binder has some paths that are not taking the
necessary mmap lock for using VMAs.  I'm looking into it now.

Regards,
Liam