Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c4e26f69d38c4294038430487bf10e88fa980e0b.camel@kernel.org>
Subject: Re: [PATCH] cifs: Remove {cifs,nfs}_fscache_release_page()
From:   Jeff Layton <jlayton@kernel.org>
To:     David Howells <dhowells@redhat.com>, willy@infradead.org
Cc:     Steve French <smfrench@gmail.com>, linux-cifs@vger.kernel.org,
        samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Mon, 08 Aug 2022 10:51:29 -0400
In-Reply-To: <165996923111.209242.10532553567023183407.stgit@warthog.procyon.org.uk>
References: <165996923111.209242.10532553567023183407.stgit@warthog.procyon.org.uk>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.3 (3.44.3-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2022-08-08 at 15:33 +0100, David Howells wrote:
> Remove {cifs,nfs}_fscache_release_page() from fs/cifs/fscache.h.  This
> functionality got built directly into cifs_release_folio() and will
> hopefully be replaced with netfs_release_folio() at some point.
>=20
> The "nfs_" version is a copy and paste error and should've been altered t=
o
> read "cifs_".  That can also be removed.
>=20
> Reported-by: Matthew Wilcox <willy@infradead.org>
> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: Jeff Layton <jlayton@redhat.com>
> cc: Steve French <smfrench@gmail.com>
> cc: linux-cifs@vger.kernel.org
> cc: samba-technical@lists.samba.org
> cc: linux-fsdevel@vger.kernel.org
> ---
>=20
>  fs/cifs/fscache.h |   16 ----------------
>  1 file changed, 16 deletions(-)
>=20
> diff --git a/fs/cifs/fscache.h b/fs/cifs/fscache.h
> index aa3b941a5555..67b601041f0a 100644
> --- a/fs/cifs/fscache.h
> +++ b/fs/cifs/fscache.h
> @@ -108,17 +108,6 @@ static inline void cifs_readpage_to_fscache(struct i=
node *inode,
>  		__cifs_readpage_to_fscache(inode, page);
>  }
> =20
> -static inline int cifs_fscache_release_page(struct page *page, gfp_t gfp=
)
> -{
> -	if (PageFsCache(page)) {
> -		if (current_is_kswapd() || !(gfp & __GFP_FS))
> -			return false;
> -		wait_on_page_fscache(page);
> -		fscache_note_page_release(cifs_inode_cookie(page->mapping->host));
> -	}
> -	return true;
> -}
> -
>  #else /* CONFIG_CIFS_FSCACHE */
>  static inline
>  void cifs_fscache_fill_coherency(struct inode *inode,
> @@ -154,11 +143,6 @@ cifs_readpage_from_fscache(struct inode *inode, stru=
ct page *page)
>  static inline
>  void cifs_readpage_to_fscache(struct inode *inode, struct page *page) {}
> =20
> -static inline int nfs_fscache_release_page(struct page *page, gfp_t gfp)
> -{
> -	return true; /* May release page */
> -}
> -
>  #endif /* CONFIG_CIFS_FSCACHE */
> =20
>  #endif /* _CIFS_FSCACHE_H */
>=20
>=20

Reviewed-by: Jeff Layton <jlayton@kernel.org>