Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 8 Aug 2022 16:20:12 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     linux-kernel@vger.kernel.org, Andy Shevchenko <andy@kernel.org>,
        Lee Jones <lee@kernel.org>
Subject: Re: [RESEND][PATCH v1 8/9] mfd: intel_soc_pmic_bxtwc: Support IRQ
 chip hierarchy
Message-ID: <YvEprE7YwuwaMXwL@google.com>
References: <20220718122328.8287-1-andriy.shevchenko@linux.intel.com>
 <20220718122328.8287-8-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220718122328.8287-8-andriy.shevchenko@linux.intel.com>
Precedence: bulk

On Mon, 18 Jul 2022, Andy Shevchenko wrote:

No commit message.

Probably needs to justify why it's calling a function denoted for
internal use only.

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/mfd/intel_soc_pmic_bxtwc.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/intel_soc_pmic_bxtwc.c b/drivers/mfd/intel_soc_pmic_bxtwc.c
> index 8dac0d41f64f..f9842ff44b3f 100644
> --- a/drivers/mfd/intel_soc_pmic_bxtwc.c
> +++ b/drivers/mfd/intel_soc_pmic_bxtwc.c
> @@ -422,8 +422,10 @@ static int bxtwc_add_chained_irq_chip(struct intel_soc_pmic *pmic,
>  		return dev_err_probe(pmic->dev, irq, "Failed to get parent vIRQ(%d) for chip %s\n",
>  				     pirq, chip->name);
>  
> -	return devm_regmap_add_irq_chip(pmic->dev, pmic->regmap, irq, irq_flags,
> -					0, chip, data);
> +	return __devm_regmap_add_irq_chip(pmic->dev, pmic->regmap, irq,
> +					  irq_flags, 0,
> +					  regmap_irq_get_domain(pdata),
> +					  chip, data);
>  }
>  
>  static int bxtwc_probe(struct platform_device *pdev)

-- 
DEPRECATED: Please use lee@kernel.org