Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp4901999rwb; Mon, 8 Aug 2022 08:48:54 -0700 (PDT) X-Google-Smtp-Source: AA6agR4e6AVBxVmcIdXWvPmEPidCOn3u4Fy+jMmAoxspcJ/9VW8A9OKbb2nKE91hCVuiabyBMlz2 X-Received: by 2002:a05:6402:4282:b0:43e:612c:fcf7 with SMTP id g2-20020a056402428200b0043e612cfcf7mr18090629edc.242.1659973734575; Mon, 08 Aug 2022 08:48:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659973734; cv=none; d=google.com; s=arc-20160816; b=hzLbBP+KhdQPshW3O81Eht8+zFqEgsdV0hDiz1zgJ7FSxl7l9iL7M/R2Dzs0QCNjCn +tpCLp3EF2nBuIY6uG1ro5Mh9It+Pn9vrcz/nuNDsiNappz/20tn/VCfr+Lqii88IqPw fBURK4kZdP49qrlNewxZsB7FLR70mYhSRyv3zUbE39ufCYUrvAIvAAX05ZzhtWW3sG+1 EPM2r4Z1hg9OOQZs62PxF4nN9o4UXqxjUAMcXOzzw2NnfS0CnkDqDNDrSUcbEzt8YK6X dMssr//F0rG8QtpLY6Ifba/XcxL3Nz9YXfyRy9CSlk/XzDmImEqAJhb5oipTSV0VRWWw 16oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=bh9vtqVsqdtuRVtF0p+dDtPg259p3E95D1pLQvcru3w=; b=kx8TnQDeRCaUUtaAuDTNyEdXcxkw+s6t6CnrWQQasXsXjsd+YH7FX0RZ/J/oaDhFit GDFTNK8zLmC0HFNGSVgG4z/vfN7UbzQUwi05M+AKH8XJ/GAZsyUB7Ti7C7DsFHP5Q+fG IGeWunxT9s3kJoZZ17QKkUm6ZQDZmzmxbsYpqecKz43J8TFvMd3hC2Ktq20nX8k2Oqgs yeb6WknWlTWTndccn2KZaPwkeRyqScShb8ZBkxR0qcW/5Mgz2pbA4HCw08sCvp3F7peU S+LBKpfjoiBzBQ8Ci2OWRNO01++3Q7yWLcyADCKaZJSeVHm5fF6rtqS9Sm74KnLEqb39 SASA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=cq0MuZNj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xa14-20020a170906fd8e00b007308bf614f7si9574420ejb.512.2022.08.08.08.48.27; Mon, 08 Aug 2022 08:48:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=cq0MuZNj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243460AbiHHPpi (ORCPT + 99 others); Mon, 8 Aug 2022 11:45:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243400AbiHHPpe (ORCPT ); Mon, 8 Aug 2022 11:45:34 -0400 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0C5E224; Mon, 8 Aug 2022 08:45:33 -0700 (PDT) Received: by mail-qk1-x730.google.com with SMTP id 17so6727904qky.8; Mon, 08 Aug 2022 08:45:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=bh9vtqVsqdtuRVtF0p+dDtPg259p3E95D1pLQvcru3w=; b=cq0MuZNjL1Iosi7Dw8iy1M0vF630xTIQJG5rd0OZ9lwC1og/efLemVAc6kL8of945S fwOEOiveVvwp/2AJ9c5gMx7T29KMzoRYmOXu/LaDOxmLog87EDhQlY6DElzxNFskfNTf KWIJ6JcK0rQ6QjQJuJjGA5HL+JaNkGm4xHMu7w6e+QvArlZ6gHDlo4+0iX2YBA+2C7kL M3cRRgpfWMypuWLUpnDFGlA6UgxfhC0i1d3/8mEDQQiKvd0kkyfd3CkWWJ28ZsmgKsoO oo7kncJO0EjxdVSjxFHvkIYxPRdRtRRkdQ8DPyuC5HqT+SlxJngbo+FaAvC/5Rdq3Ziq FMVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=bh9vtqVsqdtuRVtF0p+dDtPg259p3E95D1pLQvcru3w=; b=twgGlGrNrSngSEATXP/vQ6ZHebq8nQKyV/40WxFrw2YBzBRIj6wO+btefewhBzxefm PN5K+pXX0ExhR6I7hB5eeMS5kjhPIbJ5yGLdDAECJQcYmne5aRH+3YikO2q2mIwGYh36 e9ZBnDWbJouZtRTXYQxE6lfjzqAzUF7hKum1dPAZK13BWa9KBW4vNzbLXYdhuvNYoTLv dh9VFr/jS7z7dinXDAY/UEm/QWDrgrXagg8V1Nse1M+Zs2lp18+mjIUhEycLydqm3sy+ 6cNs5KwQS29uPSvZsojTx4gV8yIAyESHFpXD8ojjbC7AbFbtYF4ICN39gp4fejtZhzNh XrMw== X-Gm-Message-State: ACgBeo1PLbij1VdqgSGuMbaQiPPJXhHk9k7KPDAIRUk7Nld/tOxYLySt ahofx41DsZPeKViHla2LEHrjtdL0UnLuqBXn7MM= X-Received: by 2002:ae9:e88d:0:b0:6b9:4a0b:cea5 with SMTP id a135-20020ae9e88d000000b006b94a0bcea5mr4324382qkg.748.1659973532761; Mon, 08 Aug 2022 08:45:32 -0700 (PDT) MIME-Version: 1.0 References: <20220808030420.8633-1-luke@ljones.dev> <20220808030420.8633-7-luke@ljones.dev> In-Reply-To: <20220808030420.8633-7-luke@ljones.dev> From: Andy Shevchenko Date: Mon, 8 Aug 2022 17:44:56 +0200 Message-ID: Subject: Re: [PATCH v2 6/6] asus-wmi: Add support for dGPU-only mode To: "Luke D. Jones" Cc: Hans de Goede , Mark Gross , Platform Driver , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 8, 2022 at 5:10 AM Luke D. Jones wrote: > > Adds support for a dGPU-only mode on some laptops where when enabled > the boot GPU is the dGPU, and the iGPU is not visible. the enabled boot (If I understood the intention correctly of the phrase) ... > +What: /sys/devices/platform//dgpu_only > +Date: Aug 2022 Not sure, I would put September for sure > +KernelVersion: 6.0 As in a parallel review it appears that this should be 6.1, merge window for 6.0 is ongoing and this series definitely is out of scope of it. > +Contact: "Luke Jones" > +Description: > + Set the dGPU to be the only GPU available: > + * 0 - Disable, > + * 1 - Enable, Since you mentioned the patch is wrong, the rest may not be reviewed. We will wait for a new version. -- With Best Regards, Andy Shevchenko