Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp4937807rwb; Mon, 8 Aug 2022 09:20:40 -0700 (PDT) X-Google-Smtp-Source: AA6agR6/rbZHvVvtlm1oqynmGsIYlDQUW7DS3593n6fRFfYiUFSjsiSpDUg8j9f7kBOtajdJWiS2 X-Received: by 2002:a17:902:da81:b0:16e:fdf4:ea79 with SMTP id j1-20020a170902da8100b0016efdf4ea79mr19076802plx.166.1659975640255; Mon, 08 Aug 2022 09:20:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659975640; cv=none; d=google.com; s=arc-20160816; b=ogsZgQxfp6NsLkoiq0ZMI3p8aIMmNO2o+PR51FXJDDJ2wnlm8+3z3Pbae6qFOmD9t/ RWseEcGw85+KhAQpPQ51/BF8SaZSvKhimnkcjKX2x/YQzB4pmlVlyZC7RGY4gn1LQYrQ idTk4SG/zEgMS6Lbs2VX6batFsJ4X9rx1rBxVJ307y2O7T3c6C/hALzZS6RYKnH8o12O W0SDNLfZuS0FOh6rbt0sbjiW8SD3AOzvz/xfM7I53lssSoN3Hs/N4jV1MLjw8JKPWjUU ePe2HYJpK2ZjPIOtk1X+ymN4prx04yxXuZAp/u7tUCqV0OPYLiQGTEneA4uczjx9m0YI gbEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=v2lgBXjNZtsYzCboM1GnlUy05vvC9EjJee5FKw0cYsQ=; b=ApoYdQEZVclkIlXIEkP8yu2zj3ymsS9o/SUvoQ6JYvK3J39kJDl/T43+pjnBBGjQQc TE0oCXQNK2IgWY9pOFfNhY5X8ibWyp37+p/1tp7JW3jSz3WTD2BjCxP59FKWDjvxTyEI lX5JlQzB1ow9OpSkqC+RmyvWxyqPMyploZe31PmOr5SmRtQKeDo9tcwocNJm02jFvlVz q+etwb+gAM28swy33hcEEP2Z7Zh/FYGILZCgUpPxSlp8Hi5EenplLy0Dfd4j+BOhIrPR 0LvnRbCcqK81BZBJX6OksgxQfD1Qxxe3b0Qjafl+AanEELHuw3LFBYbRI5lQnnn3F0lo FS0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mIHwvx+t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i62-20020a638741000000b00415b57a54b3si3564065pge.275.2022.08.08.09.20.21; Mon, 08 Aug 2022 09:20:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mIHwvx+t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243532AbiHHP4M (ORCPT + 99 others); Mon, 8 Aug 2022 11:56:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236569AbiHHP4K (ORCPT ); Mon, 8 Aug 2022 11:56:10 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24086A47B; Mon, 8 Aug 2022 08:56:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CEF8EB80FCD; Mon, 8 Aug 2022 15:56:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E36DC43149; Mon, 8 Aug 2022 15:56:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659974167; bh=v2lgBXjNZtsYzCboM1GnlUy05vvC9EjJee5FKw0cYsQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=mIHwvx+tj2BxsPEjBZ0vinsl4KXkSc+hUHjGOo+mlAFTJmKRMbMY/LMLgKCe1QNv4 nWVNNWJGt7Id3daVXh9gG0kGjCNCY90Ec8lpHmpiS1DGviiH1Ye9GbbRrGb+16XcTk luRIciiAM6aSFU/64rT51FuMNb4ojhjb2dLoLIYZ+W9kTOL0L7kKvRP7p2k9OZgB3Z GtVeNG5fVpg6X/jx4l8owP7xHWDcjmfsPc734Gi4Kp9fRvQ5uBJr6nArf2AwQYpBwM SN13eiIZoUhJYu5L0DT1feKn/7/6/FgwtFdgCYbKqZXXmX4XC/KvDmagMFJjHVaUCk W3BZthQ+6i1fg== Received: by mail-vk1-f179.google.com with SMTP id x128so1554356vke.3; Mon, 08 Aug 2022 08:56:07 -0700 (PDT) X-Gm-Message-State: ACgBeo0LKoPn+86gdnjt8QxyNSMi8FgwachBS1wcPtvnAN2QD9BgOtHz zZ3EmJYhrO/f1C0WUxy9g+VwzkqwBcXFCasTCg== X-Received: by 2002:a1f:2dc2:0:b0:377:84fa:dbe5 with SMTP id t185-20020a1f2dc2000000b0037784fadbe5mr8008232vkt.15.1659974166257; Mon, 08 Aug 2022 08:56:06 -0700 (PDT) MIME-Version: 1.0 References: <20220806163255.10404-1-markuss.broks@gmail.com> <20220806163255.10404-2-markuss.broks@gmail.com> In-Reply-To: <20220806163255.10404-2-markuss.broks@gmail.com> From: Rob Herring Date: Mon, 8 Aug 2022 09:55:54 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/3] drivers: serial: earlycon: Correct argument name To: Markuss Broks Cc: "linux-kernel@vger.kernel.org" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS , Hans de Goede , Andy Shevchenko ," <~postmarketos/upstreaming@lists.sr.ht>, phone-devel@vger.kernel.org, Jonathan Corbet , Ard Biesheuvel , Greg Kroah-Hartman , Jiri Slaby , Helge Deller , "Paul E. McKenney" , Borislav Petkov , Kees Cook , Andrew Morton , Randy Dunlap , Damien Le Moal , Thomas Zimmermann , Michal Suchanek , Javier Martinez Canillas , Arnd Bergmann , Maarten Lankhorst , Wei Ming Chen , Bartlomiej Zolnierkiewicz , Tony Lindgren , Linux Doc Mailing List , linux-efi , "open list:SERIAL DRIVERS" , Linux Fbdev development list , dri-devel Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 6, 2022 at 10:34 AM Markuss Broks wrote: > > The "node" argument is actually an offset, It's an offset to a node in the FDT. The fact that it is an offset is an internal implementation detail of the FDT format. So really, it's a handle to a node. 'node' is more descriptive to its purpose. > and it's also an "int", and not "unsigned long". Uh, no it's not. of_flat_dt_*() functions all take an unsigned long. Rob