Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220808030420.8633-1-luke@ljones.dev> <20220808030420.8633-6-luke@ljones.dev>
In-Reply-To: <20220808030420.8633-6-luke@ljones.dev>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 8 Aug 2022 18:13:08 +0200
Message-ID: <CAHp75VdgGgp2H906sQjhauzEGLp8Mr-2Hj9hKdkF9MPeOOCbLQ@mail.gmail.com>
Subject: Re: [PATCH v2 5/6] asus-wmi: Convert all attr-show to use sysfs_emit
To:     "Luke D. Jones" <luke@ljones.dev>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Aug 8, 2022 at 5:08 AM Luke D. Jones <luke@ljones.dev> wrote:
>
> This changes all *_show attributes in asus-wmi.c to use sysfs_emit

We refer to functions as func().

> instead of the older method of writing to the output buffer manually.

...

> -       return sprintf(buf, "%d\n", value < 0 ? -1 : value*100);
> +       return sysfs_emit(buf, "%d\n", value < 0 ? -1 : value*100);

While at it, put spaces around *: 'value * 100'.

-- 
With Best Regards,
Andy Shevchenko