Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 8 Aug 2022 17:15:28 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Patrice CHOTARD <patrice.chotard@foss.st.com>
Cc:     Alexandre Torgue <alexandre.torgue@foss.st.com>,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        linux-spi@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        christophe.kerello@foss.st.com, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] spi: stm32_qspi: Add transfer_one_message() spi
 callback
Message-ID: <YvE2oN7EDDFLlxyv@sirena.org.uk>
References: <20220808074051.44736-1-patrice.chotard@foss.st.com>
 <20220808074051.44736-3-patrice.chotard@foss.st.com>
 <YvEP15/7KmQGyPgL@sirena.org.uk>
 <bbe8f91e-35f4-fe80-4b6e-25d21a6547fc@foss.st.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="uC8gnb5PKUmB6mjc"
Content-Disposition: inline
In-Reply-To: <bbe8f91e-35f4-fe80-4b6e-25d21a6547fc@foss.st.com>
Precedence: bulk


--uC8gnb5PKUmB6mjc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Aug 08, 2022 at 06:09:51PM +0200, Patrice CHOTARD wrote:
> On 8/8/22 15:29, Mark Brown wrote:
> > On Mon, Aug 08, 2022 at 09:40:50AM +0200, patrice.chotard@foss.st.com wrote:

> >> +	ret = pm_runtime_get_sync(qspi->dev);
> >> +	if (ret < 0) {
> >> +		pm_runtime_put_noidle(qspi->dev);
> >> +		return ret;
> >> +	}

> > Use the core runtime PM, there should be no need to open code.

> Right, i will use pm_runtime_resume_and_get() instead.

There's also core SPI support for calling this - set auto_runtime_pm.

--uC8gnb5PKUmB6mjc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLxNp8ACgkQJNaLcl1U
h9AyFAf/c/JlPakgNi2pE4cLX1TuxOSGJ8lGkAMOizwJksSpHV6k+e1iN+dhc9NK
fSxOjFkXL6gKyzPwpoO1hgr09RdmibswfrpsqZ9S8YdZ3F2DTZusCayYJKM7qHku
Kjh8ZcTqk1rWhJqzMB6I6V+zRzJgvFkim48znIMJ1iNdkvHjS0NbTAhy3spmCR5D
yUu2eejgpD3rgKTMd92KOXKabBMUAcVekHCXOjVrcx3Z2Yr9C4X3+TXY6N3eh5SS
+v6OMOjAHGlv8msMj3t+b68Zt4+kQ0/IVnIRHenhU1rmOL3PAKH7+FtTFchVA0UT
PphizwOFmcTie/b8CHLMS32uIYEbKA==
=fz/n
-----END PGP SIGNATURE-----

--uC8gnb5PKUmB6mjc--