Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp4995858rwb; Mon, 8 Aug 2022 10:19:08 -0700 (PDT) X-Google-Smtp-Source: AA6agR4T9ZHM7JMtyaiDvounrlBAoLjyCae+E9MBAjaFK+Ksln45kyTzlOH1zb+e1UDU9/YuQUhI X-Received: by 2002:a63:353:0:b0:41d:eeb:aa5c with SMTP id 80-20020a630353000000b0041d0eebaa5cmr12561919pgd.90.1659979148639; Mon, 08 Aug 2022 10:19:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659979148; cv=none; d=google.com; s=arc-20160816; b=nse2w1/7ZortxkYRiQfx9VK4O34L2kDnQOYRqz4lw73uC3Ql2UdMLnCeWbiiY3RuIX csDENK7wNuO8fdligGlbky2q51PXaxUo+13Y7wnFa7nIjhbABNFHxr8v9jFoNLulYdKw GDj/hKKTpVGFp2VnTNXz7+hG4h6D3bYdQVFrrq8NqG1rfvBpTD0B74gFjOMNkXXAtehq qzCGg1rIgfQ2ia5+8/m6JzK5O6IW4A071Bik+u/X5PvpcWiF/vbxuDHjnG1xqFXLVa0v lHEBY1cuCuh6hnnQLNvI08Fus3yqBfIi45oRxG4nLcFIz8zdePHK1lB2EnmYQLWSD3y/ OYdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Q7OFE4V4aAbdglbeYKgCwEwCovM5XoI7VKTD2yBeEK8=; b=LIk6Ljr78z4mQKwTQAy7o22V3eqbLODIwKSNSoBNjW3C4bYQeytGUdbGbE38NB1wHt mZulGf+hWNXZ+r7NaHdUgclXKayfugk8A5uBlUyUqTN4nvn9ovFQYnaoZ1m3tARIbkAN 3WLXxxA0P9R/SPPND7zSThDdHiyqBdVkDDF3R1Ky8TT0PwH7pz1mOxZ++KqqsBiRTvRR wwkjNCl1/3Of7eCbEXNt+A+AfdcMIZP94M724Hgh242kjCmcpR+1gFo7MjeNKNa9YS6a nAaQstpR0SJQCaBUKauA2pkMyKdjKCm5QPlafm1ZcKNevu8QMafLwZe4WFKk+IvnyYkR PSJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Y4sOgoqg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y70-20020a62ce49000000b0052e486a9ffcsi11650727pfg.259.2022.08.08.10.18.53; Mon, 08 Aug 2022 10:19:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Y4sOgoqg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243400AbiHHQiT (ORCPT + 99 others); Mon, 8 Aug 2022 12:38:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244008AbiHHQiQ (ORCPT ); Mon, 8 Aug 2022 12:38:16 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C387E01E for ; Mon, 8 Aug 2022 09:38:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659976696; x=1691512696; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZdtKQDr/7hNuJqSsyBjbXL9BpkN6bXL5MCwDsuiI8z4=; b=Y4sOgoqg+GE3/HdGLRvf9zwJUIFuNIR2aVoyf7eNUjm0Rap4v/+5nZze ZVlRfI85TRZAIxmf6vNIzp6JyekL9hjn/ZnbiU8J9Tl03O0PZMAfXboWP rPMkgrBm7EaX05JNVgnwoiR0WmGAc3qP9L5pPwaSi9aodM3jfxrKot6nK LiOjsa8bzeTRuR4ruVWcG+mU0JaDVhlpZ5nuCb7UPTXwffW6l2knfq89v ibTmP3eGon+jFxlJ8cyd1eNBqnvWZSPU6M3V0J/zt9Y5KspruphxzykK9 iQ8zyX+elij7aNM+/C6zHABtIbpZ+3RpPEYY5oIcZqLTNCUzCyaLa2/Vx w==; X-IronPort-AV: E=McAfee;i="6400,9594,10433"; a="288202763" X-IronPort-AV: E=Sophos;i="5.93,222,1654585200"; d="scan'208";a="288202763" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2022 09:38:05 -0700 X-IronPort-AV: E=Sophos;i="5.93,222,1654585200"; d="scan'208";a="664030714" Received: from mkabdel-mobl.ger.corp.intel.com (HELO intel.com) ([10.249.40.190]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2022 09:38:00 -0700 Date: Mon, 8 Aug 2022 18:37:58 +0200 From: Andi Shyti To: Mauro Carvalho Chehab Cc: Niranjana Vishwanathapura , Andi Shyti , Tvrtko Ursulin , Thomas =?iso-8859-15?Q?Hellstr=F6m?= , Chris Wilson , Daniel Vetter , David Airlie , Jani Nikula , Joonas Lahtinen , Lucas De Marchi , Maarten Lankhorst , Matt Roper , Matthew Auld , Michael Cheng , Ramalingam C , Rodrigo Vivi , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] drm/i915: pass a pointer for tlb seqno at vma_invalidate_tlb() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mauro, On Thu, Aug 04, 2022 at 09:37:22AM +0200, Mauro Carvalho Chehab wrote: > WRITE_ONCE() should happen at the original var, not on a local > copy of it. > > Fixes: 5d36acb7198b ("drm/i915/gt: Batch TLB invalidations") > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Andi Shyti Are you going to send it to the stable mailing list? Andi