Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Khandelwal, Rajat" <rajat.khandelwal@intel.com>
To:     "pmalani@chromium.org" <pmalani@chromium.org>,
        "bleung@chromium.org" <bleung@chromium.org>,
        "groeck@chromium.org" <groeck@chromium.org>
CC:     "chrome-platform@lists.linux.dev" <chrome-platform@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Rao, Abhijeet" <abhijeet.rao@intel.com>
Subject: RE: [PATCH] platform/chrome: Adding support for visibility of alt
 modes under their respective 'active' attributes
Thread-Topic: [PATCH] platform/chrome: Adding support for visibility of alt
 modes under their respective 'active' attributes
Thread-Index: AdirVRLNn/pHkgH2S0CKDG6Mjchicw==
Date:   Mon, 8 Aug 2022 18:32:06 +0000
Message-ID: <CO1PR11MB48352BEA7C0C40F42BBB561196639@CO1PR11MB4835.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.500.17
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Rir+wv4w3UOG9IdIVFYptk5U4MB1biDk4C32zM3/T1DlsY7+2z0V9iSrL42W?=
 =?us-ascii?Q?5jqtu+EduSC8ZPpuY4J7fGZtMqagQR0syTKCWOScRTBXHrm7bhAyzWJBHALr?=
 =?us-ascii?Q?gQTb0kaCikJTFjtvW6JxlAt/R1wm+lXo1eoTegq1ovR6WuDfwYm1Of9Zsksd?=
 =?us-ascii?Q?ckhVcdhcKMMyiQpfJT7K961AKaXXo+ats9dDJ9SYGAKKkTpcScjDiTmjszVA?=
 =?us-ascii?Q?LuvXB2RL6oQqC62PkvjByTk/pHn1HbIh0HrD8Bd92uj+lR1uhWs3fpui/1eT?=
 =?us-ascii?Q?jX9/oID0PzPVT5mGaJqd4bY1c8EwFv18CMGF9Ei6M4HJ1FFa4opTYjeQnRHC?=
 =?us-ascii?Q?DJIA30F7Xt7wc2tXWOpCGTj60+qOoerJUCszwKDosA4BSvZjSloxuiOTlol3?=
 =?us-ascii?Q?jvosxrmxufReFOT0Le18v3V1t+MWL0xK8+C2Ov0IKwXl64ILRAxXtBNJNgy9?=
 =?us-ascii?Q?7c5quOMSiTQq1/0AD8le54GDMABtp1RbFLaEdC9HXNpleARWeJU7YvlqB2fN?=
 =?us-ascii?Q?dyKP+qTKdy4RlO8S8vKJPywr8VcyPgQuvVy0pB0lcOzVYvyoWcTTP/jMR+XB?=
 =?us-ascii?Q?Cb4MjXwZW3RqCf8/cCb+zVWt9L50ugBEQo01iyOWS83zHyE1xjNF6KyZSlqI?=
 =?us-ascii?Q?5gVjLxJrFA+B9uU2Hq/C1pkozeZ640YE+az0+1/YcrIDd9/jaxCp4XCCzRxn?=
 =?us-ascii?Q?VYrCboFXI3yERm92SC67ZF4uolLJ/1ZPuvdXaCwKu5INJlX11jcAcmHCYY9J?=
 =?us-ascii?Q?SZySVNg6m5PPpuZ0SYCTjR+MvJQzXJTzTBmLM5M5Bc5cAsK/x5gWddTqhRYP?=
 =?us-ascii?Q?Vu/cPi7kEl6Nn63+bbzKkFAmG+o6yP83mbAykbvzyCq9gAN5WegrVhZOQGEI?=
 =?us-ascii?Q?KSeGGyd+9oMj0Sz6oYxdMvCdXb1kiNtEQlq7w13KuZIZ6jPIXnqDxGNnuLRO?=
 =?us-ascii?Q?d079+6xR6rQLQjNeKP3HyGT9SMUh4vi06yVzkU9FCR3MSpN08fP/XDQXMhri?=
 =?us-ascii?Q?cKAgyoQ/I7wNEya6kkQueT7ecQSDYiZ95LLbH7Fb3WykHkNJoydMwlWS9ux2?=
 =?us-ascii?Q?jHrWHalit0BVSyvolYuHyYjRiprRv0Gc0JmNFdC+TRtgCCXgr1Y5GYxAH4j/?=
 =?us-ascii?Q?fJMA7T9ZqxFge2jMYCjAJFZyH7n8mIi8DVvqKhymbWJGwrMB0Yc3xPXFPmsm?=
 =?us-ascii?Q?fAt5MbVSzthADYPxdJRoTuR4+YVboi7FFwSegUEBs50sFDxxMhMOvsdv/ruH?=
 =?us-ascii?Q?hl3nzZqhP2aH3afYtechr+a2Vhpy3GBKvA1KzORLVTHr0kBlCWWvc2oGEEDT?=
 =?us-ascii?Q?qfHd4n0ZSmzj0Jy8eNKw804PezWzK4qqLq+9mkkiFiXWdZ5DWpx45frXHgwl?=
 =?us-ascii?Q?6yQTQA8eHtL1Zwb2wVe7jT3rHb/P+cZug8nrr8C63BwKOjadxkIT+yPtNreH?=
 =?us-ascii?Q?5QWgmFFLIHxB/oqb1kuy4MHjwIFd0bHEUjkPMnN+iUob1CYyRDYGN8ppwDQY?=
 =?us-ascii?Q?NK/f2hjHUUXD044nndt39rJY8CbFAPSWekZfDrItUxbbY0qVZuXJRUf0QTWS?=
 =?us-ascii?Q?6A6pTRoUP4s2RgeUFj3wm//601pnNH8MkDF/TXMFmgIncH7yQeqiyv7mO9K6?=
 =?us-ascii?Q?GQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4835.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a241e7a4-e463-4bb8-8961-08da796c4c0c
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Aug 2022 18:32:06.5196
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2NuuQwsRgsymhhpt4MKJfx7doebfonC2hccO+bnUOFomxLivInHnGJbbtd/YR2yTs7jJn0H6rGSHsN4FUe6b6h/tHg3sdrrwZECZTvt7B+0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1964
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Please consider the replied thread for review.=20

-----Original Message-----
From: Khandelwal, Rajat <rajat.khandelwal@intel.com>=20
Sent: Tuesday, August 9, 2022 3:19 AM
To: pmalani@chromium.org; bleung@chromium.org; groeck@chromium.org
Cc: chrome-platform@lists.linux.dev; linux-kernel@vger.kernel.org; Khandelw=
al, Rajat <rajat.khandelwal@intel.com>; Rao, Abhijeet <abhijeet.rao@intel.c=
om>
Subject: [PATCH] Adding support for visibility of alt modes under their res=
pective 'active' attributes

In the current implementation of cros-ec-typec driver, 'active'
attribute of type-C class doesn't reflect the current status of active
mode. It's hardwired to 'no'. This patch adds the functionality to
userspace.
After this patch:
localhost /sys/bus/typec/devices # cat port2-partner.1/active
yes
This was just an example of DP alt mode reflecting it's active status as
'yes', not 'no'
Same goes for TBT alt mode.

Let me know what you think of this as the userspace attribute currently
has no significance.

Signed-off-by: Rajat Khandelwal <rajat.khandelwal@intel.com>
---
 drivers/platform/chrome/cros_ec_typec.c | 52 ++++++++++++++++++-------
 1 file changed, 38 insertions(+), 14 deletions(-)

diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chr=
ome/cros_ec_typec.c
index 7cb2e35c4ded..0de221ea22db 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -32,6 +32,12 @@ enum {
 	CROS_EC_ALTMODE_MAX,
 };
=20
+/* Supported alt modes and their SVIDs */
+enum {
+	CROS_EC_ALTMODE_DP_SVID =3D 0xff01,
+	CROS_EC_ALTMODE_TBT_SVID =3D 0x8087,
+};
+
 /* Container for altmode pointer nodes. */
 struct cros_typec_altmode_node {
 	struct typec_altmode *amode;
@@ -514,25 +520,14 @@ static int cros_typec_enable_usb4(struct cros_typec_d=
ata *typec,
 }
=20
 static int cros_typec_configure_mux(struct cros_typec_data *typec, int por=
t_num,
-				struct ec_response_usb_pd_control_v2 *pd_ctrl)
+				struct ec_response_usb_pd_control_v2 *pd_ctrl,
+				struct ec_response_usb_pd_mux_info resp)
 {
 	struct cros_typec_port *port =3D typec->ports[port_num];
-	struct ec_response_usb_pd_mux_info resp;
-	struct ec_params_usb_pd_mux_info req =3D {
-		.port =3D port_num,
-	};
 	struct ec_params_usb_pd_mux_ack mux_ack;
 	enum typec_orientation orientation;
 	int ret;
=20
-	ret =3D cros_ec_command(typec->ec, 0, EC_CMD_USB_PD_MUX_INFO,
-			      &req, sizeof(req), &resp, sizeof(resp));
-	if (ret < 0) {
-		dev_warn(typec->dev, "Failed to get mux info for port: %d, err =3D %d\n"=
,
-			 port_num, ret);
-		return ret;
-	}
-
 	/* No change needs to be made, let's exit early. */
 	if (port->mux_flags =3D=3D resp.flags && port->role =3D=3D pd_ctrl->role)
 		return 0;
@@ -945,8 +940,14 @@ static void cros_typec_handle_status(struct cros_typec=
_data *typec, int port_num
=20
 static int cros_typec_port_update(struct cros_typec_data *typec, int port_=
num)
 {
+	struct cros_typec_port *port =3D typec->ports[port_num];
 	struct ec_params_usb_pd_control req;
+	struct ec_params_usb_pd_mux_info req_pd_mux =3D {
+		.port =3D port_num,
+	};
 	struct ec_response_usb_pd_control_v2 resp;
+	struct ec_response_usb_pd_mux_info pd_mux;
+	struct cros_typec_altmode_node *node, *n;
 	int ret;
=20
 	if (port_num < 0 || port_num >=3D typec->num_ports) {
@@ -966,8 +967,16 @@ static int cros_typec_port_update(struct cros_typec_da=
ta *typec, int port_num)
 	if (ret < 0)
 		return ret;
=20
+	ret =3D cros_ec_command(typec->ec, 0, EC_CMD_USB_PD_MUX_INFO,
+			      &req_pd_mux, sizeof(req_pd_mux), &pd_mux, sizeof(pd_mux));
+	if (ret < 0) {
+		dev_warn(typec->dev, "Failed to get mux info for port: %d, err =3D %d\n"=
,
+			 port_num, ret);
+		return ret;
+	}
+
 	/* Update the switches if they exist, according to requested state */
-	ret =3D cros_typec_configure_mux(typec, port_num, &resp);
+	ret =3D cros_typec_configure_mux(typec, port_num, &resp, pd_mux);
 	if (ret)
 		dev_warn(typec->dev, "Configure muxes failed, err =3D %d\n", ret);
=20
@@ -986,6 +995,21 @@ static int cros_typec_port_update(struct cros_typec_da=
ta *typec, int port_num)
 	if (typec->typec_cmd_supported)
 		cros_typec_handle_status(typec, port_num);
=20
+	list_for_each_entry_safe(node, n, &port->partner_mode_list, list) {
+		if (node->amode->svid =3D=3D CROS_EC_ALTMODE_DP_SVID &&
+		!(pd_mux.flags & USB_PD_MUX_DP_ENABLED))
+			typec_altmode_update_active(node->amode, false);
+		else if (node->amode->svid =3D=3D CROS_EC_ALTMODE_TBT_SVID &&
+		!(pd_mux.flags & USB_PD_MUX_TBT_COMPAT_ENABLED))
+			typec_altmode_update_active(node->amode, false);
+		else if (node->amode->svid =3D=3D CROS_EC_ALTMODE_DP_SVID &&
+		(pd_mux.flags & USB_PD_MUX_DP_ENABLED))
+			typec_altmode_update_active(node->amode, true);
+		else if (node->amode->svid =3D=3D CROS_EC_ALTMODE_TBT_SVID &&
+		(pd_mux.flags & USB_PD_MUX_TBT_COMPAT_ENABLED))
+			typec_altmode_update_active(node->amode, true);
+	}
+
 	return 0;
 }
=20
--=20
2.17.1