Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 8 Aug 2022 11:44:18 -0700
From:   Bjorn Andersson <bjorn.andersson@linaro.org>
To:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc:     Bhupesh Sharma <bhupesh.sharma@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
        bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org,
        robh@kernel.org, pavel@ucw.cz, devicetree@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH] dt-bindings: leds: Describe optional 'reg' property used
 for Qualcomm LPG nodes
Message-ID: <YvFZgr1RRq6tYaVC@ripper>
References: <20220721195502.1525214-1-bhupesh.sharma@linaro.org>
 <CAA8EJppGS38aP7gyd1c3kNgraAVJDoqUef2cDfZpu2aL_iwW0g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAA8EJppGS38aP7gyd1c3kNgraAVJDoqUef2cDfZpu2aL_iwW0g@mail.gmail.com>
Precedence: bulk

On Thu 21 Jul 13:19 PDT 2022, Dmitry Baryshkov wrote:

> On Thu, 21 Jul 2022 at 22:55, Bhupesh Sharma <bhupesh.sharma@linaro.org> wrote:
> >
> > As Bjorn noted in [1], it is useful to describe the optional
> > 'reg' property for Qualcomm LPG nodes as it is used in
> > some Qualcomm dts files.
> 
> I don't think this is correct. LPG block maps to several regions, so
> using just one of them in reg doesn't look correct.
> 

I agree, but I also like the uniformity of having unit addresses for the
devices on the spmi buses.

> > This fixes the following 'make dtbs_check' error reported for
> > pm8350c & sc8280xp pwm nodes:
> >
> > arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb:
> >  pwm@e800: 'reg' does not match any of the regexes:
> >  '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
> 
> I'd prefer to follow the existing schema and to drop the region from
> those files.
> 

I'm fine either way, but we have more of these nodes, so I would like to
hear from the DT maintainers on the direction to take. All nodes on the
spmi bus has an (at least one) address, so it would be accurate to state
this in the node.

It does however not seem like devicetree@, nor Krzysztof is Cc'ed on
this patch, so I've added them...

Regards,
Bjorn

> >
> > [1]. https://lore.kernel.org/linux-arm-msm/Ytg3tIaL5h5b9ewH@builder.lan/
> >
> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Cc: robh@kernel.org
> > Cc: pavel@ucw.cz
> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> > index fe336fa16518..f394ab7a757b 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> > @@ -27,6 +27,9 @@ properties:
> >        - qcom,pmi8994-lpg
> >        - qcom,pmi8998-lpg
> >
> > +  reg:
> > +    maxItems: 1
> > +
> >    "#pwm-cells":
> >      const: 2
> >
> > --
> > 2.35.3
> >
> 
> 
> -- 
> With best wishes
> Dmitry