Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1b92761a-c166-b84f-8d77-a966d4c0ef9a@gmail.com>
Date:   Mon, 8 Aug 2022 14:42:03 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.0
Subject: Re: [PATCH v5 27/32] PCI/P2PDMA: Convert to printbuf
Content-Language: en-US
To:     Bjorn Helgaas <helgaas@kernel.org>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc:     linux-kernel@vger.kernel.org, pmladek@suse.com,
        linux-pci@vger.kernel.org
References: <20220808175122.GA1215280@bhelgaas>
From:   Kent Overstreet <kent.overstreet@gmail.com>
In-Reply-To: <20220808175122.GA1215280@bhelgaas>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/8/22 13:51, Bjorn Helgaas wrote:
> I don't object to the patch, but it would be nice if the commit log
> hinted at what the advantage is.  I assume it's faster/safer/better in
> some way, but I have no idea what.

Printbufs have some additional features over seq_buf but they're not 
used here. The main one you might be interested in is heap allocation: 
that means no need to statically allocate buffers on the stack and no 
need to calculate the buffer size, printbufs will reallocate as necessary.

I generally haven't been converting code to use that unless it's obvious 
that we're in a context where it's safe to allocate memory and can deal 
with allocation failures.

I notice that in calc_map_type_and_dist() you're using xa_store() which 
can fail, but you're not checking for that or returning errors properly 
:) perhaps a fix for that could also switch to using printbuf in 
heap-allocation mode.

> Also, cpu_show_meltdown() doesn't appear in this patch, so maybe
> that's relevant to some other patch but not this one?

Whoops, was copying the commit message from another patch, yeah.n