Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Ondrej Mosnacek <omosnace@redhat.com>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Minchan Kim <minchan@kernel.org>,
        "Christian Brauner (Microsoft)" <brauner@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Hridya Valsaraju <hridya@google.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        Martijn Coenen <maco@android.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Todd Kjos <tkjos@android.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Linux kernel mailing list <linux-kernel@vger.kernel.org>,
        =?iso-8859-1?Q?Arve_Hj=F8nnev=E5g?= <arve@android.com>,
        Carlos Llamas <cmllamas@google.com>
Subject: Re: Binder regression caused by commit a43cfc87caaf
Thread-Topic: Binder regression caused by commit a43cfc87caaf
Thread-Index: AQHYqw+ISmpRZPmLpkiane2Iritf5K2lGuGAgABPlAA=
Date:   Mon, 8 Aug 2022 19:51:52 +0000
Message-ID: <20220808195146.im4diqaqnmxkzo5t@revolver>
References: <CAFqZXNtNjQLpzu4CFiMawfkKeVFULw4ti3MdZL1QejPrzeJv8Q@mail.gmail.com>
 <20220808150657.liop7yf5hsutbpp3@revolver>
In-Reply-To: <20220808150657.liop7yf5hsutbpp3@revolver>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ArpX6gv8eeFoGTf/7HpylZwBBYiRhg79Wi16S2CxkIgDH7Qvw0+s/hFiwt?=
 =?iso-8859-1?Q?r2GvwY5/Z89rCPHsP85VfhlFPpzjPU9nxCu1I1nkMaEjXlc4tVpiFd5blO?=
 =?iso-8859-1?Q?tm7K3dvJHxhh+YVFrZXU2x5FaOoEBv/W5truRoehnvU8bM76ogjAWDsUK6?=
 =?iso-8859-1?Q?hzOhUx8er0TqsqWkuyYt9H01BRwZ151qd21TzzykJt4jDYuHlYM1kVU9y4?=
 =?iso-8859-1?Q?DzrOHcJx7n2Ml3yQ2P+eGwoJ7hfaASqD/XLB0sBj1p6VCYw7TPzK+LyXdr?=
 =?iso-8859-1?Q?1+lwCy385/HjS65xw5Rv9eqBi6FEwpK/rleUEyUecu22qVrP4CgFGZx18X?=
 =?iso-8859-1?Q?suTPq5wOXHUeMG+1rq3B1w5Y+VrUjjm1EzWDI0PYSAbjctoU03GvIJ5u9w?=
 =?iso-8859-1?Q?j85Xfki4cK3geLADtDWFyTBBnxtwqKhvqDSqfKmLvLIBzcjHCl/bDYag6o?=
 =?iso-8859-1?Q?OzKhA5hJcvfwx9wZIItDURp9xB5qmm2xdUOARICs6bSOv4BC33Jv/5Q6uR?=
 =?iso-8859-1?Q?nLnd1Z026hqPhG/AvsVHMdAnCQYmob6sTkDCdCpCk0EF8SSWAyjpDS7JfX?=
 =?iso-8859-1?Q?1W4hKSpzkj+pWy1/eSmxM+jfsy+OqsL3RyZwEOFMKdskFF7QbVbc8/0jTs?=
 =?iso-8859-1?Q?RN/bVNPNeLmpB2AhLUnLu4H3MBykd1VFZBAVzNW+E5vk7s5ntwtYXg9uNo?=
 =?iso-8859-1?Q?eCe7tztz32B8zcy+US515dt81b0RrMy67I9Rg/vk17wUaUQUEpi9DvKZMi?=
 =?iso-8859-1?Q?KFFFc3JVl+VMbbwWY9HM2Fs42buHmeV+L8yCXskdtePAjmB82hvO/uVDYX?=
 =?iso-8859-1?Q?4OIZVqw+PI/h6PJlwbRRxobkuReW6HYqa2wh5Nh62Q/iDrWH+LJ6em1vMw?=
 =?iso-8859-1?Q?DppxR4g2ObUf6fV0zH9e8r81zUXfpbYJHI56ZZVXQgI3rl9vc3rx/78LGT?=
 =?iso-8859-1?Q?QE1p4FjsC+Il8bHer1vIp/NCrvCXPqwbPRupemYzLAg7VjXsN+MP5dTeys?=
 =?iso-8859-1?Q?r8nar71eg1iGWhyZJ/fQPaxJJHxWsAEL06v4VinpV/3VycpIcro0KPIH81?=
 =?iso-8859-1?Q?qYma9NjaRrhbglA9UijNVom/UnFQ8eIjHdk9wcZs7PxW9zPlkn8G65vG3B?=
 =?iso-8859-1?Q?HPpQu189+zBcGqgUV4FMv87/1UC/OrO365EbRr/6RAihZrZlfAkdnqAR3D?=
 =?iso-8859-1?Q?h03s/2YSN5PhOQi7cXNYHazD2QKt15NiCRmQ3qe5yU8h6Tp5HL3s6IiCiL?=
 =?iso-8859-1?Q?rUtUlIo44SpNFR9pgz3Ta2Xb9KlshqdTvqA3WwtYYsP7hWfsBMSM2WS+cq?=
 =?iso-8859-1?Q?naVqm7uy26FkSiAkzZAcdG0DeJds5lKEhOd05b+3aN3X+U3EoL7vI10gtH?=
 =?iso-8859-1?Q?jcnMXOQCsVExCBhDadMDufuN7xPq64OrKB12jdYOluFsgZm/CRhtpl4/PZ?=
 =?iso-8859-1?Q?eXmNKiSdh7wwCFHSefJP9mAOJd5s3bXRlkRX2oogBqHTE4xgqQRB7y7snN?=
 =?iso-8859-1?Q?dyfnia0giLPNjeQvbwL/Zl5xav0rkiKimV+6XvZ9mEy2/J1z20uFcM13wp?=
 =?iso-8859-1?Q?rep0g5cnXRZYnA+Iog6KDtXRFtXk6l/Uryu66c8Xjbg6SvxHFhBRVf9BPo?=
 =?iso-8859-1?Q?noZTnzDl0Li804hg4d+8MbgwaxA7dma1H0tIPYboGZMZZwZIke/QMckg?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <6E29A34D11C567458DF03715926F73CF@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 44c433c2-2c57-4470-86b6-08da797770fd
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Aug 2022 19:51:52.9610
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AS75wUowcEmknMZlyG/Xmm8SzUyl/TTPnZp8fTpUVOffHcL4tkpnNmN3N2erbqRo+WerxTT+3egyQr/2v46+fQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4513
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-08_13,2022-08-08_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999
 phishscore=0 malwarescore=0 suspectscore=0 adultscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2208080087
X-Proofpoint-ORIG-GUID: Bzn_CtP0Y5LT8_d4Vjbov0rIMIPmtKOX
X-Proofpoint-GUID: Bzn_CtP0Y5LT8_d4Vjbov0rIMIPmtKOX
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Liam R. Howlett <Liam.Howlett@Oracle.com> [220808 11:07]:
> * Ondrej Mosnacek <omosnace@redhat.com> [220808 06:13]:
> > Hello,
> >=20
> > FYI, since commit a43cfc87caaf ("android: binder: stop saving a
> > pointer to the VMA") (found by git bisect) the binder test in
> > selinux-testsuite [1] started to trigger a lockdep assert BUG() in
> > find_vma() - see the end of [2] for an example.
> >=20
> > A minimal reproducer is:
> > ```
> > git clone https://github.com/SELinuxProject/selinux-testsuite.git
> > cd selinux-testsuite/tests/binder
> > make
> > setenforce 0  # if SELinux is enabled
> > ./init_binder.sh || true
> > ./manager -n -v & sleep 2
> > ./service_provider -n -v
> > ```
> > Requires the equivalent of libselinux-devel, make, gcc, and git-core
> > Fedora packages.
> > The last command will trigger the BUG; on good kernels it will
> > successfully enter the ioctl loop.
> >=20
> > [1] https://github.com/SELinuxProject/selinux-testsuite/
> > [2] https://s3.us-east-1.amazonaws.com/arr-cki-prod-datawarehouse-publi=
c/datawarehouse-public/2022/08/07/redhat:606549366/build_x86_64_redhat:6065=
49366_x86_64/tests/5/results_0001/console.log/console.log
> >=20
>=20
> Thanks.  It looks like binder has some paths that are not taking the
> necessary mmap lock for using VMAs.  I'm looking into it now.

This does not fail for me, are you sure this is the reproducer?  I see
the manager and service_provider communicate.

Looking at your trace and the code, the bug makes sense and I have
something that will probably fix the issue, but I'd like to verify.

Thanks,
Liam=