Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Stephen Brennan <stephen.s.brennan@oracle.com>
To:     Baoquan He <bhe@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Dave Young <dyoung@redhat.com>, linux-kernel@vger.kernel.org,
        Stephen Brennan <stephen.s.brennan@oracle.com>,
        Vivek Goyal <vgoyal@redhat.com>, kexec@lists.infradead.org
Subject: [PATCH] vmcoreinfo: add kallsyms_num_syms symbol
Date:   Mon,  8 Aug 2022 13:54:10 -0700
Message-Id: <20220808205410.18590-1-stephen.s.brennan@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?r7wZ0EIu2orZQ/RX5IXzc0wbTQN0L9AolcL54PFfwODUxHGUQMCQABfhEUx4?=
 =?us-ascii?Q?Ohqby4ND9s8lyTQcP1cTrYQ2l38AQ1RbdkbZmTdeFB5zG/tZSIW21cdGVFkY?=
 =?us-ascii?Q?o5qVNglWZAzkNKkhjUb7wNhAN5ernJwcWxbGnT4Mya/mp5n30hI1wbmptXHp?=
 =?us-ascii?Q?g/YG8MVk+zbqK+iFf9ZuAS2pI7iWXKCK/c5gORiQYbegUG59dSVdkkSaTKYM?=
 =?us-ascii?Q?QxvmiLiNAVAlRcZVF+k942LhRwmUCKEl6baYYlbdD4zGUDuezC4awvUYj//f?=
 =?us-ascii?Q?tGc3eNDAiohnMzXeAWwpgT/yem4AE57/8cohQklaXkVwqtgn2cFrvz3CULeA?=
 =?us-ascii?Q?Bw8prfVnethzJUe41RWGryFJI8Iy1mZ6oS0FyYoJaV6GABbXLXMop3yRKLew?=
 =?us-ascii?Q?ZoIgJyD/Z5RQkxO/ra/MYxDRi9/vZOcriYWMrirQCjbXCjcHm3ZDUym9bcsR?=
 =?us-ascii?Q?Xr2x7vsLMVSSdT/CVSnEAbbW+bFYcsdCm1k5dqAdACVU4FIJNor8N36bBlOP?=
 =?us-ascii?Q?+gdDuF394SQw95XaNK7aYMDVWPS+j+gpkbYza8gA1R+OOcVsLgntKde9kWli?=
 =?us-ascii?Q?gYT2WvT+lvmnpuY/5ztP4cGA3jpEYJ70kyBm3BIbR6Xd8+uwONZifsLRWZ1F?=
 =?us-ascii?Q?JAGMe9nW54++520vT2F2fpcUTGx0oQujqw4UQKD7/O091cDt+knMXIa3uTzm?=
 =?us-ascii?Q?BO9T9kccCfLpYvFJOo4EIj4Z78QDldTQLi+NNswXtosQ5tmEc98wfBYWG70B?=
 =?us-ascii?Q?nbb+POFH6V5H7CxfgD/Kg8ybo+hJ3saCliiInR8wN0PQLz/Mxz+Ua6pO8uRK?=
 =?us-ascii?Q?wcAxDfr3so5Z61kk/n0eeDGUtJr6fxuIZqAD8AmEHgYu1Mzu35yepNPNbgaX?=
 =?us-ascii?Q?qFTu10ymJw0SHJc97ztUq5BneHjKGfE3/xz04iGZ6JDAwg5+WVMsNehNhFRR?=
 =?us-ascii?Q?i/9/L9GZZX/AP0pAjMBcnHTWLFGEwpwNDujvpsz+GhjZjlab9fFUbbWElQG5?=
 =?us-ascii?Q?s/Hl5hj32AlOYs8uK4xQtJVTfK1sidzKtV8oKlC85bYyR5zVZk9wmWIpP72K?=
 =?us-ascii?Q?Hk4iwsHP5D3xzrIgU1vzFx/LPiNWNcpAHDTy7bIifT6YyzHyQAbuVfjhqZuB?=
 =?us-ascii?Q?QJvMm225by+Xyx4TK1iOBwRPXxUFJM/vJPFigAYuHOozdI/LmA9BZ9xz/B0I?=
 =?us-ascii?Q?pXcPxS244P/zNpk4702us54S61oRHek7ALb14AmDXYdIniA5kowK0qkY2mYh?=
 =?us-ascii?Q?RyxR0gpnWeE4nYqaef+molvX1CW8/EYj23M7emGCOHRimz/yovcmXaDu99Bo?=
 =?us-ascii?Q?PYMSWJQGN91v7y+PgHvR6BSH0d1Oo2HsA5NP0XX9B5lb3iqLexjF9AxuhNj2?=
 =?us-ascii?Q?I7C9ZeUME/w6mw0ImwePdHepm2otAJ2YTAwPULOD7zP7gflsba8rVK3lEP9c?=
 =?us-ascii?Q?lB/nvxe9ZBB3vUsHW8GbUY4U1fMn6RRUIxn0NA4olYspgLYzsUPLLHjaieNf?=
 =?us-ascii?Q?+CEoWthxBnGg7S/RAwXFYPdzqVeHLe9DvbiXJ8oIj6WU8Xr0+OQ7v0hg6xA8?=
 =?us-ascii?Q?Er+C7n2hLLilC6g131ThnefjoHY7DovtLW4QFhj0YMXVKFVrgVKPjo6xsgJ9?=
 =?us-ascii?Q?Pg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88ffa492-8a06-4ffd-33f9-08da79802599
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4166.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2022 20:54:12.1157
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1q+2CTFLTrYXi366YDvFneDkQhh4D9AcD1pUJosvqV6YS9vS0c3eUhFShqEyQI0OXrkbCOmihOVXbSU3A/oPs9x5/UD13CBM6dVrFqRKxdE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6248
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-08_13,2022-08-08_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 adultscore=0
 bulkscore=0 phishscore=0 suspectscore=0 spamscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2208080091
X-Proofpoint-ORIG-GUID: WGVH38OtDlyXo3kOIysKENdSMvkgzm28
X-Proofpoint-GUID: WGVH38OtDlyXo3kOIysKENdSMvkgzm28
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The rest of the kallsyms symbols are useless without knowing the number
of symbols in the table. In an earlier patch, I somehow dropped the
kallsyms_num_syms symbol, so add it back in.

Fixes: 5fd8fea935a1 ("vmcoreinfo: include kallsyms symbols")

Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
---
Hi Baoquan & Andrew,

I made a silly omission in the above mentioned commit, which just got merged
via Andrew's non-mm pull request yesterday. I must have dropped it as I
cherry-picked between versions. Would you be able to queue this up with whatever
fixes you'll send for the 6.0 rc's?

Thanks, and sorry!
Stephen

 kernel/crash_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/crash_core.c b/kernel/crash_core.c
index 07b26df453a9..a0eb4d5cf557 100644
--- a/kernel/crash_core.c
+++ b/kernel/crash_core.c
@@ -494,6 +494,7 @@ static int __init crash_save_vmcoreinfo_init(void)
 
 #ifdef CONFIG_KALLSYMS
 	VMCOREINFO_SYMBOL(kallsyms_names);
+	VMCOREINFO_SYMBOL(kallsyms_num_syms);
 	VMCOREINFO_SYMBOL(kallsyms_token_table);
 	VMCOREINFO_SYMBOL(kallsyms_token_index);
 #ifdef CONFIG_KALLSYMS_BASE_RELATIVE
-- 
2.34.1