Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <86b63b7b-afda-d7f4-7bfa-175085d5a8ef@gmail.com>
Date:   Tue, 9 Aug 2022 02:53:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
To:     jaschultzms@gmail.com
Cc:     benjamin.tissoires@redhat.com, biju.das.jz@bp.renesas.com,
        bjorn.andersson@linaro.org, catalin.marinas@arm.com,
        corbet@lwn.net, devicetree@vger.kernel.org, dmanti@microsoft.com,
        dmitry.baryshkov@linaro.org, dmitry.torokhov@gmail.com,
        geert+renesas@glider.be, jaschultz@microsoft.com, jikos@kernel.org,
        krzysztof.kozlowski+dt@linaro.org,
        linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        marcel.ziswiler@toradex.com, robh+dt@kernel.org,
        shawnguo@kernel.org, vkoul@kernel.org, will@kernel.org
References: <20220707165902.3184-1-jaschultzMS@gmail.com>
Subject: Re: [PATCH v5 0/6] Add spi-hid, transport for HID over SPI bus
Content-Language: en-US
From:   Maximilian Luz <luzmaximilian@gmail.com>
In-Reply-To: <20220707165902.3184-1-jaschultzMS@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/7/22 09:58, Jarrett Schultz <jaschultzms@gmail.com> wrote:
> Surface Duo devices use a touch digitizer that communicates to the main
> SoC via SPI and presents itself as a HID device. This patch's goal is to
> add the spi-hid transport driver to drivers/hid. The driver follows the
> publically available HID Over SPI Protocol Specification version 1.0.

As far as I can tell based on the downstream code you provide in [1],
your proposed driver (and v1.0 spec) is incompatible with the version
used on current Surface devices (Surface Duo 1 and 2, Surface Pro X, and
I assume some AMD/x86 based devices on which you also use spi-hid for the
digitizer). On those, SPI_HID_SUPPORTED_VERSION is 0x0100 whereas it is
0x0300 for the driver proposed here, along with at least some protocol
struct changes.

Do you have any plans on supporting those devices (i.e. protocol version
0x0100) at some point?

Regards,
Max

[1]: https://github.com/microsoft/surface-duo-oss-kernel.msm-5..4/tree/surfaceduo2/11/2022.108.8/drivers/hid/spi-hid