Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ryan Chen <ryan_chen@aspeedtech.com>
To:     Andrew Jeffery <andrew@aj.id.au>, Joel Stanley <joel@jms.id.au>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
CC:     BMC-SW <BMC-SW@aspeedtech.com>
Subject: RE: [PATCH v3 2/3] dt-bindings: i2c-ast2600: Add bindings for AST2600
 i2C driver
Thread-Topic: [PATCH v3 2/3] dt-bindings: i2c-ast2600: Add bindings for
 AST2600 i2C driver
Thread-Index: AQHYaPENO2grG+HzSECGUwldbn2ojq2VE+oAgAAINMCAAARRAIAGqoiggApywoCAAAVaIA==
Date:   Tue, 9 Aug 2022 00:59:01 +0000
Message-ID: <SEZPR06MB5269B2ACF6D765E214FD6DF2F2629@SEZPR06MB5269.apcprd06.prod.outlook.com>
References: <20220516064900.30517-1-ryan_chen@aspeedtech.com>
 <20220516064900.30517-3-ryan_chen@aspeedtech.com>
 <5d863bc1-4f27-48b6-89ab-c3f02bc09057@www.fastmail.com>
 <SEZPR06MB5269DFE2CF762B62846D315EF2999@SEZPR06MB5269.apcprd06.prod.outlook.com>
 <4c4462a6-e950-48cb-b9ba-822909a86867@www.fastmail.com>
 <SEZPR06MB52695BDBE90ECE00DB2D9684F29D9@SEZPR06MB5269.apcprd06.prod.outlook.com>
 <cd11b517-ae6c-4a67-9f43-74825812b00b@www.fastmail.com>
In-Reply-To: <cd11b517-ae6c-4a67-9f43-74825812b00b@www.fastmail.com>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KCQUrVk7AlGe7NGw1Yh5q/d0SZgAE2J9RsfeYuaCalYosoJEs5nWtt/0FAhp?=
 =?us-ascii?Q?XLZ6GJyMVTfDvmHUhZa+OnE+DL5/vzc2q3egresIe0IL/eS/BTzFn6nQQGhD?=
 =?us-ascii?Q?+s0RJGI9E82DWMFKK4KcfGRJfYiiF34R4W5ZsvV6xZ9ByeGJMSm9W6KdZuSI?=
 =?us-ascii?Q?PxdVe7HepjgnqJ3Gn2MrDecU0tM6enmw9paYyjltnLlZeSDv1EF7l7/Sw//a?=
 =?us-ascii?Q?ZfUREPWpxgAbfF3Z6+5CCymyhTTymB4QIgnEdZNakdFiwhRoAubUHGIJtmso?=
 =?us-ascii?Q?kZqGz8J027ww3NLquwF1l/hLH0LqyVE3CnCasVYtZXWe5ERGszRl40+zFw/B?=
 =?us-ascii?Q?wmWefHvDjGhVK2z+vusBYUyQyi7JGzDKS7aFWeCmAI82nAho9nMWMbQCDN9/?=
 =?us-ascii?Q?XC2/K3JYzrFB+M1k+KYJx/SxfgmwT8yiUdvT8fFPIDWhYusPaI57hcmh16PY?=
 =?us-ascii?Q?oVWdg0t7M3aueJB+oFovIYK2vH0uuVQb50X6PKyIxtxCUVtnqJv/wRncXTdT?=
 =?us-ascii?Q?uxCT0QWqf+tJZWXxnqBO5LHtGuUlJg6s+Z2mJ8SsVhnlYqThbt4vRq+KgD6c?=
 =?us-ascii?Q?Xf9m8JuZ/nlOqW58GpTZ5czzgk/1bmHljZThb6dkrINwOJTFCXxGO7K6CZkG?=
 =?us-ascii?Q?3QGp0fB9XwDaIfdqRkWlZR6VQpD71OPJ5s2vG8Zf3tIBI4tByDjd8TSO9QrH?=
 =?us-ascii?Q?ySnhvJWiXQYVethVJBIvG7RxFxNT60U5DBkGXN8WOmLqW58gHoA1Lt7LfSI8?=
 =?us-ascii?Q?A6PIpRWZZkvKSHjQaByLNhhgEnEnwLBl5PbG0gkIHfeGyEABaPiRtb29UYuR?=
 =?us-ascii?Q?83C6xr3srXxQ6mI9t8yK2BDuULKKbVaSpi459s0A+WyIltXjYeJ0pY3ykUJU?=
 =?us-ascii?Q?qvl/MqKLKb7x6bAefxfjs63I0IgtGzqTYh6aGhoi9W6iuR7fSsRqlsLIX+zW?=
 =?us-ascii?Q?jK+C6RwKErBHd45FW7EtNFwTBBxfnZUQndxmeqGD5yp31D5Xi815k04CDo8+?=
 =?us-ascii?Q?RoAV4nd97/nL3FygWcGskZ3razi/j6MRGL1eihIYfLrHrWSiMwEiLvWZbiOy?=
 =?us-ascii?Q?s8wtala7nfYoACBf9eNECAgPNI+Ezfh2H0H1uFluLagiOZ81V5kZ7jIeKVk9?=
 =?us-ascii?Q?2zGkbZhg0dSJJikfQIi2nw/jfprk1QLJoZ9snX8oHVoAMpHRppXBLlaVNigq?=
 =?us-ascii?Q?LnB3ol9yTXTCIpHtU4Wj6ZYtEeAkRzysY4JRL03w3INO9Wk2mrbq/6+NT51i?=
 =?us-ascii?Q?C93pmwO4CU3R0nuGOLDobwye8FSqrH40yJh4hYKwTVR3oO0pJAjWKD0S2Lod?=
 =?us-ascii?Q?Bwj8jlFC5ie58RQ2h9I9qYoHH7D3C+SrSfWovR7BbgOPIaJxzxw9pbfWhi6x?=
 =?us-ascii?Q?cyH8GXsD/xP60qIWYgtUnt8A69ghf2fNegvjAAO6DJ4pVrmlC/DRwnU1aUSb?=
 =?us-ascii?Q?HTCkkNHDCYQeI5E5au1tDtzPeQLXq4Uink2JfGjUUzsOnFnzDLqSgaTYApas?=
 =?us-ascii?Q?0h07c2WWaVSnQs8QtTcgYQQcevFpE8Q0p/LrDTa3Cp54Di2bJJQjNI9sY5Yh?=
 =?us-ascii?Q?615sxZqKEYxCH2fkuTMURYCvMwyPDKZletYh0IBM+yyZQ0sMXYqrtalzuaV2?=
 =?us-ascii?Q?TA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d2b56357-fe90-47e6-ec8b-08da79a25900
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2022 00:59:01.0617
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5WZoMp5PxE28WhPFZn8Lm1ws5lBWlfVomIACzBPfbiSsBn1Hm1sMtTztevfPh+0hy8s+VmAkJDmLC/oM6qpe2pZSW0l6QsY3R29pNE0SWQo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4297
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

> -----Original Message-----
> From: Andrew Jeffery <andrew@aj.id.au>
> Sent: Tuesday, August 9, 2022 8:35 AM
> To: Ryan Chen <ryan_chen@aspeedtech.com>; Joel Stanley <joel@jms.id.au>;
> Philipp Zabel <p.zabel@pengutronix.de>; linux-arm-kernel@lists.infradead.=
org;
> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org;
> openbmc@lists.ozlabs.org
> Cc: BMC-SW <BMC-SW@aspeedtech.com>
> Subject: Re: [PATCH v3 2/3] dt-bindings: i2c-ast2600: Add bindings for AS=
T2600
> i2C driver
>=20
>=20
>=20
> On Tue, 2 Aug 2022, at 18:34, Ryan Chen wrote:
> > Hello,
> >
> >> -----Original Message-----
> >> From: Andrew Jeffery <andrew@aj.id.au>
> >> Sent: Friday, July 29, 2022 11:13 AM
> >> To: Ryan Chen <ryan_chen@aspeedtech.com>; Joel Stanley
> >> <joel@jms.id.au>; Philipp Zabel <p.zabel@pengutronix.de>;
> >> linux-arm-kernel@lists.infradead.org;
> >> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org;
> >> openbmc@lists.ozlabs.org
> >> Cc: BMC-SW <BMC-SW@aspeedtech.com>
> >> Subject: Re: [PATCH v3 2/3] dt-bindings: i2c-ast2600: Add bindings
> >> for AST2600 i2C driver
> >>
> >>
> >>
> >> On Fri, 29 Jul 2022, at 12:33, Ryan Chen wrote:
> >> > Hello Andrew,
> >> >
> >> >> -----Original Message-----
> >> >> From: Andrew Jeffery <andrew@aj.id.au>
> >> >> Sent: Friday, July 29, 2022 10:29 AM
> >> >> To: Ryan Chen <ryan_chen@aspeedtech.com>; Joel Stanley
> >> >> <joel@jms.id.au>; Philipp Zabel <p.zabel@pengutronix.de>;
> >> >> linux-arm-kernel@lists.infradead.org;
> >> >> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org;
> >> >> openbmc@lists.ozlabs.org
> >> >> Cc: BMC-SW <BMC-SW@aspeedtech.com>
> >> >> Subject: Re: [PATCH v3 2/3] dt-bindings: i2c-ast2600: Add bindings
> >> >> for AST2600 i2C driver
> >> >>
> >> >> Hi Ryan,
> >> >>
> >> >> On Mon, 16 May 2022, at 16:18, ryan_chen wrote:
> >> >> > +    i2c0: i2c-bus@80 {
> >> >> > +      #address-cells =3D <1>;
> >> >> > +      #size-cells =3D <0>;
> >> >> > +      #interrupt-cells =3D <1>;
> >> >> > +      compatible =3D "aspeed,ast2600-i2c-bus";
> >> >>
> >> >> This isn't quite right with respect to your binding description
> >> >> above
> >> >> :)
> >> > Yes, the compatible need to be " aspeed,ast2600-i2c" is that your po=
int ?
> >>
> >> Yes, but only if we agree that we should have different compatibles
> >> for the different drivers. I'm not convinced about that yet.
> >>
> >> I think it's enough to have different Kconfig symbols, and select the
> >> old driver in aspeed_g4_defconfig, and the new driver in
> >> aspeed_g5_defconfig. Won't that gives us the right outcome without
> requiring a new set of compatibles?
> >>
> > The new driver in aspeed_g5_defconfig.
>=20
> Right, behind a new Kconfig option.
>=20
> > And different compatible string
> > claim will
> > Load the new or legacy driver,
>=20
> I don't think we need this. It's enough to enable the new driver in the d=
efconfig
> (and possibly disable the config option for the old driver).
>=20
> > it should ok like the different
> > generation SOC. Have
> > different design.
> > Am I right?
>=20
> We have SoC-specific compatibles already, so the new driver can just bind=
 on
> the compatibles for the SoC revisions that have the new register interfac=
e. The
> old driver just binds to the device in the SoCs that have the old registe=
r
> interface.
>=20
> There's an overlap in support between the two drivers, but for people who=
 care
> about which implementation they use they can choose to exclude that drive=
r
> from their kernel config.
>=20
> None of this requires more compatibles be added.
>=20
> Does that help?

The kernel device tree driver use compatibles string to separate the driver=
,=20
like currently aspeed_g5_defconfig include the ast2500/ast2600.
So use dtsi/dts to separate which driver to loaded. Use can use dts to choi=
ce which=20
driver to loaded.

So keep the dtsi/dts for user implement to loaded should be good, right?

>=20
> Andrew