Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp5470442rwb; Mon, 8 Aug 2022 20:46:35 -0700 (PDT) X-Google-Smtp-Source: AA6agR6hiD+gicMPBbPexHSAiXLQB084Jx3me9zKVz+aQbnhhgg4dGuhHgZZSpCow5iZztsKaOaT X-Received: by 2002:a17:902:d544:b0:170:874f:f6df with SMTP id z4-20020a170902d54400b00170874ff6dfmr15522808plf.41.1660016795629; Mon, 08 Aug 2022 20:46:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660016795; cv=none; d=google.com; s=arc-20160816; b=qwT6wdMnJ7UiExnmu9RC29oeCnElPmJuvdo0HaGFg4tScowExuckk/lqdpNPxqvoD+ HujA43FuFpijPQCX4wyc9UB8/ca0D/bBQTqEgqnIhJkeKP0SKblZoMQzZOUELGYLsIuJ 8LA+DZfejOG+MdprkEqHVL4/AK4yyOa0nwxOOjCF5Q+aCGJSYqGQ9QsDVrL4FpzL1SCH jFeaYuJjgvlVsYwBmKWu5G7TWdmjaQQB3iQwpNYDM/qkpocRChhuIwsNw53hbYE357i8 CEgv38YYALBf2QYmmRo2QsxZBMe6EvOpZcwIiStNfitmvpt48094X73ZBYd4iFX722cI r1oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=FMiiSOQ7kFpCQRP4V7zdvtOcbS3P4Kj5FE/+dqNg378=; b=gt6w4KZbsm5Ge/sgc/zDKo2256lmv1FwTeq1+dWBOhaRwF57nuHTs7UBI2EQi+ywjt psQTQwE5KNM/M8EZBrR9rlmNRmrOdgRPQt6TSwINt6jimewHkdwX/UM/eAFtmppHqUmt 4Ki3p0c0ZWZAFS85HRKr2xcMIAnPnN3b7nlSylr3lop49xju9kudQEFFnxZgS25fvSco EbwrZVr32FxtVUQJHQpmmD3v+089Ehbly864JCF+V/Dv9vCHSUaAn+uLA+XZK0XSKP5z F830nyZQS0VJUr5tzBDk7knIJhG2L/EPcz/otgo25+ELiKAD22QQPKIzgV2QU0XX5/+B 49Xw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 32-20020a630d60000000b0041a4f693412si12540984pgn.134.2022.08.08.20.46.18; Mon, 08 Aug 2022 20:46:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231984AbiHIDoG (ORCPT + 99 others); Mon, 8 Aug 2022 23:44:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229600AbiHIDoE (ORCPT ); Mon, 8 Aug 2022 23:44:04 -0400 Received: from out30-43.freemail.mail.aliyun.com (out30-43.freemail.mail.aliyun.com [115.124.30.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1181A1DA43; Mon, 8 Aug 2022 20:44:01 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R551e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=13;SR=0;TI=SMTPD_---0VLoAmLY_1660016628; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VLoAmLY_1660016628) by smtp.aliyun-inc.com; Tue, 09 Aug 2022 11:43:59 +0800 From: Jiapeng Chong To: agross@kernel.org Cc: bjorn.andersson@linaro.org, konrad.dybcio@somainline.org, amitk@kernel.org, thara.gopinath@gmail.com, rafael@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] thermal/drivers/qcom/spmi-adc-tm5: Remove unnecessary print function dev_err() Date: Tue, 9 Aug 2022 11:43:46 +0800 Message-Id: <20220809034346.128607-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The print function dev_err() is redundant because platform_get_irq() already prints an error. ./drivers/thermal/qcom/qcom-spmi-adc-tm5.c:1029:2-9: line 1029 is redundant because platform_get_irq() already prints an error. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1846 Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c index add6f40e5e2a..af68adf720cc 100644 --- a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c +++ b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c @@ -1025,10 +1025,8 @@ static int adc_tm5_probe(struct platform_device *pdev) adc_tm->base = reg; irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "get_irq failed: %d\n", irq); + if (irq < 0) return irq; - } ret = adc_tm5_get_dt_data(adc_tm, node); if (ret) { -- 2.20.1.7.g153144c