Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <20a349c9-a479-ad5b-fe33-4758a773972e@linaro.org>
Date:   Tue, 9 Aug 2022 08:58:50 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] dt-bindings: marvell: Update Armada 37xx platform
 bindings
Content-Language: en-US
To:     =?UTF-8?Q?Pali_Roh=c3=a1r?= <pali@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220713200123.22612-1-pali@kernel.org>
 <20220808202352.iimhb2q6yawi35y6@pali>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220808202352.iimhb2q6yawi35y6@pali>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 08/08/2022 23:23, Pali Rohár wrote:
> PING?
> 
> On Wednesday 13 July 2022 22:01:23 Pali Rohár wrote:
>> Distinguish between Armada 3700 family, Armada 3710 SoC and Armada 3720 SoC.
>> Armada 3720 DB is name of the board with Armada 3720 SoC, so correctly
>> indicate SoC in example.
>>
>> Signed-off-by: Pali Rohár <pali@kernel.org>
>> ---
>>  .../devicetree/bindings/arm/marvell/armada-37xx.txt        | 7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt b/Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt
>> index f6d6642d81c0..d2ca008de266 100644
>> --- a/Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt
>> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt
>> @@ -4,6 +4,11 @@ Marvell Armada 37xx Platforms Device Tree Bindings
>>  Boards using a SoC of the Marvell Armada 37xx family must carry the
>>  following root node property:
>>  
>> + - compatible: must contain "marvell,armada3700"
>> +
>> +In addition, boards using the Marvell Armada 3710 SoC shall have the
>> +following property before the previous one:
>> +

The change is an ABI break, which looks reasonable, but still platform
maintainer should comment on it. Especially on the aspect why the
marvell,armada3710 fallback was chosen at the first place.

Unfortunately none of Marvel folks were CCed here, so you will need to
resend it. Otherwise no one will apply it, regardless of our ack.

Best regards,
Krzysztof