Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f0c0d56e-5cbc-4337-6339-778883393b1c@huawei.com>
Date:   Tue, 9 Aug 2022 09:28:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: soundwire qcom slimbus dependency (was Re: [PATCH 0/2] arm64
 defconfig: Get faddr2line working)
From:   John Garry <john.garry@huawei.com>
To:     Arnd Bergmann <arnd@arndb.de>, Jonathan Marek <jonathan@marek.ca>
CC:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Olof Johansson <olof@lixom.net>, "SoC Team" <soc@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Vinod Koul <vkoul@kernel.org>
References: <1658681004-132191-1-git-send-email-john.garry@huawei.com>
 <CAK8P3a0umWWic6LAzxXJ7BACYVE--m-wbynh7Z8F+pGoUBxGTA@mail.gmail.com>
 <25237c44-ebc4-fc9a-7c6f-3e990f968038@huawei.com>
 <CAK8P3a2+0EwSJ=fRBL2JCGypJRL-qE4rEiXYnJbqhZ=weethdQ@mail.gmail.com>
 <b39bf8c4-c702-8f49-12aa-d3ac05889b80@huawei.com>
 <CAK8P3a0w+_MLOjJAKMENe6MYvBcXWXSir47Hz34WbtdEeAmaBw@mail.gmail.com>
 <4d010f40-6c4c-32c7-2772-1bbfa02c03b7@linaro.org>
 <CAK8P3a38uGGGLA4b2bi=v8cV6-dH5yEcvBYcwr5ChzkwMTX9_Q@mail.gmail.com>
 <966a62da-52b6-1789-13d6-5fe06b62c7fe@marek.ca>
 <CAK8P3a2HGYJZvcXM+9fROys5A6c40zFWD2qATT4xssSJf6hRfQ@mail.gmail.com>
 <dba4385e-87ef-01ee-af59-6daade4a9a24@huawei.com>
In-Reply-To: <dba4385e-87ef-01ee-af59-6daade4a9a24@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 04/08/2022 11:35, John Garry wrote:
>>>>           ctrl->cols_index = sdw_find_col_index(data->default_cols);
>>>> -#if IS_REACHABLE(CONFIG_SLIMBUS)
>>>> -       if (dev->parent->bus == &slimbus_bus) {
>>>> -#else
>>>> -       if (false) {
>>>> -#endif
>>>> +       if (IS_ENABLED(CONFIG_SLIMBUS) && dev->parent->bus == 
>>>> &slimbus_bus) {
>>>>                   ctrl->reg_read = qcom_swrm_ahb_reg_read;
>>>>                   ctrl->reg_write = qcom_swrm_ahb_reg_write;
>>>>                   ctrl->regmap = dev_get_regmap(dev->parent, NULL);
>>>>
>>>
>>> This relies on the compiler optimizing out the reference to slimbus_bus,
>>> which doesn't exist in the CONFIG_SLIMBUS=n case (not tested, but I
>>> think this means an O0 build will fail?).
>>
>> That is correct: We rely on this everywhere in the kernel, which is why
>> it is impossible to build kernels with -O0.
>>
> 
> Was there any patch sent to fix/improve this? I could not see any. Or 
> any plan to do so?

Since I got no response, I'll assume 'no'. So I'll look to do this when 
I get a chance.

Thanks,
John