Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\))
Subject: Re: [PATCH 1/3] dt-bindings: sound: Add Apple MCA I2S transceiver
From:   =?utf-8?Q?Martin_Povi=C5=A1er?= <povik+lin@cutebit.org>
In-Reply-To: <cbe80ae1-3ae8-eccf-89f7-4506e3f44ca7@linaro.org>
Date:   Tue, 9 Aug 2022 10:55:35 +0200
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Philipp Zabel <p.zabel@pengutronix.de>, asahi@lists.linux.dev,
        alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <C55ADB0F-0894-4A3B-BDD2-6A20BB1F4A4F@cutebit.org>
References: <20220808224153.3634-1-povik+lin@cutebit.org>
 <20220808224153.3634-2-povik+lin@cutebit.org>
 <8ce59940-f559-35cb-5f86-37399da166a1@linaro.org>
 <DCBCB694-F5A3-4E76-9518-89E9A1A4AB55@cutebit.org>
 <cbe80ae1-3ae8-eccf-89f7-4506e3f44ca7@linaro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Precedence: bulk


> On 9. 8. 2022, at 10:47, Krzysztof Kozlowski =
<krzysztof.kozlowski@linaro.org> wrote:
>=20
> On 09/08/2022 11:40, Martin Povi=C5=A1er wrote:
>>> Describe the items because otherwise you allow any order. The list =
will
>>> be unfortunately quite long, but still readable enough.
>>=20
>> Well, I would assume the =E2=80=98dmas=E2=80=99 property as described =
above has an implicit
>> natural order, and the dma-names are tied to it. You order it like =
the other
>> per-cluster properties, and then within the cluster the order is =
fixed to
>> 'TXA, RXA, TXB, RXB=E2=80=99 (maybe the word =E2=80=98respectively=E2=80=
=99 thrown into the description
>> would have made it clearer).
>>=20
>> Anyway that=E2=80=99s just discussing my assumptions. I can roll out =
the items list
>> for =E2=80=98dma-names=E2=80=99, if that=E2=80=99s what you mean. Or =
do you mean explicitly describing
>> the items in =E2=80=98dmas=E2=80=99 too?
>=20
> The text description of 'dmas' does not mean it will be followed by =
DTS
> author. In current bindings DTS author can therefore put any order of
> dmas/dma-names. Unrolling the dma-names forces this order to be fixed
> and validated by dtschema.

OK

>>=20
>>>> +    description: |
>>>> +      Names for the DMA channels: 'tx'/'rx', then cluster number, =
then 'a'/'b'
>>>> +      based on the associated SERDES unit.
>>>> +
>>=20
>> (...)
>>=20
>>>> +
>>>> +additionalProperties: false
>>>> +
>>>> +examples:
>>>> +  - |
>>>> +    mca: mca@9b600000 {
>>>=20
>>> You called it I2S transceiver but isn't it also actually I2S =
controller?
>>> If yes, then the node name should be probably "i2s".
>>=20
>> It=E2=80=99s a peripheral you use to transmit and receive samples =
over I2S, frankly
>> I don't know the nomenclature.
>=20
> Looking at other devices, it's i2s.

OK, thanks.

> Best regards,
> Krzysztof

Best,
Martin