Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220809033048.1634583-1-luke@ljones.dev> <20220809033048.1634583-3-luke@ljones.dev>
In-Reply-To: <20220809033048.1634583-3-luke@ljones.dev>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 9 Aug 2022 10:40:31 +0200
Message-ID: <CAHp75VeAMBM+itfAn8hRDykV9rRLGXzck8L2kBgpGkVRsPUm5g@mail.gmail.com>
Subject: Re: [PATCH v3 2/2] asus-wmi: Add support for ROG X13 tablet mode
To:     "Luke D. Jones" <luke@ljones.dev>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Aug 9, 2022 at 5:31 AM Luke D. Jones <luke@ljones.dev> wrote:
>
> Add quirk for ASUS ROG X13 Flow 2-in-1 to enable tablet mode with
> lid flip (all screen rotations).

...

>         { KE_IGNORE, 0xC6, },  /* Ambient Light Sensor notification */
>         { KE_KEY, 0xFA, { KEY_PROG2 } },           /* Lid flip action */
> +       { KE_KEY, 0xBD, { KEY_PROG2 } }, /* Lid flip action on ROG xflow laptops */

Shouldn't you keep it sorted by value?

...

>  #define NOTIFY_KBD_FBM                 0x99
>  #define NOTIFY_KBD_TTP                 0xae
>  #define NOTIFY_LID_FLIP                        0xfa
> +#define NOTIFY_LID_FLIP_ROG            0xbd

Ditto.

...

> +static void lid_flip_rog_tablet_mode_get_state(struct asus_wmi *asus)
> +{
> +       int result;
> +
> +       result = asus_wmi_get_devstate_simple(asus, ASUS_WMI_DEVID_LID_FLIP_ROG);
> +       if (result >= 0) {

You missed the second part of my comment. Please, read carefully _all_
reviewer's comments.

> +               input_report_switch(asus->inputdev, SW_TABLET_MODE, result);
> +               input_sync(asus->inputdev);
> +       }
> +}

...

Overall, it's getting better!

-- 
With Best Regards,
Andy Shevchenko