Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] mtd_blkdevs: add mtd_table_mutex lock back to
 blktrans_{open, release} to avoid race condition
To:     ChristophHellwig <hch@lst.de>
Cc:     MiquelRaynal <miquel.raynal@bootlin.com>,
        RichardWeinberger <richard@nod.at>,
        VigneshRaghavendra <vigneshr@ti.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20220809075753.21950-1-liwei.song@windriver.com>
 <20220809080809.GB14727@lst.de>
From:   Liwei Song <liwei.song@windriver.com>
Message-ID: <7f925359-69b0-49b1-cdbb-337912da4f9c@windriver.com>
Date:   Tue, 9 Aug 2022 17:03:41 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20220809080809.GB14727@lst.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aG5NdGVHNXk3MythWXU5YTU5dWVhL2MvL2xwQmY4RWJpSmYydzJNTE1GN1Nj?=
 =?utf-8?B?Y1hQTlJjNGJCZ09hZmRKNFdVS1daZlFVRytMWEkwT1Z2Qk9QcVJUUjZkSDhI?=
 =?utf-8?B?OUMyTHdLOHFiK1Njb080RThWTGZtTjJad3pWMDlYNGZ1YkFGTkZxb1NWalZU?=
 =?utf-8?B?b1pBcG1UNEkzZkliTGtlTnpqYVM2ak1LbmlJbitDUEhWNzM1T1I3NURRWDNE?=
 =?utf-8?B?M0pNLzVlTXFBc0Q3QTFmREk5bXVXR0NqdVduME91SGtwdEt2WTFSeWNkSUdh?=
 =?utf-8?B?YW04a2U1eXRYSWk0eDRzU2N5ZVFHUGVlQ0cvTmlnUXJQZGE0a0ZDVkduV1Uy?=
 =?utf-8?B?THFzMmFjblcwUlorcXhvTkpIU01SVVhLL1N5QU9IVzQ2KzBGRHRyUHJXUUtO?=
 =?utf-8?B?RmxjUGVUTGIzZExxZVVQcXYwOXJuQ1NmeTdlc09GR2xaenpoNTVERGxrd2Yw?=
 =?utf-8?B?SUtHMDU2LzhPNFJ6amZ4NytEY2J4ZkJmMWZsRVFOYWJzQWVtNUFVTEREZkhh?=
 =?utf-8?B?ZUJpc0pDTG5XaTJpcVFOTXc4eWN1L09PQ0ZaK3RyQU5FN2JYclBTZitYdGFy?=
 =?utf-8?B?K253ZVpmeGdmNTBqd21vNXJMWElrUEFnYnVoY3l0eWJ4R3BVTmtId1ZaOXlu?=
 =?utf-8?B?dUVlWnluNngvRzR5Tm8wTHNDOTZFeVJLdmJGUTVURFpadEhVWGZPUmEySUEv?=
 =?utf-8?B?SHBHMDdlSFU2WmJ0UWNYbnNBYmxQbEpFeWdEbDhIVE0rZ1dkaERBdlp4b21k?=
 =?utf-8?B?UlJVdFVraitDTHFnbW9aR1hnYit0dU9jMXZXRUl4b0RCbUZ1WSsvVFNQSzgw?=
 =?utf-8?B?TjRweUtFajlMUWZkNG11U1BEcTZFUWtJWG1XVG1jTU8zYVd3QXJoNW5MUXRv?=
 =?utf-8?B?SVA1WVFkQkN5ek50Q0FsSUZoclg2VE0wdVB1Nks4UE4wWVJVQXdEb2NmekhP?=
 =?utf-8?B?Z1J6K0xpQjNiQm85NFk0NnNmUmpCSXVuc2hyNkZCVGFSL1JpZWNoT3VidTNs?=
 =?utf-8?B?enhGUnZOVnZpSGRjKzRGbGdaQTJXTlQ1WjdMMFUvSjM0RjNIV0RaNXVLSXZX?=
 =?utf-8?B?WjBXQ1lnaWhqOUVCSFZBaCtTMUdXbjUvSkZqNm9kamdDVjZSREFmdStlNmpZ?=
 =?utf-8?B?Q0FzNm1wT1VpVUVKQUdIMDZmd3hZK3BhalF4OUZacWRVVnZobjc1bU44S2ds?=
 =?utf-8?B?MmtMOFAxdjVjSU9HZTVBdG1pOUd0bzBoMUZtRlNLL3Z2bVFlN3JCckl3NUox?=
 =?utf-8?B?WUE0Y2xBNGh6NWdWNUw4ZFAyRTFLRU1mSTF3QnBFL2V6QzhFeDdUR0w3RkxB?=
 =?utf-8?B?bUFYY2hYeTBKeVY3QURKdDg2NzNoUTJ3R05yY0w0Z3hXVmUxdjYvaytrUlRj?=
 =?utf-8?B?NTE3QUloZVJ3RHkrTzFDODB1VVFVeW5ENWRFZ2lpbTFBOWZaR2ppU2ZXN1Ra?=
 =?utf-8?B?WEhLK0J3K1NhMHkzUktDS2x0MzNISDBiYjY5WW1xa1RvQWhSWkZBcnppdlZl?=
 =?utf-8?B?dXlmSXhQNTNjaytrVkliM2RqOVY3NHhXNGo5WlpQelZsaEVFVzJDem01c0Yr?=
 =?utf-8?B?ZXR6dVpteDlwblVJSks0aWtveGgwNjRWMFo5R1VEanRXMFZncmtKTU9NUmF1?=
 =?utf-8?B?emtLSkNNelVnRiszTkZHejhCOVIvT2E4NzM3UUN1QmcweFlHOUxQRm4rMzhZ?=
 =?utf-8?B?QUpmVm9UNk1YSjNTQ2c4SnhLckgwQnJBNnVpZlBwTmJ2VHpZS1NZZnFud2h5?=
 =?utf-8?B?UExOV0R2cWptYnhwV3BTNGlSemRkTklER0RacXQvazFjK3NDQlRJQnAxZjl3?=
 =?utf-8?B?RS9pbkVMY05IYVpOTWNUK3BkOGJPdFZDa1liQ3VJKzg5azJ4R29aVUhaNU5a?=
 =?utf-8?B?NFkyaFgzb2NJdTY5UHI0OTlXbGtmOC9yRUhOOUMrVDh4V25UVlBkTUYrZEhH?=
 =?utf-8?B?d0oybDk2cFdFWm1lQjJiak5YQ29xT1VRWVU3SDFFK2I1ZmsrN0hXMGRSRW53?=
 =?utf-8?B?ekRRc0VtZ2ZqdUJnQ1BZWUE1OFh5bTJRRkFhc2QvQ2cwVXdWL2R5bm1paWha?=
 =?utf-8?B?aFBIUmtsQVU3K21Ka1lXODk2aEhpZHZMMDM1VjQ2N3pmSG1NcFZRS0JOQUdJ?=
 =?utf-8?B?b3NRNlpvOTBzdDhISXExTTQwMm1XRkxpcHlzY1NYT1MwT2NBTE5CejdJZmV0?=
 =?utf-8?B?RlE9PQ==?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6eafbb9e-3a2f-450a-ce70-08da79e62f53
X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5348.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2022 09:04:37.0745
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RaG6tvRjPiQQOZ+61ToapM0wkxIVpc1zBTXg6VwVgtqx95ABc2410JP5/y8u+4DAEHUce6fpoSGUxHp1gZRxYRbZ6iSmCKso7ZQf7lWH7E4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4272
X-Proofpoint-GUID: xUUPy97R1ViKErwmEPEodwwDRdOVWoY-
X-Proofpoint-ORIG-GUID: xUUPy97R1ViKErwmEPEodwwDRdOVWoY-
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-09_03,2022-08-09_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015
 bulkscore=0 phishscore=0 priorityscore=1501 mlxlogscore=947 spamscore=0
 impostorscore=0 lowpriorityscore=0 suspectscore=0 mlxscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2208090040
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/9/22 16:08, ChristophHellwig wrote:
> On Tue, Aug 09, 2022 at 03:57:53PM +0800, Liwei Song wrote:
>> without lock mtd_table_mutex in blktrans_{open, release}, there will
>> be a race condition when access devices /dev/mtd1 and /dev/mtdblock1
>> at the same time with a high frequency open and close test:
>>
>> kernel BUG at drivers/mtd/mtdcore.c:1221!
>> lr : blktrans_release+0xb0/0x120
> 
> This does not seem on a current mainline kernel and seems to be
> a somewhat incomplete backtrace.  Can you send the full dmesg of
> a latest mainline run and maybe share the reproducer?

Yes, the kernel I used is 5.15, unfortunately this is the latest version
that worked on my board, the whole log is:

[   31.301343] ------------[ cut here ]------------
[   31.301343] ------------[ cut here ]------------
[   31.301365] kernel BUG at drivers/mtd/mtdcore.c:1221!
[   31.314981] kernel BUG at drivers/mtd/mtdcore.c:1221!
[   31.329328] Internal error: Oops - BUG: 0 [#1] PREEMPT SMP
[   31.374117] Modules linked in: 8021q sch_fq_codel openvswitch nsh nf_conncount nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 fuse
[   31.395820] CPU: 2 PID: 390 Comm: a.out Not tainted 5.15.58-yocto-standard #1
[   31.412672] Hardware name: SoCFPGA Agilex SoCDK (DT)
[   31.427372] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[   31.444058] pc : __put_mtd_device+0x4c/0x84
[   31.457977] lr : put_mtd_device+0x3c/0x5c
[   31.464122] sp : ffff80000c26bc50
[   31.466126] x29: ffff80000c26bc50 x28: ffff000285785100 x27: 0000000000000000
[   31.471945] x26: 0000000045585401 x25: 0000000000000000 x24: ffff000285785768
[   31.477762] x23: ffff0002803ee520 x22: ffff0002804f8900 x21: ffff000281956800
[   31.483580] x20: ffff000281956800 x19: ffff000281955080 x18: 0000000000000000
[   31.489402] x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000
[   31.495219] x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000
[   31.501037] x11: 0000000000000000 x10: 0000000000000000 x9 : ffff8000088a79b0
[   31.506855] x8 : ffff80000c26bcb0 x7 : 0000000000000000 x6 : 0000000000000001
[   31.512673] x5 : ffff000280959488 x4 : 0000000000000000 x3 : 0000000000000000
[   31.518491] x2 : ffff000281956800 x1 : 00000000ffffffff x0 : ffff000281955080
[   31.524310] Call trace:
[   31.525450]  __put_mtd_device+0x4c/0x84
[   31.527979]  put_mtd_device+0x3c/0x5c
[   31.530333]  mtdchar_close+0x3c/0x84
[   31.532604]  __fput+0x78/0x220
[   31.534357]  ____fput+0x1c/0x30
[   31.536193]  task_work_run+0x88/0xc0
[   31.538467]  do_notify_resume+0x384/0x12a0
[   31.541261]  el0_svc+0x6c/0x80
[   31.543015]  el0t_64_sync_handler+0xa4/0x130
[   31.545977]  el0t_64_sync+0x1a0/0x1a4
[   31.548338] Code: b9448841 51000421 b9048841 36ffff41 (d4210000) 
[   31.553115] ---[ end trace 9652b26ea1d7daa1 ]---
[   31.556420] Internal error: Oops - BUG: 0 [#2] PREEMPT SMP
[   31.556420] note: a.out[390] exited with preempt_count 1
[   31.560588] Modules linked in: 8021q sch_fq_codel openvswitch nsh nf_conncount nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 fuse
[   31.575265] CPU: 3 PID: 391 Comm: a.out Tainted: G      D           5.15.58-yocto-standard #1
[   31.582466] Hardware name: SoCFPGA Agilex SoCDK (DT)
[   31.586115] pstate: 40000005 (nZcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[   31.591757] pc : __put_mtd_device+0x4c/0x84
[   31.594642] lr : blktrans_release+0xb0/0x120
[   31.597603] sp : ffff80000c22bc20
[   31.599608] x29: ffff80000c22bc20 x28: ffff000285785e80 x27: 0000000000000000
[   31.605428] x26: 0000000045585401 x25: 0000000000000000 x24: ffff0002857864e8
[   31.611247] x23: ffff0002803ee520 x22: ffff0002803e3470 x21: ffff0002803e3400
[   31.617066] x20: ffff0002803e3020 x19: ffff000281955080 x18: 0000000000000000
[   31.622884] x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000
[   31.628702] x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000
[   31.634519] x11: 0000000000000000 x10: 0000000000000000 x9 : ffff8000088b0230
[   31.640337] x8 : ffff80000c22bb90 x7 : 0000000000000000 x6 : 0000000000000001
[   31.646155] x5 : 0000000000000000 x4 : 0000000000000000 x3 : 0000000000000000
[   31.651973] x2 : ffff000281956800 x1 : 00000000ffffffff x0 : ffff000281955080
[   31.657792] Call trace:
[   31.658933]  __put_mtd_device+0x4c/0x84
[   31.661462]  blktrans_release+0xb0/0x120
[   31.664077]  blkdev_put+0xd4/0x210
[   31.666175]  blkdev_close+0x34/0x50
[   31.668355]  __fput+0x78/0x220
[   31.670108]  ____fput+0x1c/0x30
[   31.671943]  task_work_run+0x88/0xc0
[   31.674217]  do_notify_resume+0x384/0x12a0
[   31.677009]  el0_svc+0x6c/0x80
[   31.678762]  el0t_64_sync_handler+0xa4/0x130
[   31.681723]  el0t_64_sync+0x1a0/0x1a4
[   31.684082] Code: b9448841 51000421 b9048841 36ffff41 (d4210000) 
[   31.688857] ---[ end trace 9652b26ea1d7daa2 ]---
[   31.692161] note: a.out[391] exited with preempt_count 1

the testcase  a.out is compiled from below code:
when run the case /dev/mtd1 and /dev/mtdblock1 will be used for open and close test.

#include <stdio.h>
#include <stdlib.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <string.h>
#include <signal.h>
#include <unistd.h>

int main(int argc, char *argv[])
{
    pid_t pid, pid1, pid2;
    int fd,ret = 0;
    int status = 0;
    char device_char[12]="/dev/mtd";
    char device_block[17]="/dev/mtdblock";

    strcat(device_char, argv[1]);
    strcat(device_block, argv[1]);

    pid1 = fork();
    if(pid1 == 0){
        while(1){
            fd = open(device_char, O_SYNC|O_RDWR);
            ret = close(fd);
        }
    }
    pid2 = fork();
    if(pid2 == 0){
        while(1){
            fd = open(device_block, O_SYNC|O_RDWR);
            ret = close(fd);
        }
    }
    sleep(10);
    kill(pid1, SIGKILL);
    kill(pid2, SIGKILL);
    pid = wait(&status);
    pid = wait(&status);
    return 0;
} 

> 
>> diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
>> index b8ae1ec14e17..147e4a11dfe4 100644
>> --- a/drivers/mtd/mtd_blkdevs.c
>> +++ b/drivers/mtd/mtd_blkdevs.c
>> @@ -188,6 +188,8 @@ static int blktrans_open(struct block_device *bdev, fmode_t mode)
>>  
>>  	kref_get(&dev->ref);
>>  
>> +	if (!mutex_trylock(&mtd_table_mutex))
>> +		return ret;
> 
> No, that's not really the solution.
> 
> Turning the kref_get above into a kref_get_unless_zero might be better
> path to look into.

Thanks, I will have a look at this.

Liwei.


>