Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i5ec1447f:Fastmail
Date:   Tue, 09 Aug 2022 20:55:58 +1200
From:   Luke Jones <luke@ljones.dev>
Subject: Re: [PATCH v3 1/6] asus-wmi: Implement TUF laptop keyboard RGB
 control
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        =?iso-8859-2?q?Barnab=E1s_P=F5cze?= <pobrn@protonmail.com>,
        Pavel Machek <pavel@ucw.cz>,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Message-Id: <AHBCGR.7I4U7CDRZ3J83@ljones.dev>
In-Reply-To: <CAHp75VfZeuuQjfM+CY4nxrFJQcfpdHVVzyj6GLjeweT3ycSn5A@mail.gmail.com>
References: <20220809025054.1626339-1-luke@ljones.dev>
        <20220809025054.1626339-2-luke@ljones.dev>
        <CAHp75VfZeuuQjfM+CY4nxrFJQcfpdHVVzyj6GLjeweT3ycSn5A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Precedence: bulk

Hi Andy,

On Tue, Aug 9 2022 at 10:46:33 +0200, Andy Shevchenko 
<andy.shevchenko@gmail.com> wrote:
> On Tue, Aug 9, 2022 at 4:51 AM Luke D. Jones <luke@ljones.dev> wrote:
>> 
>>  Adds support for TUF laptop RGB control via the multicolor LED API.
>> 
>>  As this is the bas for adjusting only the RGB values, it sets the
>>  default mode of the keyboard to static since there is no way to read
>>  any existing settings from the device. These defaults overwrite the
>>  booted state of the keyboard when the module is loaded.
> 
> ...
> 
>>  +       err = asus_wmi_evaluate_method3(ASUS_WMI_METHODID_DEVS, 
>> ASUS_WMI_DEVID_TUF_RGB_MODE,
>>  +                               rgb->save | (rgb->mode << 8) | (r 
>> << 16) | (g << 24),
>>  +                               (b) | (rgb->speed << 8),
> 
> Too many parentheses.

Uh, yeah. I was unable to find concrete info on this. I at one point 
experienced an issue where the order of operations *without* 
parentheses ended up as "x | y << (8 | z) << 16". But now I'm not even 
sure if I remember that correctly. I see the order here 
https://www.cs.uic.edu/~i109/Notes/COperatorPrecedenceTable.pdf

I'll do as said and test it to be certain.

> 
>>  +                               &ret);
>>  +       if (err)
>>  +               dev_err(dev, "Unable to set TUF RGB data?\n");
>>  +
>>  +       return err;
> 
> How ret is being used?

Damn.. fixed now.

> 
> --
> With Best Regards,
> Andy Shevchenko