Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i5ec1447f:Fastmail
Message-ID: <6fee3e143bd339ac9e4e8513c96a3af2137a3b3a.camel@ljones.dev>
Subject: Re: [PATCH v3 1/6] asus-wmi: Implement TUF laptop keyboard RGB
 control
From:   Luke Jones <luke@ljones.dev>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        =?UTF-8?Q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>,
        Pavel Machek <pavel@ucw.cz>,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Date:   Tue, 09 Aug 2022 21:31:34 +1200
In-Reply-To: <CAHp75VepmbLv1cx2cS6gbe_prs+cHZ0DYjJNkcuOXxeJaCqDGw@mail.gmail.com>
References: <20220809025054.1626339-1-luke@ljones.dev>
         <20220809025054.1626339-2-luke@ljones.dev>
         <CAHp75VfZeuuQjfM+CY4nxrFJQcfpdHVVzyj6GLjeweT3ycSn5A@mail.gmail.com>
         <AHBCGR.7I4U7CDRZ3J83@ljones.dev>
         <CAHp75VepmbLv1cx2cS6gbe_prs+cHZ0DYjJNkcuOXxeJaCqDGw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (by Flathub.org) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-08-09 at 11:29 +0200, Andy Shevchenko wrote:
> On Tue, Aug 9, 2022 at 10:56 AM Luke Jones <luke@ljones.dev> wrote:
> > On Tue, Aug 9 2022 at 10:46:33 +0200, Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > > On Tue, Aug 9, 2022 at 4:51 AM Luke D. Jones <luke@ljones.dev>
> > > wrote:
>=20
> ...
>=20
> > > > =C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 err =3D
> > > > asus_wmi_evaluate_method3(ASUS_WMI_METHODID_DEVS,
> > > > ASUS_WMI_DEVID_TUF_RGB_MODE,
> > > > =C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rgb->save | (rgb->mode << 8) =
|
> > > > (r
> > > > << 16) | (g << 24),
> > > > =C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (b) | (rgb->speed << 8),
> > >=20
> > > Too many parentheses.
> >=20
> > Uh, yeah. I was unable to find concrete info on this. I at one
> > point
> > experienced an issue where the order of operations *without*
> > parentheses ended up as "x | y << (8 | z) << 16". But now I'm not
> > even
> > sure if I remember that correctly. I see the order here
> > https://www.cs.uic.edu/~i109/Notes/COperatorPrecedenceTable.pdf
> >=20
> > I'll do as said and test it to be certain.
>=20
> I'm talking about the '(b)' part. The rest is okay to me.
>=20

Understood, thanks.