Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 9 Aug 2022 05:51:39 -0400
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Mauro Carvalho Chehab <mchehab@kernel.org>
CC:     David Airlie <airlied@linux.ie>, <linux-kernel@vger.kernel.org>,
        <dri-devel@lists.freedesktop.org>,
        <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v2 15/39] drm/i915: intel_dp_link_training.c:
 fix kernel-doc markup
Message-ID: <YvIuKw8KY6xMi0Fj@intel.com>
References: <cover.1657699522.git.mchehab@kernel.org>
 <0fac471eb7f6d365e9a7544071114292e08aa5ad.1657699522.git.mchehab@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <0fac471eb7f6d365e9a7544071114292e08aa5ad.1657699522.git.mchehab@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6g3y7KgYCU5+ibuFneTgwJHlHf8wJsTEO94kaxQqWr9uMR7cN/uMq/0c5Xkr?=
 =?us-ascii?Q?Df0eEvo3DglG98pgMr/5R+RlzWFGAEs9rURBzqr0zBxNG3Yhk7I1sU8eukrV?=
 =?us-ascii?Q?ad/VVzWh2bZKZSMDNH58aJVohK9kaOvQRxCFDqVJe/CtxkzETZ2C1rWniz51?=
 =?us-ascii?Q?/BOwriwsv5fPePfZHYxFgI8Msz6SEqXGvo4liB8bsnwQw3jUzWtmIauRIw+t?=
 =?us-ascii?Q?RccuiXYbMKyG3WnJC8xK607kn7tIfj96HWShicM1v2vNCZuef81S7ijDT7Aj?=
 =?us-ascii?Q?mO/CeUoQwYSZQRmG/J+sZpHqNgMGGLsM1fAhpLirnqeafmr33dqB2e3Z0yTf?=
 =?us-ascii?Q?tBIfx3KsBneCv4v6dbwBgiW2RMniW8lE8FgXaaXSmCMboXZbqNUJwWblw+aj?=
 =?us-ascii?Q?xHIILKxojSr257tmgMRW1yRTYGG7LblixJFPAzhv4+pz+3Rlj6NdAAqtPRy/?=
 =?us-ascii?Q?XZfN1AH3d1j1W22M/E9fJ3PGDNSjEFArsiC9vccwDAFNnONqMA7DOybLFvHb?=
 =?us-ascii?Q?xjnU3I4Dl3Gzwt0oxUL3NFlsjYYE+iuJgexWp0VtvCtHyTORR+jzBLt0pUz4?=
 =?us-ascii?Q?0lAhb49i4HbtICK/AzbdvLyvW4H00YurMW62Uosu9rW6EKd9N6iC6wWxElz0?=
 =?us-ascii?Q?XPm7M/B9mNpnbRLuk3Bz/IpLc+4EWv4eYBycC6Qu6l6kzUIuLMlndb9TZK9F?=
 =?us-ascii?Q?ySPJkgChi0p2gam26SJmreTNicHWmnHjPGvtPgZb1o/OVwkrcREepJYn4VMB?=
 =?us-ascii?Q?54Pr7Ls86xcna0rw7C4tJ1nXII8Urzli0CW70QGVzovlJ2gFmClh9nlzDZOU?=
 =?us-ascii?Q?Jnr9actryTDplV3sSIKoFpALR1R6Vk1oM7VH3YNTSWtuAjDrMLxC1CJkJJMd?=
 =?us-ascii?Q?fMxRyXfjazCjJdX+Id510R4jal5sXKUX3ruH3UatMqZHwabPlVXkZ0sPQc/u?=
 =?us-ascii?Q?GIPF8Vs4q9AdiumFCYS5VyKvllQLN33Uu1RtP9Zsuy2DXk0PhVQdRBp1wUaM?=
 =?us-ascii?Q?D9F4Glp0mgXxLzAypTAgoyWEXKDdh70BaoxD9JT7e8Zo8YwMv/X/AEsMJFuJ?=
 =?us-ascii?Q?j7Ya6gTOImKVCxfA6m9T1RGwkl9IEw5UPXvZ4S9eq5QN4oPOstB39WvPNOtZ?=
 =?us-ascii?Q?dl4fw2RGYvsMCb4hcBi8XPxhZBa/pKDq2DF0qxf91/5kYRwEF7f8dfOHeTI6?=
 =?us-ascii?Q?QmXHV8ACtaP1yWlQzpBMXJkGjElIBXi1HiuqUaHoZQSV1ik/cxIqq1qluwpz?=
 =?us-ascii?Q?whRHyYjis9MGIBMYkctjMtMNABAmGUAzdLJnAoRsYn/IgnnIG6meWo43HCRp?=
 =?us-ascii?Q?wyrb8xXfGRPCJJSMN1jsSdU42ocPf239HFLyugEodtrArhK32JXuNh0L3JXz?=
 =?us-ascii?Q?JIngGkCp6qATzndlWxcWac3wURuUyhacu7ZXAPWZYc61+FsoP6X2xPVr7rKr?=
 =?us-ascii?Q?8II3gJUWV5l597QtEYkqs1p8RUIUKvGwkzTw5G5CYrzlNEI70XmAkxozIvHo?=
 =?us-ascii?Q?bP5Dw80GtioWHAfJmlneANum1cMwxlC9/QKeomXQidYgwqu/Q8IfE6LTwTrZ?=
 =?us-ascii?Q?N1GZdUEZgoHo8OMvGlog0Zb95gx+bsDjMdP2Aie+NfWpIqyYwxCMB0PYgiSy?=
 =?us-ascii?Q?bw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 927c4fc6-c943-40c3-72a4-08da79ecc43b
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2022 09:51:44.3286
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Lxk7t9k5L5TKtX4gxNyHvBNpwdjkNF/6Xqee/9TXXcCrO9g6NLaZ4ODOoLszLcNiEJY7Ui6S9Lv/5liloqekBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4958
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 13, 2022 at 09:12:03AM +0100, Mauro Carvalho Chehab wrote:
> The return code table is not properly marked, causing warnings
> and being badly parsed by Sphinx:
> 
>     Documentation/gpu/i915:130: ./drivers/gpu/drm/i915/display/intel_dp_link_training.c:183: WARNING: Block quote ends without a blank line; unexpected unindent.
>     Documentation/gpu/i915:130: ./drivers/gpu/drm/i915/display/intel_dp_link_training.c:186: WARNING: Definition list ends without a blank line; unexpected unindent.
> 
> Use table markups to fix it.

cool, I didn't know that

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>


> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
> 
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v2 00/39] at: https://lore.kernel.org/all/cover.1657699522.git.mchehab@kernel.org/
> 
>  drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> index 9feaf1a589f3..23a269fcf6ca 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> @@ -177,12 +177,14 @@ static int intel_dp_init_lttpr(struct intel_dp *intel_dp, const u8 dpcd[DP_RECEI
>   * transparent mode link training mode.
>   *
>   * Returns:
> + * ====  =====================================================================
>   *   >0  if LTTPRs were detected and the non-transparent LT mode was set. The
>   *       DPRX capabilities are read out.
>   *    0  if no LTTPRs or more than 8 LTTPRs were detected or in case of a
>   *       detection failure and the transparent LT mode was set. The DPRX
>   *       capabilities are read out.
>   *   <0  Reading out the DPRX capabilities failed.
> + * ====  =====================================================================
>   */
>  int intel_dp_init_lttpr_and_dprx_caps(struct intel_dp *intel_dp)
>  {
> -- 
> 2.36.1
>