Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 9 Aug 2022 06:09:56 -0400
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Mauro Carvalho Chehab <mchehab@kernel.org>
CC:     Thomas =?iso-8859-1?Q?Hellstr=F6m?= 
        <thomas.hellstrom@linux.intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@linux.ie>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Matthew Auld <matthew.auld@intel.com>,
        <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v2 36/39] drm/i915 i915_gem_object_types.h: document
 struct i915_lut_handle
Message-ID: <YvIydIV6ozIabt3A@intel.com>
References: <cover.1657699522.git.mchehab@kernel.org>
 <6bdbfc5a739deceba57175269cc8e129ca481ed9.1657699522.git.mchehab@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <6bdbfc5a739deceba57175269cc8e129ca481ed9.1657699522.git.mchehab@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oTobCZbZbW7FcNy8u6iBots5uqy508MGTeFWpL0s4ZPaTQb4VxjEV7SlLzaF?=
 =?us-ascii?Q?v0w08WC8SDcD/WX9j0s5vy/MZdU1ITCyTH+rC/EdSGjVwcOK3Gc7K9VDkCQi?=
 =?us-ascii?Q?ZMR+7m2i/ik5lO+kuhjKa9b2WsvV3U18E/Rmhi5XmNK72hK9mzNS3MxhO/Um?=
 =?us-ascii?Q?E+kf4vVMnhhyKTNWcy/65rvuqkG+rnGSXN8+2FwM+P7DPafYrknvyBrttUwf?=
 =?us-ascii?Q?RCjP4hLA07/FjEWREMo1AIah3EGf9C6FWWOzJ+Q8IlCukL3AL5RdA0TG+l25?=
 =?us-ascii?Q?/1I7kYaEZQo3VVCpB3yIJcn6ES8kreWcUHWTh3n/cAVgVrdeXd/SCkkbHjyr?=
 =?us-ascii?Q?dnMSlvGjRJJdpF470eqOqekM5/xxJbLYr+hD4CLWQUDTmxCmUqJcaXQfZQN7?=
 =?us-ascii?Q?Z5iV69cfnXGyFdVRv1E689amVEJxUHBhMB6qatkm3Aq8mH+5Xs2Z30j9LjMX?=
 =?us-ascii?Q?sTJDgae6pdphiScVkKsQfYfWIiPGMT2OVKIyBQe+yaIehD2NX9rFoZ4M/zPg?=
 =?us-ascii?Q?xFcWmBTprLWTzSG7het6u/lsrgtNKxeF6MI/U/gDTTAkzhNCGG+Y5uO4Olb0?=
 =?us-ascii?Q?E09udltlt+9eLNzUYhLKvMihJZNdXAZ9oTJnRunryzDvugSHJ4RFsbD5ADsd?=
 =?us-ascii?Q?66rk/T7yIgjcYEURsjxXyawtZl4mnz5wDzf5cWiz0ZQTrO56WAUCGj33Gacw?=
 =?us-ascii?Q?ezldsFoTnHOf4P0Dul0o+vQ+t2FHU6OEj14v+ICgWey55H3y5By8GmUXoQaO?=
 =?us-ascii?Q?3aj2wu2j1QY4ua6/lV9shgtDeI39xcXCuYw4KyFzs5R1OOnG7xOzsMWB1k0n?=
 =?us-ascii?Q?K+t9gf//spF9GT78+JpnmezwARg8Lh99oI4gkQPdXrHOdbeRe2je/mpV0eGn?=
 =?us-ascii?Q?11+ulesk8y0lYafnpsWWY24Z2JAtZ0CooKjou9GepZiyHVpQe7EtjYzNmTWv?=
 =?us-ascii?Q?mjcY+rBDHr4/LvXlAJJKqYFi/obpt4/CtaQcey9cIQ1zTX6GbOgUq3s7TRLY?=
 =?us-ascii?Q?5POYJzqb1C9yeRaYVgSftBHmYE7b7mRG0b7aDRMtELi1o+8uJ+EllOXAiCnJ?=
 =?us-ascii?Q?ZgN5MbwdfHUzCnb1usuBT7+Si2UqSbPLl5cd3QlaV7nv4guRArkzdEHllC+j?=
 =?us-ascii?Q?3vtlLAdrOUjNZYuW9F1iYs4xpQeATkpw/D+pateK05oD8qs3tRPkzhtImdwe?=
 =?us-ascii?Q?a+5fYq29cu3Mvjr2R3pDcpsS4e4uezAIYgYlEbDqGmSVTavMVyVW3y3xUOEy?=
 =?us-ascii?Q?PU68XIYy8wdt3xap7rHpRFQZcUG6VjqkcpT4omtKlOP3zNv+LPezeIFdIyer?=
 =?us-ascii?Q?8U7qC02hs/JOy9gP91b6RAZ6jrTQPXsqjgK0RTTp3oYS4ejflNfxuQ3qvgyP?=
 =?us-ascii?Q?zYWjw6HfYapMHKFn613Lur/lvmI3vJeeIgF5dmhWbNSBCFfBloVZ4mXQs0PJ?=
 =?us-ascii?Q?5CPT4DOse2Yq7HCSoCAqvS2g6wOuePK3I/1O4Pe62ZOYbCzy61TIL4l9tykI?=
 =?us-ascii?Q?BSQXT1hiVROwCQfdHu9BcCIFUNMqJZ4vx4aFJEOfOY7neiP3nINyVS4MTdlD?=
 =?us-ascii?Q?t2RgqfpZ+V0wX3uFYE3srXdrnaUZonnouZxPb/4I88M+Q48tVph3wk14UA+7?=
 =?us-ascii?Q?yw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 636808cc-5237-495e-925f-08da79ef5269
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2022 10:10:01.5484
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s8A8mjFdTHUJ1w6NJo5/7Db+EcbFMPiZZQ3TNOJ0iiOfnGPFhgZu8BFsyzSfgik1N1prfZnwvpU1ESQEnrEUxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1393
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 13, 2022 at 09:12:24AM +0100, Mauro Carvalho Chehab wrote:
> commit d1b48c1e7184 ("drm/i915: Replace execbuf vma ht with an idr")
> added a rbtree list to allow searching for obj/ctx.
> 
> Document it.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> 
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v2 00/39] at: https://lore.kernel.org/all/cover.1657699522.git.mchehab@kernel.org/
> 
>  drivers/gpu/drm/i915/gem/i915_gem_object_types.h | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object_types.h b/drivers/gpu/drm/i915/gem/i915_gem_object_types.h
> index 5cf36a130061..ceed0d220ce3 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object_types.h
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object_types.h
> @@ -21,9 +21,15 @@ struct drm_i915_gem_object;
>  struct intel_fronbuffer;
>  struct intel_memory_region;
>  
> -/*
> - * struct i915_lut_handle tracks the fast lookups from handle to vma used
> - * for execbuf. Although we use a radixtree for that mapping, in order to
> +/**
> + * struct i915_lut_handle - tracks the fast lookups from handle to vma used
> + * for execbuf.
> + *
> + * @obj_link: link to the object associated with the @handle.
> + * @ctx: context associated with the @handle.
> + * @handle: a rbtree handle to lookup context for specific obj/vma.
> + *
> + * Although we use a radixtree for that mapping, in order to
>   * remove them as the object or context is closed, we need a secondary list
>   * and a translation entry (i915_lut_handle).
>   */
> -- 
> 2.36.1
>