Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220809073648.167821-1-marcus.folkesson@gmail.com> <20220809073648.167821-8-marcus.folkesson@gmail.com>
In-Reply-To: <20220809073648.167821-8-marcus.folkesson@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 9 Aug 2022 11:57:19 +0200
Message-ID: <CAHp75VerfFgNKRbE=f0LnpRBr1o=qNwSnUkzq69BeECJFY9Vvw@mail.gmail.com>
Subject: Re: [PATCH v5 7/9] dt-bindings: iio: adc: mcp3911: add
 microchip,data-ready-hiz entry
To:     Marcus Folkesson <marcus.folkesson@gmail.com>
Cc:     Kent Gustavsson <kent@minoris.se>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Aug 9, 2022 at 9:32 AM Marcus Folkesson
<marcus.folkesson@gmail.com> wrote:
>
> The Data Ready Output Pin is either hard wired to work as high
> impedance or push-pull. Make it configurable.

...

> +    description:
> +      Data Ready Pin Inactive State Control
> +      true = The DR pin state is high-impedance when data are NOT ready
> +      false = The DR pin state is a logic high when data are NOT ready

Wouldn't be better to move " when data are NOT ready" to the main
description text:

      Data Ready Pin Inactive State Control when data are NOT ready

In this case it unloads the list and moves focus from the part of "NOT
ready" to the real part of what you pointed out here --
"high-impedance" or "high".


-- 
With Best Regards,
Andy Shevchenko