Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 9 Aug 2022 06:23:28 -0400
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Mauro Carvalho Chehab <mchehab@kernel.org>
CC:     Thomas =?iso-8859-1?Q?Hellstr=F6m?= 
        <thomas.hellstrom@linux.intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@linux.ie>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        Matthew Auld <matthew.auld@intel.com>,
        <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v2 11/39] drm/i915: i915_gem_ttm_pm.c: fix kernel-doc
 markups
Message-ID: <YvI1oNQlSd/9AGmZ@intel.com>
References: <cover.1657699522.git.mchehab@kernel.org>
 <d3c6c2b3afa1baa8061489d8d4cd358b251fd30e.1657699522.git.mchehab@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <d3c6c2b3afa1baa8061489d8d4cd358b251fd30e.1657699522.git.mchehab@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Etww7wnEV64HNLTPuqyAqUGpLUe3Q9Jl4Zfc1wOCTG1kBk+riboAKuAaRrJI?=
 =?us-ascii?Q?ujCwpEexjlkwkyAdadIlhQJiJ5TpOdjtO1gNkhCyRv+Bni5zecU0ktCvEDuG?=
 =?us-ascii?Q?gdq2O4/JsFoSVgiP3AbfQSJVPomrFXljsN2WfA+6rqcxhyWy0J/QUuxJ44Zi?=
 =?us-ascii?Q?4ntbBJsAwkEx0tDjBlqHwSHtdOGHxLgrDKgnPt2f5dglZRxmQ8u3L5qY0WPS?=
 =?us-ascii?Q?Hm4yFGbvOXRzTM/M9iK9u/6EnILD7Nxfo6NWloYPYCtwjMLmLbkiEBHmJl99?=
 =?us-ascii?Q?p9ec6LqolcS1vRXQEx+s/rsdfvMEdKG9vkNZ2AvszuIW2DA4CHAz9xBffgfT?=
 =?us-ascii?Q?M5K7ujFGb7BO8Gw7L2Lt6bp52kfi5BZ8Qyz64zkGMzW7QkvFlF5uIEgYcZFc?=
 =?us-ascii?Q?+KXn6IVGvHHxUi4ZnsBzwOQ+Ek8oEp6HR0hcDVLi48gxbbZCUeVO/BpyX/po?=
 =?us-ascii?Q?jIDXyUom9k+BNWSEYaQmXhlIC+DUrPkw8q56YZhF3hRu2XnC5+0zWYoJpc9w?=
 =?us-ascii?Q?CfhqZhXU78ZNFARiP993ImcehZ9dMCN9KwLlzbw2/FqkdakjSLaLH/HQU72o?=
 =?us-ascii?Q?k1jl7vxhCvP00/fxpRu/pNJi0f3dSItymOamPs8kjC9se4k8HUp8evVgfQzd?=
 =?us-ascii?Q?kcTxXeCkgx/KtN/8M5bF7h/G7ubzeu1TpRGiqN7h8+kOPwUNxrjRgdgL5QKD?=
 =?us-ascii?Q?6mej8X+uvJJHugL3euYlL1nTjRh1ZyDsCa6udkIb8Lx3biWrcJDnl0Dk3fvR?=
 =?us-ascii?Q?MhrG8ISOltAtQBqdS3krsHwAFpyY449zCkj4/rR5TQfj6fGStWn4RiMRuGO5?=
 =?us-ascii?Q?llKf7iPN17tR5Sh1hB31bQtPMwIhECq69cpXJDtv5hwT8f1QkTzEoXI7qU6y?=
 =?us-ascii?Q?rR53tOASDeGHsAJj3lyw1f+mC0cvXHN2hrSlsa3zd8CcgXs80Cz8nnJPdo44?=
 =?us-ascii?Q?l5XhgQ578WaA8RBd0K9xIh+u7wb9c/7k+z4xXdjjDlqHQU9aL/txWLx8aTjD?=
 =?us-ascii?Q?CYT11G/8I6B9sqVycx1iumotAU+8ckgsyB0wzlyBJDkoulX/uMcrTT4xQWVN?=
 =?us-ascii?Q?0R4p3NbcadQOqvA/fahwADN2IckZsm+gNUFQKg0OkdaLWplP++ZuYLktZk+l?=
 =?us-ascii?Q?wIwuYMijjgnbOorJMoz4FPTaRlyW6GkkFudQjonL6unFOuQW48pv9pXYE5Kk?=
 =?us-ascii?Q?+CH4ceaFo8ROiEVnM0YPsNSb5WBC8x2u2jh2qD0Y05BxvtJ/QljSsIowcYQc?=
 =?us-ascii?Q?h4n60Co3beduX3vVf3BW1cjGO4/wwCk+C8B5YPeTQ+VnvG0d25wujjuNfHPM?=
 =?us-ascii?Q?8CUGA8VEKND9C/o7UmSnHExIgDaxSMnGb/LpJ18rX6aGvgonCUsG6hd8Dv+n?=
 =?us-ascii?Q?jvLEUNo9rr0PRXuEUJ0do1dthaO/bnfk1KjayPIcmVruW+y2S5fPWRQ14cAB?=
 =?us-ascii?Q?+lhSDJJkJrYdM9z9xz93vvEC36Ae3xLltkENqmsF2t3WkfWUoS5eZdM9bQCC?=
 =?us-ascii?Q?15t8GY3nunTI3IfJ9bWOMn8TdDb+6rFQYwoGMdlt8A3mpW7xmz0jij8BQoJ6?=
 =?us-ascii?Q?ZD9YKya7iimwKN5pmTnYoT5gaMVMJQ4Bhx8j83baZeeqnLI5WcPNM4hTtqWF?=
 =?us-ascii?Q?lw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 12529411-d10e-48d8-dc7c-08da79f13620
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2022 10:23:33.1751
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TY1Lqn2M615Ms3QAxbA4tpzOWs8vAoIjQEyuzRSxzeFQqoNS9ZWzxcdBaN1daMCed99JAGHtK0tk6TOpMbDQqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5477
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 13, 2022 at 09:11:59AM +0100, Mauro Carvalho Chehab wrote:
> The documentation for the flags field is missing there. It sounds
> that some last-time change converted some bools into flags, but
> the kernel-doc change didn't follow it.
> 
> Fix those warnings:
> 
> 	drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:135: warning: Function parameter or member 'flags' not described in 'i915_ttm_backup_region'
> 	drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:135: warning: Excess function parameter 'allow_gpu' description in 'i915_ttm_backup_region'
> 	drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:135: warning: Excess function parameter 'backup_pinned' description in 'i915_ttm_backup_region'
> 	drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:199: warning: Function parameter or member 'flags' not described in 'i915_ttm_restore_region'
> 	drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:199: warning: Excess function parameter 'allow_gpu' description in 'i915_ttm_restore_region'
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> 
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v2 00/39] at: https://lore.kernel.org/all/cover.1657699522.git.mchehab@kernel.org/
> 
>  drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
> index 9aad84059d56..9843831c9b37 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c
> @@ -123,8 +123,9 @@ void i915_ttm_recover_region(struct intel_memory_region *mr)
>  /**
>   * i915_ttm_backup_region - Back up all objects of a region to smem.
>   * @mr: The memory region
> - * @allow_gpu: Whether to allow the gpu blitter for this backup.
> - * @backup_pinned: Backup also pinned objects.
> + * @flags: Bitmap field with the following flags:
> + *	%I915_TTM_BACKUP_ALLOW_GPU: allow the gpu blitter for this backup;
> + *	%I915_TTM_BACKUP_PINNED: backup also pinned objects.
>   *
>   * Loops over all objects of a region and either evicts them if they are
>   * evictable or backs them up using a backup object if they are pinned.
> @@ -188,7 +189,8 @@ static int i915_ttm_restore(struct i915_gem_apply_to_region *apply,
>  /**
>   * i915_ttm_restore_region - Restore backed-up objects of a region from smem.
>   * @mr: The memory region
> - * @allow_gpu: Whether to allow the gpu blitter to recover.
> + * @flags: Bitmap field with the following flags:
> + *	%I915_TTM_BACKUP_ALLOW_GPU: allow the gpu blitter for this backup;
>   *
>   * Loops over all objects of a region and if they are backed-up, restores
>   * them from smem.
> -- 
> 2.36.1
>