Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp5983749rwb; Tue, 9 Aug 2022 07:20:02 -0700 (PDT) X-Google-Smtp-Source: AA6agR75eTrbYY9vz7xW6lPqEh1/am+TrBw/lD2BTWlTbCL+fR4aW8D6k1EnKSFufdCH4KGdtNAI X-Received: by 2002:a05:6a00:1496:b0:52f:734f:9122 with SMTP id v22-20020a056a00149600b0052f734f9122mr7422273pfu.85.1660054801832; Tue, 09 Aug 2022 07:20:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660054801; cv=none; d=google.com; s=arc-20160816; b=UHNrtwvCi+5t3z5g6+x4alGOAXriQ963mpuGREejfCMvuRXp3Ml9BNhhgEwuEmI7li AZhymYKEmtjbIP5HE0Ais8km5r1nAOVUheR0kOv3rIl1LinXSW3jT5XoeoyFu2eLyEgm aV//tU/tjdXU6QLKEOyYc+XTQFIwRmzuHLtVkcCRMY+kkBxkwKC7AZghPuo21k64Z6UT PTH0mHAMFIOTSMYkvcXQQUUoD9xyndxUUTkpUHCdMCFyKHjXpYtpNFRggK1UabiqCykg bbqt7ixYEIxiDuoV/D50hy2dR9sROGO3CVVt98NukmyzRI81F1OPXiu0J35N3B+1GAgn M2IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8yBpUGfZbdMabjzikGKdcUT0TODwCx9uSyAd8Z6Yn9s=; b=qH2pWpye7v0Kj/qIcJe+h0xAGHgc4rZ5AXoCHVr4hJcEHlZ+nStF3Ko1zz9Yjn9ytK qrswy9f6d9nN6blE7gr1kl6UXl9K/FaEC+ycysf0R57DjsKmwMTkA+Uj87TKvrH3vQ9q 4BTsVQlFXScFxq8KehEdyKSVjNmtBahzV5Z2N3eCTaNeXHYIymMdDqxCAXmknIRtKB56 151ADCNQ+iFE7yO4C0B8cBXrxQvsLG0Gr4VAVd+/RoWL3hsuwgLN1ZnviYsLAQFmnfw2 X8wh8H2X6q9XvN/s7BOp35pwXDCZyFVcQC5gZ5OK0RFojwDeuGkLTVwTXl+Hnp+oGr4g fDDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=SjuY2JQz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f13-20020a056a00238d00b005283d9f80desi2854871pfc.308.2022.08.09.07.19.45; Tue, 09 Aug 2022 07:20:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=SjuY2JQz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244660AbiHINxZ (ORCPT + 99 others); Tue, 9 Aug 2022 09:53:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239746AbiHINxX (ORCPT ); Tue, 9 Aug 2022 09:53:23 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E3D02610; Tue, 9 Aug 2022 06:53:20 -0700 (PDT) Received: from notapiano (unknown [193.27.14.109]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 31A1C6601C45; Tue, 9 Aug 2022 14:53:16 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1660053198; bh=R+CpuZN1Sl+R1CObLrG1wLITHiTzHmjmpta/SIREkdM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SjuY2JQzbM0PFwmAXUkG2NewMPwh5uPBzPQkoYv8b+NViFKYoRaSGYgXA6YSAWYna qSBCjU78IGhJ0uGfuZn1Dm3GK3sBSeTGvJn1h4XdjaUwFgk2W+FEOhGkRDDJFRzjOJ h6KRVfb+d4ZURdxwDr4dcpUa4or57PdiFRkAIwdaxAEEn9Px2t9oVIl/E5wlAs04f8 X9cns2SgL1slzGdaZ5yS6uInTQxTVkc37bwEle4BoVpSUOeSYyFPhU4OJDaxvVrrlC 7CWGQFRiCPv/rrgLzG7f46/tSSyyk5QXckkaePiEdtklThsMY+ItVw04TaYHAG3H3X XVOk1qLihA2aA== Date: Tue, 9 Aug 2022 09:53:12 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Tinghan Shen Cc: Krzysztof Kozlowski , Yong Wu , Joerg Roedel , Will Deacon , Robin Murphy , Rob Herring , Krzysztof Kozlowski , Lee Jones , Matthias Brugger , AngeloGioacchino Del Regno , MandyJH Liu , iommu@lists.linux.dev, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v5 02/20] dt-bindings: memory: mediatek: Update condition for mt8195 smi node Message-ID: <20220809135312.hadcs7ti2cgyyuez@notapiano> References: <20220804021553.14867-1-tinghan.shen@mediatek.com> <20220804021553.14867-3-tinghan.shen@mediatek.com> <96e66425-ff2a-4640-8b96-48fa39943bf9@linaro.org> <6a1977971317059fcfad685869b6ccf233edcb68.camel@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6a1977971317059fcfad685869b6ccf233edcb68.camel@mediatek.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 09, 2022 at 07:01:10PM +0800, Tinghan Shen wrote: > Hi Krzysztof, > > On Thu, 2022-08-04 at 17:12 +0200, Krzysztof Kozlowski wrote: > > On 04/08/2022 04:15, Tinghan Shen wrote: > > > > > > It's because the 'mediatek,mt8195-smi-sub-common' compatible incorrectly > > > matches the 'else' conditions for gen2 HW without gals. > > > > > > Rewrite the 'else' condition to specifically identify the compatibles > > > that utilizing gen2 HW without gals. > > > > > > Signed-off-by: Tinghan Shen > > > Reviewed-by: AngeloGioacchino Del Regno > > > > > > > Unfortunately, your patches got corrupted. > > > > > > Best regards, > > Krzysztof > > Do you mean rebase to the latest linux-next? > I'll rebase in the next version, thanks! Hi TingHan, the issue is that some line wrapping happened on your patches, which broke tags and also the diffs themselves (it's very obvious on patch 3). So you need to sort out your setup so that no longer happens, and resend the patch. Thanks, N?colas