Subject: Re: Coding style - a non-issue
To: pavel@suse.cz (Pavel Machek)
Date: Sun, 2 Dec 2001 21:28:00 +0000 (GMT)
Cc: hps@intermeta.de (Henning Schmiedehausen),
        viro@math.psu.edu (Alexander Viro),
        jgarzik@mandrakesoft.com (Jeff Garzik), lm@bitmover.com (Larry McVoy),
        linux-kernel@vger.kernel.org
In-Reply-To: <20011202211309.B251@elf.ucw.cz> from "Pavel Machek" at Dec 02, 2001 09:13:09 PM
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <E16Ae9Y-0004c9-00@the-village.bc.nu>
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Sender: linux-kernel-owner@vger.kernel.org

> > a) media echo that "linux core developers start insulting code
> > committers"
> > 
> > b) vendors start cleaning up their code.
> 
> Question is... what hurts us more. Bad press or bad code? I guess bad
> code is worse...

What would be much much more constructive isnt quite a hall of shame - its
to build a set of pages that take problem drivers and quote chunks of them
with an explanation of _why_ it is wrong, what should be used instead and
possible the "after" code if it also gets cleaned up.

That way people coming along actually learn something from it. Anyone can
be a critic, its rather harder and much more valuable to be a critic that
actually has positive impacts on what you criticize


Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/