Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
In-Reply-To: <1660026909-7365-2-git-send-email-quic_c_skakit@quicinc.com>
References: <1660026909-7365-1-git-send-email-quic_c_skakit@quicinc.com> <1660026909-7365-2-git-send-email-quic_c_skakit@quicinc.com>
From:   Stephen Boyd <swboyd@chromium.org>
User-Agent: alot/0.10
Date:   Tue, 9 Aug 2022 11:34:17 -0500
Message-ID: <CAE-0n52t0MPDxGQNEdhNaqOBhUhr8FBew_cuEwmruN12k4f15A@mail.gmail.com>
Subject: Re: [PATCH V4 1/3] arm64: dts: qcom: sc7280: Cleanup the lpasscc node
To:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh@kernel.org>,
        Satya Priya <quic_c_skakit@quicinc.com>
Cc:     Douglas Anderson <dianders@chromium.org>,
        Andy Gross <agross@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        quic_tdas@quicinc.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Quoting Satya Priya (2022-08-08 23:35:07)
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 13d7f26..71735bb 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -2168,9 +2168,8 @@
>                 lpasscc: lpasscc@3000000 {
>                         compatible = "qcom,sc7280-lpasscc";
>                         reg = <0 0x03000000 0 0x40>,
> -                             <0 0x03c04000 0 0x4>,
> -                             <0 0x03389000 0 0x24>;
> -                       reg-names = "qdsp6ss", "top_cc", "cc";
> +                                 <0 0x03c04000 0 0x4>;

This looks oddly tabbed out? I'd expect it to align with the first reg
property, so be unchanged.

> +                       reg-names = "qdsp6ss", "top_cc";
>                         clocks = <&gcc GCC_CFG_NOC_LPASS_CLK>;
>                         clock-names = "iface";