Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp6136333rwb; Tue, 9 Aug 2022 09:40:46 -0700 (PDT) X-Google-Smtp-Source: AA6agR7rxKu+XAjgRGm2fL7CWz7/UuYc++XRvHFrqfgn00gBo90gdKfmKZuqpuv7KDf5znTv0bxt X-Received: by 2002:a17:902:d58b:b0:16d:c9ff:3c26 with SMTP id k11-20020a170902d58b00b0016dc9ff3c26mr24597357plh.10.1660063246668; Tue, 09 Aug 2022 09:40:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660063246; cv=none; d=google.com; s=arc-20160816; b=sPTEijnq9KNGa6kmn8tvO1VfLfJjLmgZUEcnoZkbVru+HkMgjRHwnX6iQdvlSNgzX5 eXLD9oi/Fvh2XbB4da4suwRSIh7iTO/6UkcbNOdwT0WvZoWeCTqfReGhM8PLq26BqkOE 2l8WpmehJ3tEC8XeRJDAeXDHjc7fpKaqP00YuWMFcdantXeaFje9Q3l/aGJUj+EOvPbs K2iVHB80maaiUrfr+9ok6yS3Cz77FiyZXZpxczwo0AmaufljOsJJyPg0DpD8K8WIo0Jt BX3ehoUosGHMa5uYFFhtk31/EiFnYA9zPk7yqTvtp3yef6Gtz82DSx9O0lHTbFvbmHO8 vHFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bbnUBkAuRwCvXbeqqZR7igKd7kcO8w47YNxFfd9EWB4=; b=FiHzMVJU3P6o9I744GOUj7THIgsyJZvtMZ6+k9wKZBpkjcqzOTXUPgf2VMY2qkKuQG wRqq3QJC583V3h3j21q6NpPq00K6OfCG2g73F7DzKFkPm1m8VS/z89zEIR00v8mYyz5D Rf+n0FQNkY2vERqEZf/pSU3MKbC0XXs/JEhq5HYP7cGQE60LrWctTKxCkPQHaFaLFIkK CAsiD4wyqFShqXPKz8x2eII0+KUENj2FI/XbCVLrqtLo9RG0zvpMCd4rswbm4KzTKSBN J5VrAqTUsYPAuESpQxNIiFiqP4G4PMHWuGtpF3S8xf/gyR7yu9nYXdIoW+P11cv2b0jr d+nA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="PAs8/xzh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z7-20020a170902ccc700b0016a676058b5si14800903ple.270.2022.08.09.09.40.32; Tue, 09 Aug 2022 09:40:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="PAs8/xzh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245121AbiHIQg0 (ORCPT + 99 others); Tue, 9 Aug 2022 12:36:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245168AbiHIQgT (ORCPT ); Tue, 9 Aug 2022 12:36:19 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF0261D8; Tue, 9 Aug 2022 09:36:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7DAA2B8111F; Tue, 9 Aug 2022 16:36:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1EF4C433D7; Tue, 9 Aug 2022 16:36:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660062974; bh=KQIbq1M7KiQ601fejWiMxVueLyd23HzAj7uEElLFxgo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PAs8/xzhrFvK6sqOrZ5ZPdRMnvP1npJqlA3BIMJ/KKViTn4+sMI39HwQNNWTKoiWT HHn37o1IM2dG3IABKuFEJTh8BhQOWyduIzisvHRr5fsmWBempzIBR8LOgpOvupdJra mpKVzj9U16VMhNSpzkkTlN9Y3MbNPtRX+/B2tv32g6EqqubtCxbWqmizKsfyO3czUB 33hAk7NOEoB14XBzaEiTq9vnONrkB61Wpv0SkAJQWPr+pW9qcfMS9IKcYZTLQsID7P hs/hTaLCCt0e+nciY7VNCV5uacYAw7W5V7MvfW0cEHtBaiTwBgCMUhUBpL5mczezWi RKMDDywOXGrBQ== Date: Tue, 9 Aug 2022 09:36:12 -0700 From: Nathan Chancellor To: Guillaume Tucker Cc: Shuah Khan , Nick Desaulniers , Tom Rix , Mark Brown , kernel@collabora.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] selftests: add missing ')' in lib.mk Message-ID: References: <7de08f7f11551d6b8195c3e5d801db2fae3f49a9.1660048017.git.guillaume.tucker@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7de08f7f11551d6b8195c3e5d801db2fae3f49a9.1660048017.git.guillaume.tucker@collabora.com> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 09, 2022 at 03:20:46PM +0200, Guillaume Tucker wrote: > Add missing closing ')' in lib.mk in a call to $error(). This only > affects LLVM / Clang builds. > > Fixes: 795285ef2425 ("selftests: Fix clang cross compilation") > Signed-off-by: Guillaume Tucker Reviewed-by: Nathan Chancellor > --- > tools/testing/selftests/lib.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk > index 947fc72413e9..a87f60873e5b 100644 > --- a/tools/testing/selftests/lib.mk > +++ b/tools/testing/selftests/lib.mk > @@ -20,7 +20,7 @@ CLANG_TARGET_FLAGS := $(CLANG_TARGET_FLAGS_$(ARCH)) > > ifeq ($(CROSS_COMPILE),) > ifeq ($(CLANG_TARGET_FLAGS),) > -$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk > +$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk) > else > CLANG_FLAGS += --target=$(CLANG_TARGET_FLAGS) > endif # CLANG_TARGET_FLAGS > -- > 2.30.2 >