Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b39c9fa3-1b7c-c7b1-c3dd-bf5ceb035dc8@intel.com>
Date:   Tue, 9 Aug 2022 10:32:21 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] igc: Remove _I_PHY_ID check for i225 devices
Content-Language: en-US
To:     Linjun Bao <meljbao@gmail.com>
CC:     Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20220809133502.37387-1-meljbao@gmail.com>
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <20220809133502.37387-1-meljbao@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUp4WXczOFZwY3ExTFBHc3FBZVd5QTFidFdBYXRQRXYrdm5oenYxb3NOYzN6?=
 =?utf-8?B?RTgyb0RVVUJkeFVvdkNLc3FBN2NrR2k1ZjlLbWpjbmx6dGFHMjJZRVJhNVls?=
 =?utf-8?B?NEUzTUhQWDdoWmU0cnd6RGM4QXB5L2lmRGRUQ0JweVV1aTNzaDZnTXBLZmxv?=
 =?utf-8?B?WHRNeWRUanBGYjVBcUtDQ2ZDSnViaEJEK1FuMFhUb1ppaFJtMkQxYWJYMkZj?=
 =?utf-8?B?NlE3WlhuOVBCcUF1Y3VuUVZDaVk2UkxuSkZEckZLWmVjVG9aT3BpdlpXVU9y?=
 =?utf-8?B?bVE2bC9lazR2dE1FYll2bzBoY3MydUJ5MWlRbmdZbXRQYzEvakwySE5GL1J1?=
 =?utf-8?B?cG5pWTlSZ055RW5GNXp0ZkZSSFl4M0czME9BbklMNmExQWhkbllZcXF2Tlp5?=
 =?utf-8?B?c0lVOHpnSnhnMjU0M2prbDZGVktncGI5NmVKc3ZLeFQ4N3A0SkU3Q3Nja05n?=
 =?utf-8?B?amd3Z201TXRJdUc4RlN3ZEJrQmZjb3BOV0pQR2VUUFB2dmFDNE1QYmJ4OXgy?=
 =?utf-8?B?djBvdDNwMEhwMWJvS3RPMFc5NWl3NVd1a0xiRitkendLb01kOVhQcTRBNENv?=
 =?utf-8?B?ZU1aOGQyS0xsSko1UTlMZWIvTE1XZG4xWW5jVXlzcWZPQ0V4c1B3eVZZYTZR?=
 =?utf-8?B?L2FNYWZHMFZFNTBwaGpCbkEzaDJrLy8zTm5UVGpvMnplRVl1S1VjYWVMZkxy?=
 =?utf-8?B?ZTNpU1ZaTHE2MGQxc1FlNVZkeXlPNmsyVUI1bmZBUXdkbmo2cFB4aFdoaDc4?=
 =?utf-8?B?ZXNudWtiWElkRmJLOHhEL215VDRIRkI5ZU5WdDByajRxZFhNQWFYbzhPaEN2?=
 =?utf-8?B?bjk5OEt1VHIzdnFxb3Vra2JBRkRFUUpxWXhoaVpOMGpONnlZcFpMWWZNRllV?=
 =?utf-8?B?cTc0TGxSOUhNQnRuUkZrMERYdFNISkdnQkVwcHVCcFd3em1sNmljQmZUMUwv?=
 =?utf-8?B?bmVldjVKd1JIbGxsNXR5N2ZHWGFDbkZBVExMaTRoaWZIVmcvSGJ5Zm5JMWIv?=
 =?utf-8?B?YzZyaWFXMTMvSjFyVnA4YnZMU0pWdnM2VXAzQzdTOWFZUDJMRFNjcjVXbFdq?=
 =?utf-8?B?K0JJKzNtQkxody9RWXhmeXhyYVB5YjVVVG5UOGd3dEFsV05SY2M5aitoTjRF?=
 =?utf-8?B?MG54ZDhSbWRIYUdNc1NpT1VQaFcraXFlWXlWUE5QaUV3dms3NUZKdzIvemcw?=
 =?utf-8?B?VFpXU3JEK2NwWUVCejFrQ0l1UkNMWHBpL3g0cmdzTXEwUCtpKytMdDJSaG51?=
 =?utf-8?B?eVdGbERLMXZQQVRwMHlyOFh1R1FkQ3ZkMGM3ZFpzWUk2SGZSSGpYY2krMmtC?=
 =?utf-8?B?ZEpmQ0gyRXU4Z3luaEYyTHBiSmJ1VmJRcEdRcTI0eDNHaUE2NEs5dEYxVmhs?=
 =?utf-8?B?UWRpS3pIZ0NrajJ2REtaeTZyc1F2YTVkdEdhaStMZ1g1ZXRGZjhrVlFTWXJh?=
 =?utf-8?B?d2trdEI4K1lZWkdsWU5EdEloUVc1NTJqWUlYRGFLUzd0dTYrL2xtRjRGTG5u?=
 =?utf-8?B?KzdUbVlpUERGb1Vwck1HRTlRKzdVOE1LWlZhZVRBWE40YjBQZGFoSW4vNXFS?=
 =?utf-8?B?M00vYTBhakNVUDRwczZmcUlFN3d2bkFQZkZGZjB5endWVzc0aWY3RVNzVTZ6?=
 =?utf-8?B?YWNXbUR5aEI5djZFSEZHL0dlS2NQbWNEN3cyVGFTOXJEOUxjZGQvN1ZDdjhC?=
 =?utf-8?B?U3dEQVVZVlRIS3pXNnhSY1dRWmFUZmpEa2FKYXRwYzVoZzhUb2hOZnUxdVpB?=
 =?utf-8?B?c1gwNXlQdUZQNnZwSmY4b0ZvMHFGUndaV05ZaWN2Qm8yYmM5TW5Kc01WbXdy?=
 =?utf-8?B?ck16Vk1rMGUwb1VFckdyNE9rQ2hwUE0vYk5panJIY0RBazExTFVJZ3dER1Zh?=
 =?utf-8?B?bHcwSGw3MEh0Wm1UZk1XV01hQVZ1U2ovbTJhUUx0djdXUENKd2Y4QklvelFt?=
 =?utf-8?B?eGt4R09OVDFGZWltZHFYbW1oK21SSW90ei83Q2xUZjQ3MkJmekt3em80YUNW?=
 =?utf-8?B?M2NjRE5PRU9uN0N5N1hlR1lUZ09zV1ptQjZiVUYwOG0rZ1NBbUFtM1hncE5i?=
 =?utf-8?B?RGtvRStZd0NSSWtSUmxaNXVtemdHamxteHJGSmF0a3FVZEYrTlBGM0dyalUy?=
 =?utf-8?B?VVJPeEcrQ0FlVitiYTJTd2IyNHQrcTI4Nmk4QlZ6eFhoenV0b1RLM3RENGY3?=
 =?utf-8?B?aWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: be6ed68b-ef07-4b5d-2988-08da7a2d26d1
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2022 17:32:37.1267
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WHbX7uq/UlGkCOVZDCrikJdB+n7JOSDzqrzsaKPji+y0myzUUEytjxLofn2kWc6oDx4YE/MAl73z0PJEt/rQDRHGem5hVDrDk4Writm0SqU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3885
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/9/2022 6:35 AM, Linjun Bao wrote:
> Source commit 7c496de538ee ("igc: Remove _I_PHY_ID checking"),
> remove _I_PHY_ID check for i225 device, since i225 devices only
> have one PHY vendor.

What are you trying to do with this patch? You're referencing the 
original commit so you know it's committed, but it's not clear to me why 
you are re-sending it.

Thanks,
Tony

> Signed-off-by: Linjun Bao <meljbao@gmail.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_base.c | 10 +---------
>   drivers/net/ethernet/intel/igc/igc_main.c |  3 +--
>   drivers/net/ethernet/intel/igc/igc_phy.c  |  6 ++----
>   3 files changed, 4 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_base.c b/drivers/net/ethernet/intel/igc/igc_base.c
> index db289bcce21d..d66429eb14a5 100644
> --- a/drivers/net/ethernet/intel/igc/igc_base.c
> +++ b/drivers/net/ethernet/intel/igc/igc_base.c
> @@ -187,15 +187,7 @@ static s32 igc_init_phy_params_base(struct igc_hw *hw)
>   
>   	igc_check_for_copper_link(hw);
>   
> -	/* Verify phy id and set remaining function pointers */
> -	switch (phy->id) {
> -	case I225_I_PHY_ID:
> -		phy->type	= igc_phy_i225;
> -		break;
> -	default:
> -		ret_val = -IGC_ERR_PHY;
> -		goto out;
> -	}
> +	phy->type = igc_phy_i225;
>   
>   out:
>   	return ret_val;
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
> index 9ba05d9aa8e0..b8297a63a7fd 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -2884,8 +2884,7 @@ bool igc_has_link(struct igc_adapter *adapter)
>   		break;
>   	}
>   
> -	if (hw->mac.type == igc_i225 &&
> -	    hw->phy.id == I225_I_PHY_ID) {
> +	if (hw->mac.type == igc_i225) {
>   		if (!netif_carrier_ok(adapter->netdev)) {
>   			adapter->flags &= ~IGC_FLAG_NEED_LINK_UPDATE;
>   		} else if (!(adapter->flags & IGC_FLAG_NEED_LINK_UPDATE)) {
> diff --git a/drivers/net/ethernet/intel/igc/igc_phy.c b/drivers/net/ethernet/intel/igc/igc_phy.c
> index 6156c76d765f..1be112ce6774 100644
> --- a/drivers/net/ethernet/intel/igc/igc_phy.c
> +++ b/drivers/net/ethernet/intel/igc/igc_phy.c
> @@ -235,8 +235,7 @@ static s32 igc_phy_setup_autoneg(struct igc_hw *hw)
>   			return ret_val;
>   	}
>   
> -	if ((phy->autoneg_mask & ADVERTISE_2500_FULL) &&
> -	    hw->phy.id == I225_I_PHY_ID) {
> +	if (phy->autoneg_mask & ADVERTISE_2500_FULL) {
>   		/* Read the MULTI GBT AN Control Register - reg 7.32 */
>   		ret_val = phy->ops.read_reg(hw, (STANDARD_AN_REG_MASK <<
>   					    MMD_DEVADDR_SHIFT) |
> @@ -376,8 +375,7 @@ static s32 igc_phy_setup_autoneg(struct igc_hw *hw)
>   		ret_val = phy->ops.write_reg(hw, PHY_1000T_CTRL,
>   					     mii_1000t_ctrl_reg);
>   
> -	if ((phy->autoneg_mask & ADVERTISE_2500_FULL) &&
> -	    hw->phy.id == I225_I_PHY_ID)
> +	if (phy->autoneg_mask & ADVERTISE_2500_FULL)
>   		ret_val = phy->ops.write_reg(hw,
>   					     (STANDARD_AN_REG_MASK <<
>   					     MMD_DEVADDR_SHIFT) |