Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <76b5db88b280cccb784209b26fe48799dcb41b13.camel@sipsolutions.net>
Subject: Re: [PATCH v2] um: read multiple msg from virtio slave request fd
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Benjamin Beichler <benjamin.beichler@uni-rostock.de>,
        Richard Weinberger <richard@nod.at>,
        Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc:     linux-um@lists.infradead.org, linux-kernel@vger.kernel.org
Date:   Tue, 09 Aug 2022 20:07:47 +0200
In-Reply-To: <20220607112714.516408-1-benjamin.beichler@uni-rostock.de>
References: <20220607112714.516408-1-benjamin.beichler@uni-rostock.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-06-07 at 11:27 +0000, Benjamin Beichler wrote:
> If VHOST_USER_PROTOCOL_F_INBAND_NOTIFICATIONS is activated, the user mode
> linux virtio irq handler only read one msg from the corresponding socket.
> This creates issues, when the device emulation creates multiple call
> requests (e.g. for multiple virtqueues), as the socket buffer tend to fil=
l
> up and the call requests are delayed.
>=20
> This creates a deadlock situation, when the device simulation blocks,
> because of sending a msg and the kernel side blocks because of
> synchronously waiting for an acknowledge of kick request.
>=20
> Actually inband notifications are meant to be used in combination with th=
e
> time travel protocol, but it is not required, therefore this corner case
> needs to be handled.
>=20
> Anyways, in general it seems to be more natural to consume always all
> messages from a socket, instead of only a single one.
>=20
> Fixes: 2cd097ba8c05 ("um: virtio: Implement VHOST_USER_PROTOCOL_F_SLAVE_R=
EQ")
> Signed-off-by: Benjamin Beichler <benjamin.beichler@uni-rostock.de>
>=20

Reviewed-by: Johannes Berg <johannes@sipsolutions.net>


Sorry, should've sent that earlier.

johannes