Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp6373754rwb; Tue, 9 Aug 2022 14:13:23 -0700 (PDT) X-Google-Smtp-Source: AA6agR5MpJ+JUK3EkczstGhLC+pGwbqjyZeTLO7/4pIiweRKJjdgYd5uiiN/+E+3sLW85KWcPM0h X-Received: by 2002:a17:90a:e7c3:b0:1f5:8428:bee2 with SMTP id kb3-20020a17090ae7c300b001f58428bee2mr363887pjb.33.1660079603543; Tue, 09 Aug 2022 14:13:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660079603; cv=none; d=google.com; s=arc-20160816; b=A3S/9w7xg2oov3nPp/POZ4W+OX1YGLARJX7s5vRstRj8xz5c0niN6T88bMqrMSX5Se MBDo5LaQcPL17WgD8enCn2fkaSTkYvNZTd9LI2rYZJzQlkbSMEB7Dmqed6fPwgEQxZ8+ OPz7CaeMUGces+ZdRb/q2BCAaDU07O3A06+iieYyyi95L535CzUWxOtdgWWZ5pT9AUyT iM4wjMMvBvUnAA2Lxyiw/NhTnFIFpunBvL76Umxc0to1YVyRUDTXzl7sxAJ3I2cgZ/L8 haW83TIsEQerfnaqQas8uyb6TCHkvTJ5wE03nF4KvcWh7LlsQoHBKxj8hvTGR+oMVpNO jfKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=n+sIRfD+RQiRGeYS26jphMxCdbHEnhlhpCnFs913kcs=; b=Qr6Wi/FBygeqjdWaWpmqQZdlEEGiQukqnkTHp1eifgIywQHeIMvWwyleQOYJ3PA8KO Y+JquxKx9GUoz+fGUGh3OJEvZ0IuKNG13XxB19l3T/7s6Glh+jc2wxM2vGovVlDamgzE 7cyZyI1T0oSFLenozYTKTnaIqWE/3DMhzaHZIcyUMYiQHWdGYUT+mKQuw7xrMlYN503T eRrRvhtGfsINl+ckxXdKX3UiYDEjCIS2uAAnf1++gNPrsKC/Ml+7+jlb5bP/vMo3QCrf 21SqCTaqxi3lGv0tEO1OtqKiaApIJDI7VA6yrGZKwqgvdwl92++a5eu0Jy47MmcaN7IJ WBSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=jejZm+Ls; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ot6-20020a17090b3b4600b001f255162eaesi140656pjb.95.2022.08.09.14.13.09; Tue, 09 Aug 2022 14:13:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=jejZm+Ls; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245594AbiHIUO4 (ORCPT + 99 others); Tue, 9 Aug 2022 16:14:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245695AbiHIUOx (ORCPT ); Tue, 9 Aug 2022 16:14:53 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9A8825EA0 for ; Tue, 9 Aug 2022 13:14:51 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id v3so15586918wrp.0 for ; Tue, 09 Aug 2022 13:14:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=n+sIRfD+RQiRGeYS26jphMxCdbHEnhlhpCnFs913kcs=; b=jejZm+LsOkP/sKHcTEjTV6a/YYsp2p6PJWvV5Wq5e8AsJrGoqYxITRS6VyHhbYmoJM hz3dmUTvecCc+8BvqDnixZPoalS7dbYY5PMNY+/s85jL232ek1hkXHYI1OD5gzRwOV6k nlBEF2Gs8w1ocpv5PHneyEd6jUo47n/RFaR13fe5PGUkP23vB2QHFlpqLcpMtJqxujMF vfvY2a5JjxDykh1Wn/uI3hDCqNVys2WFTCDMTyXDTQLYOe4LiP+SYg/7YPfwdBLfYmXG giw3vBtwH9PmT61uF1ns7I+qhVCoRDczkpafU2m9cP6VaRONGMV3TLZI1ltQQGFyojJz UVTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=n+sIRfD+RQiRGeYS26jphMxCdbHEnhlhpCnFs913kcs=; b=dHBH5S1lDK4hS8Bn91fdD4IoZQt65nK+7u3vgOMAi2SGGYVKkslDywP3Fn2X/CmuTx T/eNTbuH41qAeA4zyKR28RTMxMn4MXWkovyXFpKPjnmswSIRPZJwRSFLKn+mNYRh12ic 11VQE2OdBBpJb/yrEr704867WBTTCE7hHXpRavw1XptAB9hJ3RMyGhBiAH3Mj4VrQHUw U0603l3JkUxlflSFYPWqcaM9K1soHAH/oA00ZK6Sr1ZGui8RqYiadTKX7LuyClwJ29Vp 7bCp6b3YKk5ipnbilX6PLN9rs1APsbzCOXQrSbicXyH5/U+EdiojJ8i3mn3yJ2kXE67j DmpA== X-Gm-Message-State: ACgBeo0WfjPPykZeNpgn3V2c89YB+iQ/gpowlLEEAIWKBnpxZWBm8FjP LHw31AFp35kRmZwHsnUoln0DfA== X-Received: by 2002:a5d:6608:0:b0:220:625e:f4e1 with SMTP id n8-20020a5d6608000000b00220625ef4e1mr16069047wru.252.1660076090308; Tue, 09 Aug 2022 13:14:50 -0700 (PDT) Received: from debian.office.codethink.co.uk ([2405:201:8005:8149:e5c9:c0ac:4d82:e94b]) by smtp.gmail.com with ESMTPSA id q15-20020a7bce8f000000b003a53e6c5425sm24041wmj.8.2022.08.09.13.14.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Aug 2022 13:14:49 -0700 (PDT) From: Sudip Mukherjee To: Tudor Ambarus , Pratyush Yadav , Michael Walle , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Cc: greentime.hu@sifive.com, jude.onyenegecha@sifive.com, william.salmon@sifive.com, adnan.chowdhury@sifive.com, ben.dooks@sifive.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: [PATCH v2 1/3] mtd: spi-nor: issi: is25wp256: Init flash based on SFDP Date: Tue, 9 Aug 2022 21:14:26 +0100 Message-Id: <20220809201428.118523-2-sudip.mukherjee@sifive.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220809201428.118523-1-sudip.mukherjee@sifive.com> References: <20220809201428.118523-1-sudip.mukherjee@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The datasheet of is25wp256 says it supports SFDP. Get rid of the static initialization of the flash parameters and init them when parsing SFDP. Testing showed the flash using SPINOR_OP_READ_1_1_4_4B 0x6c, SPINOR_OP_PP_4B 0x12 and SPINOR_OP_BE_4K_4B 0x21 before enabling SFDP. After this patch, it parses the SFDP information and still uses the same opcodes. Signed-off-by: Sudip Mukherjee --- drivers/mtd/spi-nor/issi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/spi-nor/issi.c b/drivers/mtd/spi-nor/issi.c index 89a66a19d754..8b48459b5054 100644 --- a/drivers/mtd/spi-nor/issi.c +++ b/drivers/mtd/spi-nor/issi.c @@ -71,7 +71,7 @@ static const struct flash_info issi_nor_parts[] = { { "is25wp128", INFO(0x9d7018, 0, 64 * 1024, 256) NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { "is25wp256", INFO(0x9d7019, 0, 64 * 1024, 512) - NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) + PARSE_SFDP FIXUP_FLAGS(SPI_NOR_4B_OPCODES) .fixups = &is25lp256_fixups }, -- 2.30.2