Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 9 Aug 2022 22:45:14 +0200
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Gregory Clement <gregory.clement@bootlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Marek =?utf-8?B?QmVow7pu?= <kabel@kernel.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: turris-omnia: Add ethernet aliases
Message-ID: <20220809204514.wu2om56mljsw4flz@pali>
References: <20220727130926.1874-1-pali@kernel.org>
 <20220727131504.avbfyoydzgcf6wyo@pali>
 <YvLDg7lbbaTF668e@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YvLDg7lbbaTF668e@lunn.ch>
User-Agent: NeoMutt/20180716
Precedence: bulk

On Tuesday 09 August 2022 22:28:51 Andrew Lunn wrote:
> On Wed, Jul 27, 2022 at 03:15:04PM +0200, Pali Rohár wrote:
> > On Wednesday 27 July 2022 15:09:26 Pali Rohár wrote:
> > > This allows bootloader to correctly pass MAC addresses used by bootloader
> > > to individual interfaces into kernel device tree.
> > > 
> > > Signed-off-by: Pali Rohár <pali@kernel.org>
> > > ---
> > 
> > Maybe this should have Fixes line?
> > 
> > Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
> 
> Is it broken with older kernels? That is a big part of Fixes: to
> indicate it needs back porting. Is this a new u-boot feature?
> 
> 	 Andrew

This is old u-boot feature. I was investigating why u-boot is not able
to correctly modify loaded omnia dtb file when booting linux kernel and
I found out that it is because it cannot due to missing ethernet
aliases.

Also there is a new u-boot feature for omnia to correctly put
phy-reset-gpios property into eth 2 node based on board hw revision. So
this is another purpose for which we should have those aliases, to allow
kernel to correctly reset wan (eth 2) PHY.

I would suggest this change for backporting into stable.