Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 9 Aug 2022 14:49:19 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     Rik van Riel <riel@surriel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>, <kernel-team@fb.com>
Subject: Re: [RFC PATCH 2/5] entry: Add calls for save/restore auxiliary
 pt_regs
Message-ID: <YvLWX4NiqReB5CHB@iweiny-desk3>
References: <20220805173009.3128098-1-ira.weiny@intel.com>
 <20220805173009.3128098-3-ira.weiny@intel.com>
 <YvJNe2rzXfcogFFX@zn.tnic>
 <YvKpi/CVHko50PNQ@iweiny-desk3>
 <YvKsS3QuOu4JVzZU@zn.tnic>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <YvKsS3QuOu4JVzZU@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4bfD42d9948GB4bw15fc6Fq9QIgFCQ1Mv729YvBVxCsDdhyxM1EFCva18Ykg?=
 =?us-ascii?Q?uJFLvVxaPq/dSRBg1ehk4CU9hM6UlRBAEqFiOlQMQI8YfX0i2QlUTY0P8woa?=
 =?us-ascii?Q?/wADEjaX05Z2uY+BIhX7SauYZNILKsiEPy2vXrvWMdo3k23AAGqOLqYCu9t3?=
 =?us-ascii?Q?NiJ51a6z272DIoOxyUOcncMICcT4pzP14cCzj8/tRZhZpaVfUA6UI7ERjSW0?=
 =?us-ascii?Q?9CpTV/4frwzlBgtqP3Kg4NZwj6t4Q6IyqSzmRO6tE451ZVvGXME3Jg8MQbky?=
 =?us-ascii?Q?mdKQ4kg5vGJauBR+gJzHTgfsALKd7iN7eWy59YhlCE3wkMBohRvp3oozJAXX?=
 =?us-ascii?Q?UIv6QGcfwdsNnbXDEmpENaxEHJ5axr+YTg1IVgKZN3sdBFu1fZxLzZsyZuKi?=
 =?us-ascii?Q?KooF31e5lp2i5ir9Wg/W5ERJZgsfkJGJlnpNDRl3AdBFOB39WTG7oWNOqe3w?=
 =?us-ascii?Q?ThF/61utQRovZG3YfByiqNzTZnuJ4627mPV1JOY39oqII7VkIg9N9QAX5K+3?=
 =?us-ascii?Q?blmJ4iFXyq+ZRtjbXemphMLgv930EJy462oMIBe/C3kj5dRv0k03cp76O0GF?=
 =?us-ascii?Q?5BaeVB70SZJYqBml3RO9Vr+nhkS6ysPSUr+NuyLyn5BDjYIDYFf51+PdN7Am?=
 =?us-ascii?Q?dVzxOoRKjLe0MdShjfJIPV73a+UAQBD1J3WX0VHwvw+2NeoFGCwROMFhEzKF?=
 =?us-ascii?Q?V8F7VTU4cZbCXvwrH/HgAoV3Ku2m/s/sg6NRqCsDx9QZMbMdVPpv7vMlPcs/?=
 =?us-ascii?Q?e5/PQS6JKnskNPrfkt+CxXcIQVljBQg8MoBMr5iVKauKpau6TNWc1FMBhBSc?=
 =?us-ascii?Q?fEc9J1QuR+Yu6FSG9hA3Pzswia39fsJjkccO8EH/uifYcEsmIbE1ObKYXGBd?=
 =?us-ascii?Q?Bk9g6J5pwsQyfuJ9ymJ+wjwFNMvwqxI4H+Fa6faB0tKV6C7vHGBP/CKjUV3o?=
 =?us-ascii?Q?2QNU2/zODLlSHqpJSQClSVgkqZ05UVZjdQqVnPiBXw40ivLSkTbx7AKq64Hs?=
 =?us-ascii?Q?KnE1PzkgJbJDMIgUE/n5jhMoRecEW85EvmhKcnqXB6gBQm5TT77FUWLoXyG6?=
 =?us-ascii?Q?ITxdtei8pPIP8ZKorinxaIZ3TN/aNvunCnvaahOT+7xk1L7sZtLPLR4ayVrT?=
 =?us-ascii?Q?ILk/+aboanJNltGE+D5RRlai2wvPVYIUjQ7lt7IRNJ3bgAY0xZC9iXo0PTAW?=
 =?us-ascii?Q?W/qbGGlTSht4mHRe0c+bXiEyDzaFHeeouoyB081F4uQNpWilAykVucWyhG0U?=
 =?us-ascii?Q?x04EbQMQt1A6x7Y6bGvnQLA1tATkmm1kARtVCEHpPszsFbL3o8Q+VIfcFp4E?=
 =?us-ascii?Q?yBkSC4RuI8JvH3lTSIUnszidENY9QpHGw8vg1Ka8gu+eFy8v0y7GSwIOM0w7?=
 =?us-ascii?Q?9wVI/pmr9UhGLNQV8IsNx7UJFnTVxkGJ33b82nd7ujTbkGezQ71TzzRo5HrM?=
 =?us-ascii?Q?QbF5HmjNxHUJYwOHAFjqs60w5vJG8LxEp41TH0NrFVw/EIYbzaHdkUKeSBqE?=
 =?us-ascii?Q?MWOMhU/nUTccPZyGPSXRONwT6hmoNpknCizxLkX+WTFzT1fh9JBv9z/793t7?=
 =?us-ascii?Q?cvg3NADpZ7QugH2r49nOgsdiJ2DTHPqDpPk51Ql/o4+QpdmXDhLJ2WWcGSlE?=
 =?us-ascii?Q?nQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e0c14499-a713-417d-37fe-08da7a510608
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2022 21:49:24.0831
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lZuw7t7adlMXtncw4dV/wQLPbexbfZo8IYzbQ4p3wl/4FQfOqsgXJ4v/qC3oalAtAmsqORDP1WD7a1BLsFD0sw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1342
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 09, 2022 at 08:49:47PM +0200, Borislav Petkov wrote:
> On Tue, Aug 09, 2022 at 11:38:03AM -0700, Ira Weiny wrote:
> > Thomas did a lot of work to make the entry code generic. So I was
> > keeping that work consistent. This also helps to ensure I did not miss
> > any places.
> 
> How about you worry about the other arches when you actually cross that
> bridge?

I guess I miss understood the reasoning behind Thomas' work.  No one mentioned
trying to isolate this to x86 during the PKS review.

> 
> > I don't believe this is correct because instrumentation is not enabled
> > here.
> 
> Why do you have to run
> 
> 	arch_save_aux_pt_regs()
> 
> with instrumentation enabled?

Sorry, that was carried over from the PKS series where I did need to call it.

I pulled this series over quickly to show basically what needed to be done.
But I did not review it for this detail.

> 
> Patch 5 does
> 
> +       struct pt_regs_auxiliary *aux_pt_regs = &to_extended_pt_regs(regs)->aux;
> +
> +       aux_pt_regs->cpu = raw_smp_processor_id();
> 
> only?
> 
> Why does that need to run with instrumentation enabled?

This does not.

Am I wrong that instrumentation begin/end are 0 overhead in production builds?

Ira

> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette