Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i5ec1447f:Fastmail
Message-ID: <7362f2f7795bebe9bbf9c00f0efd3eaa9143015d.camel@ljones.dev>
Subject: Re: [PATCH 3/5] asus-wmi: Add support for TUF laptop keyboard states
From:   Luke Jones <luke@ljones.dev>
To:     Pavel Machek <pavel@ucw.cz>
Cc:     hdegoede@redhat.com, markgross@kernel.org,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Wed, 10 Aug 2022 11:03:46 +1200
In-Reply-To: <20220807124102.GA32221@duo.ucw.cz>
References: <20220805081909.10962-1-luke@ljones.dev>
         <20220805081909.10962-4-luke@ljones.dev>
         <20220805120859.GB20036@duo.ucw.cz> <ZTI8GR.GMVLPPJWYEO53@ljones.dev>
         <20220807124102.GA32221@duo.ucw.cz>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (by Flathub.org) 
MIME-Version: 1.0
Precedence: bulk

On Sun, 2022-08-07 at 14:41 +0200, Pavel Machek wrote:
> Hi!
>=20
> > I'm sorry but can you direct me to a source file or other that
> > shows use of
> > "pattern trigger". I don't know what this means or what to look
> > for. From
> > your response it seems I should certainly be using it.
>=20
> Trigger is at drivers/leds/trigger/ledtrig-pattern.c , you'd want to
> do something similar to drivers/leds/rgb/leds-qcom-lpg.c .

I think we lost something in communication. This looks like it is all
done in software.

On these laptops, TUF and ROG, the LED effects are all done by the
keyboard EC. For the TUF series you can reference this
https://gitlab.com/asus-linux/reverse-engineering/-/blob/master/TUF-i2c_lap=
tops/led-rgb


It's for this reason I first went with a single node using "n n n n n
n" input.

Kind regards,
Luke.