Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <874jylots1.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: [PATCH] ftrace: makes ops_references_rec() inline
User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0
To:     Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>, Song Liu <song@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>
Cc:     linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=US-ASCII
Date:   Tue, 9 Aug 2022 23:56:48 +0000
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?USpznFp518QyG3w/n5Elza336/2McKeogHC+DhGrlksCHPuLgF8wQWdTQKdO?=
 =?us-ascii?Q?fRB0ThaA0S2GzejpGNOJ+LeA7GhW/hIBQ1qDXVjYMpbaqujHPHkPq7osZqvZ?=
 =?us-ascii?Q?Fm9Jb7+8HtCGg38B3TprlFykHU9y/kahwtpIRCCUewTtIkpGdfsCk7xAYkM7?=
 =?us-ascii?Q?jIRdipeC95wwXcacSVbykPbrvbsi1B/l9B5xXeZOThX1CekEEpoDWtVa2eAD?=
 =?us-ascii?Q?/QFHOJkgHBC8e2Z8ZNhdhYWkH01rmmYoOegFLyNcuqUlbp7qOJAbUh2J47Y/?=
 =?us-ascii?Q?jUBpbwVLqZpQM4OMRESK/BaA7oEGavE0oaUkMVuzKV/+1aQ4hMxxtJYTUzTd?=
 =?us-ascii?Q?jyPgGMZvhUBmox13zgc/q5kQ1XxHsR8m7JE+FXRS7qdss/O2oKSXJYeUyxH2?=
 =?us-ascii?Q?PtceYE8g1GCaH+amS8fZ5aimrgMxCsZmqHEDTeel7V+XO4Nr9a9KZGlVzRFE?=
 =?us-ascii?Q?j5iVaPwbkj73AXKXFQs9V7ISsyVNGIsxjrKgapG3ajV/zCBzMB5ok6Ywp8BJ?=
 =?us-ascii?Q?XLVrt3WeEbRCP0ymcm59tl3tzHLL/+aE5Kl9seIWkMAuS3WJILimAgVgzW/Y?=
 =?us-ascii?Q?0U2sSOKvhtgjEPOPZAVNmWwqZFJcqdbxwdSoNx8YzUqlZYkXwYtv/4LIehY+?=
 =?us-ascii?Q?tXPRKM6hKn1SKZYTw5lqa6rP3TYxGd4ZscyuyHuDOCRdyI0i6F9sp64NFyVE?=
 =?us-ascii?Q?wS5KOtqFVfpbGQXszaTfq4ML1dlFgY4iQHoKzljJHyPSluHDd4i3aa3QTyAH?=
 =?us-ascii?Q?PgyW46J+bGEpb6ICM4TrzYJozQdSjAhR2coBCoUte308aVKkR2V88W78qgor?=
 =?us-ascii?Q?Ro7lHrXb95QDPL2emD587IKxw2LBdK/8714Wvh2H/0B35j74YH4WFzBrxAxw?=
 =?us-ascii?Q?Q2qdbBHhmzrN7oKW7wDWNa+9y3iAXzFI+j3UxEnBUhF1QTsfV2rwEXiKSHOc?=
 =?us-ascii?Q?dJAPZU+qfXhXh61nCB9prEsu20j3mdx0g0HP6PlGUr4vfISvHnDYjQEYtrH0?=
 =?us-ascii?Q?W9iGNWjvToSFQQFf3+C7Lf103WX9Rc3+6Hk3Gq9KzhNRFDnkhVj3JrVb3MZB?=
 =?us-ascii?Q?qLDRGGTQqfZhRmFD9IvIcaJ6Rq4QXu+hiao5iGJjN+UQ1IISGeAFolgMUJQZ?=
 =?us-ascii?Q?CJnd316kMLjfjk4QNlAGhoAS4EXInavuxx4veQ80OjzehmIQpebq+mmvn2Np?=
 =?us-ascii?Q?F0KNIEWyQ/orRJNuZKICeiCx5Au3EGm+T55NQoaETyaLDl3STNBmu0aItUJQ?=
 =?us-ascii?Q?e7YW41hYEVbeUsPv3v1d671q9lTvhMFszK4umsHOJAnhx88atfhWx3sYNwt/?=
 =?us-ascii?Q?n0bVY7uApianhM205QpDO3J/L182dImPU/dmibkpwUWBZRqrjNJxpDTthF6g?=
 =?us-ascii?Q?I46SuDnxFVn1RjxJhH2deaF5TNe4YQg6/9Au/GiBQIm+ivmDOmrmiUiVBaTa?=
 =?us-ascii?Q?d81Nnkqq2iEJixkjl6kW1+2IKjrhgcP2IpKCHDLZQS3RIUJ1ClRByexDkn4U?=
 =?us-ascii?Q?PSPazB0koaKh4VBz/X7kBFEHspR0knf0zSJhk79WsQ0Dr4q1wV3LFClbw8Uw?=
 =?us-ascii?Q?8Wugm0phFVAdEHJ0uayFwr3pw91GH1g0nfujiOnruL8Q1iuffcMW1VFKHKRc?=
 =?us-ascii?Q?sFupLz4NfVmHzNPmNwWQ+EQ=3D?=
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18640c26-5f31-449b-3d56-08da7a62d292
X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2022 23:56:48.5935
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kWqMYvtXbdjT0Ex5xKmGaADgRzFDDRqlGJa0wBqLFqTvt4kuE/WI6SHWtl+5vO0tsTWkooQkFX2iOnEv0A/QUKqjc06e96mIRT4syvLDk+lw4hclvSIVIRBh9RXeFoEI
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSAPR01MB3905
X-Spam-Status: No, score=0.9 required=5.0 tests=AC_FROM_MANY_DOTS,BAYES_00,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


commit 53cd885bc5c3e ("ftrace: Allow IPMODIFY and DIRECT ops on the
same function") removes "inline" from ops_references_rec(),
thus we will get below error if .config doesn't have CONFIG_MODULES.

  CC      kernel/trace/ftrace.o
${linux}/kernel/trace/ftrace.c:3149:1: error: 'ops_references_rec' \
defined but not used [-Werror=unused-function]
 3149 | ops_references_rec(struct ftrace_ops *ops, struct dyn_ftrace *rec)
      | ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [${linux}/scripts/Makefile.build:249: kernel/trace/ftrace.o] error 1
make[1]: *** [${linux}/scripts/Makefile.build:466: kernel/trace] error 2
make: *** [/opt/disk_cd/morimoto/linux/Makefile:1843: kernel] error 2

This patch adds "inline" again, and fixes the issue.

Fixes:  53cd885bc5c3e ("ftrace: Allow IPMODIFY and DIRECT ops on the same function")
CC: Song Liu <song@kernel.org>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 kernel/trace/ftrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index bc921a3f7ea8..b52782857f97 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -3145,7 +3145,7 @@ ops_references_ip(struct ftrace_ops *ops, unsigned long ip)
  * If the ops does not trace the current record function, skip it.
  * If the ops ignores the function via notrace filter, skip it.
  */
-static bool
+static inline bool
 ops_references_rec(struct ftrace_ops *ops, struct dyn_ftrace *rec)
 {
 	return ops_references_ip(ops, rec->ip);
-- 
2.25.1