Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1238beb0a140a0987b8fdda6e7bbadfbb2415ed4.camel@mediatek.com>
Subject: Re: [PATCH v5 02/20] dt-bindings: memory: mediatek: Update
 condition for mt8195 smi node
From:   Tinghan Shen <tinghan.shen@mediatek.com>
To:     "=?ISO-8859-1?Q?N=EDcolas?= F. R. A. Prado" <nfraprado@collabora.com>
CC:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
        Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Lee Jones <lee@kernel.org>,
        "Matthias Brugger" <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        MandyJH Liu <mandyjh.liu@mediatek.com>,
        <iommu@lists.linux.dev>, <linux-mediatek@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <Project_Global_Chrome_Upstream_Group@mediatek.com>
Date:   Wed, 10 Aug 2022 09:51:32 +0800
In-Reply-To: <20220809135312.hadcs7ti2cgyyuez@notapiano>
References: <20220804021553.14867-1-tinghan.shen@mediatek.com>
         <20220804021553.14867-3-tinghan.shen@mediatek.com>
         <96e66425-ff2a-4640-8b96-48fa39943bf9@linaro.org>
         <6a1977971317059fcfad685869b6ccf233edcb68.camel@mediatek.com>
         <20220809135312.hadcs7ti2cgyyuez@notapiano>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 2022-08-09 at 09:53 -0400, Nícolas F. R. A. Prado wrote:
> On Tue, Aug 09, 2022 at 07:01:10PM +0800, Tinghan Shen wrote:
> > Hi Krzysztof,
> > 
> > On Thu, 2022-08-04 at 17:12 +0200, Krzysztof Kozlowski wrote:
> > > On 04/08/2022 04:15, Tinghan Shen wrote:
> > > > 
> > > > It's because the 'mediatek,mt8195-smi-sub-common' compatible incorrectly
> > > > matches the 'else' conditions for gen2 HW without gals.
> > > > 
> > > > Rewrite the 'else' condition to specifically identify the compatibles
> > > > that utilizing gen2 HW without gals.
> > > > 
> > > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> > > > Reviewed-by: AngeloGioacchino Del Regno
> > > >  <angelogioacchino.delregno@collabora.com>
> > > 
> > > Unfortunately, your patches got corrupted.
> > > 
> > > 
> > > Best regards,
> > > Krzysztof
> > 
> > Do you mean rebase to the latest linux-next?
> > I'll rebase in the next version, thanks!
> 
> Hi TingHan,
> 
> the issue is that some line wrapping happened on your patches, which broke tags
> and also the diffs themselves (it's very obvious on patch 3). So you need to
> sort out your setup so that no longer happens, and resend the patch.
> 
> Thanks,
> Nícolas

I see. I'll send the next version after fix the weired wrapping...
Thank you.


Best regards,
TingHan