Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1b94fa11-ee73-6fce-be1c-c113329c27b8@ftdichip.com>
Date:   Wed, 10 Aug 2022 11:55:41 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.0.3
Subject: Re: [PATCH v1] USB: serial: ftdi_sio: add IDs for NEW FTDI Products
To:     Johan Hovold <johan@kernel.org>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        gregkh@linuxfoundation.org, malliamireddy009@gmail.com,
        arun.pappan@ftdichip.com, sowjanya.reddy@ftdichip.com
References: <ac28f2c5eba23a645b3b9299c224f2755a233eef.1658385786.git.mallikarjuna.reddy@ftdichip.com>
 <Yu0DgKWYqGim7y3E@hovoldconsulting.com>
Content-Language: en-US
From:   "Amireddy Mallikarjuna Reddy (FTDI-SG)" 
        <Mallikarjuna.reddy@ftdichip.com>
In-Reply-To: <Yu0DgKWYqGim7y3E@hovoldconsulting.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cEtGMmVzREtGcVEyUXRHWjBoWlZzaW1pbmVEbzhMTzQ0VmViNGt2YjNZKzNZ?=
 =?utf-8?B?aVhjT0t1N0orU0Z1M0ZZMmZFZEFvWC9WeHliVGVHK2RoQUxHS21HWEY0bWlF?=
 =?utf-8?B?aHg5aHRBcm82b2piSkZoTEJnazhpeEt4YVJ2aXFxcTNEMklIWEVDRWE4ZEdz?=
 =?utf-8?B?L3RQbEJTYjAvRElpem5OSXdKaENEOWt4VFB6N1h0Qm9xLzQ4N3RPdlFjV2hP?=
 =?utf-8?B?SC9jRE9sSFhpV1VsWm45QXZOTFh6UG9KdGg0citpZTkvOXJVNzNzeTNVRFhu?=
 =?utf-8?B?dm14YlhybTVuWUhRbXQxaVBQbjlucDlZaGpKMnlqeWU4UVc4V1lZVzBLTmtP?=
 =?utf-8?B?emd6aWIrTTIvaEwyeTlLZkZPYVhtVGRQYXFYNkJETUVBMHZOWFhFZG9yVlhn?=
 =?utf-8?B?bGdscTN0aUJRS1lUdUw2RXZUa0xicm4rdGpXL0JIeVU3WkJBZjlnQkNpbW93?=
 =?utf-8?B?b0tRRGRIbENzMm5EdVA3ekNNM0dreTVielU5RWlPYWhoVmRaVTU0U1h6SU5N?=
 =?utf-8?B?OUEzaXc4T2tGTTZpODQ3SXJRTFE1NjFwWHAwSlZCdk9mL1h6UzJHRGZTWjRx?=
 =?utf-8?B?YUo2YzlMNnpKL3Z4R05TNjVoaEZ4NTU5eGtHRmlDOEpRTXRRbHdyQ2owREZB?=
 =?utf-8?B?QWxDMU1RaGhUUDg0eEVldEFYdGFydlVmWUcya213TEZJdWw4RllEVE9uK3lZ?=
 =?utf-8?B?UXpqTnZHMFhEY0ZXZXYxeEZydGtaWThDeHFhUWlqZWk3N0NpUW9odDROQW9L?=
 =?utf-8?B?eVZVQ3hpMitoZzNQNVhNb0NjMnp4c0czeG5YdUlVSGFabkZ5bFJhUXFYYnRD?=
 =?utf-8?B?OVByWURMeXJkOTZhZDBqcnZSVGVxS2NicjRiQUpvV0FwVDZ5NVdwRjI1Zy8r?=
 =?utf-8?B?S2hPVnV2WGVzRVRLMHRyNngwQjZRVXZuQlF3Y0E0amlpQzQ0UDR2MkJGaS83?=
 =?utf-8?B?RW1Ndi9TU0dqYkxKenJaTzNsbXNrc25vOEtBdUxnWEhwN0pBaXBVeFdta3J3?=
 =?utf-8?B?TFM2QTJ5cFdJNEpBK2ZuRHduTVZKSkZPZWFPS28vMENDaVVOMlkrTS9TZ25v?=
 =?utf-8?B?bVA5VU42ajl2aGxvS3RJTncvV1VLWnhwNGQ2LytXUEVxeFFzTzNUK0ZpOXEr?=
 =?utf-8?B?eThsWWl4Y0t0QlV2c2RFT3hZL291ajllVUtBOFlFa0dROW1qNDNGSnVrMkF1?=
 =?utf-8?B?a3RYcitOVmRDYWtFbDFEVUw0ZEJWeTVHQ3VIVi9VekFybCt2TVF3aWltdjBl?=
 =?utf-8?B?M0s0K2hSUVkzY0d1S1lBOVd1RTQxa3VHWmtqRXhaaDNqdjFuWnJ5Qmk1cFA5?=
 =?utf-8?B?eTJ5Wnd1M1kzK2xvUlVzVUxjN05HZGdJOU9MeENTcmh3NHlvWjFIdng0ZHl2?=
 =?utf-8?B?QjlSUHc4L3dIVUJkZWt1VXRQbzNZUXV4VmptQUlIaG1lT2M0Vm4xckFxMmhh?=
 =?utf-8?B?bHVUK2d4UUxvb2QrdDc3dVBnK0lEb0EzQUgzV2NtbGc3cWNZdTF1Qk43TmI1?=
 =?utf-8?B?S3ZRU0U4dVdUY0dZM3p5SFJJaUx2NmhyZVpaTFRLUFVON1NpbUc5QWlXQlZD?=
 =?utf-8?B?UzM1Q1doWjlneXlZZ1pzUGg5cWpweHlWaU5Ud2IzVVBhTnYyMC9FdTlUZzcy?=
 =?utf-8?B?dmVTZFMxdENNUFhUd2EzUXpxY0plRVJqMHhXOHdYckczS3VIdFM0SGpMUmcr?=
 =?utf-8?B?WWRJTEhHRE9Zamd4VGhTaG92NE1WbUpxSUdOZjlNamtqdU9BYUMzMG5YQWlG?=
 =?utf-8?B?ejZZOVRXbmxpMjhqMWc1SU9RZnptT0R3TkZOMWl6LzNtWkR6WW5pbVVOQjFX?=
 =?utf-8?B?RndDbWVPZkt1Y1ZOdnR2b0V6MDdITThZRy85OUhiaDZjUXFHWFlpbEQ3UkM2?=
 =?utf-8?B?SGpzZkhmZW9KMXZYU2h2RnhGalFoSnR3emNESEFlU3lSTEE3QzYxVmxQbGw5?=
 =?utf-8?B?ZWRyaXloTlZtSlJlYVdZSEhmdyt1NlVUSEE0NmlvRVVTSjNyRFdMOVliR3cy?=
 =?utf-8?B?bDZMV0M2T1M2Mk9RV3hub2xUZ2JMazJ3dWdHZDRKOVlyajR4VFZOMmRmbHRM?=
 =?utf-8?B?aU5wSU5LREthMjA0d3NBYXhKREw5Tzc2YjFKS0VudGxXTTc0cHJYVjBWbndC?=
 =?utf-8?B?b0NZeDFCWVZhMXR1K2JKMTUrQ1BqN0Y1c3R1Q2kyV3JYWHZ6ZzFGc0FBUmND?=
 =?utf-8?Q?7kEMOW4dExAziHoww2+R6Tk=3D?=
X-OriginatorOrg: ftdichip.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0751c7e7-5248-45e5-6086-08da7a8445c6
X-MS-Exchange-CrossTenant-AuthSource: SG2PR01MB2886.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2022 03:56:15.3746
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: c2456335-1328-47c5-82f2-1fe6783d7182
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wq84I1ew/sHKJ2gJ1/SXEFN5t1Oshd1VSYDAqE/aV0oMUaRsYkzN6dMqeDk2CyVNOgChkOeAxI/Z3INZuABKMBA6Hu2Rd6JZJb7gCMPx/ec=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR01MB3460
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thank you very much for the review Johan.

mallik

On 5/8/2022 7:48 pm, Johan Hovold wrote:
> On Thu, Jul 21, 2022 at 03:02:44PM +0800, Amireddy mallikarjuna reddy wrote:
>> Add the product IDs for the USB-to-Serial devices FT2233HP, FT2233HP,
>> FT4233HP, FT4232HP, FT233HP, FT232HP, and FT4232HAQ.
>> Also include BCD values so that the chiptype can be determined.
>>
>> Signed-off-by: Amireddy mallikarjuna reddy <mallikarjuna.reddy@ftdichip.com>
>> ---
>> v1:
>> - Initial version.
> Thanks for the patch. This looks mostly good even I should revisit some
> clean-up patches I have laying around that gets rid of the unnecessary
> device-type conditionals that you're now extending.
>
> I'll either rebase this patch on top or the other way around, but either
> way I'll get this in in some form in a few weeks (e.g. after the merge
> window closes).
>
> Johan

-- 
This email has been checked for viruses by AVG.
https://www.avg.com