Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d8fd3251-898d-89fe-226e-e166606c6983@virtuozzo.com>
Date:   Wed, 10 Aug 2022 08:54:52 +0300
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.1.1
Subject: Re: [PATCH v1 1/2] Enable balloon drivers to report inflated memory
To:     "Michael S. Tsirkin" <mst@redhat.com>
Cc:     Jonathan Corbet <corbet@lwn.net>,
        Andrew Morton <akpm@linux-foundation.org>, kernel@openvz.org,
        David Hildenbrand <david@redhat.com>,
        Wei Liu <wei.liu@kernel.org>, Nadav Amit <namit@vmware.com>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-mm@kvack.org
References: <7bfac48d-2e50-641b-6523-662ea4df0240@virtuozzo.com>
 <20220809094933.2203087-1-alexander.atanasov@virtuozzo.com>
 <20220809063111-mutt-send-email-mst@kernel.org>
From:   Alexander Atanasov <alexander.atanasov@virtuozzo.com>
In-Reply-To: <20220809063111-mutt-send-email-mst@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmtOQXFjWnpqZFhEM1BnS2hEd1VyRmxTWUpBVWV3QlFoQXhzNWV1TEhObzlv?=
 =?utf-8?B?YklyTWJvZStSRVk0VFBzUWx2TUw2TGlCYXdJRFp5RGM2YTlldXlxUHNnOHRR?=
 =?utf-8?B?R2FFL3VaYVRjby9NZUFFaHQzcEp1U0FEOTVmazFlbW5Oa0VJNGwrTlQzaEpr?=
 =?utf-8?B?anhoZEFmNzVVc2JpRlZ6U3Y0V2FyMC9Wd09PSXA3MzduSnVPQnZYZWViZjlj?=
 =?utf-8?B?bm5QbXRWd1JqV2c0VTFiR0V5YzlEaW5OZURNeVIzUjF1UE4wZS94Z202SW5W?=
 =?utf-8?B?bE5PVllwNmQzNkFLbWVoNG52MVlnQnVRZzlvakpDUVFDRmwvNWVEKzBoS0V5?=
 =?utf-8?B?MWxDdm82bGV4YkYvRUgrK0RyVDA4dmZsVUZDSDZEQ0I0cFViNW1RcXJSc2Nx?=
 =?utf-8?B?ODJIcFNzN2UyQ3lUWkZNQ1R0Q05HV0xiUUxtZWVzbzVZRHd1cnpWYWFuSGdz?=
 =?utf-8?B?ald4MXlBeTNUQkF2aGFtcndnQjI5dXdNN2c3RkZCcUpHenhYSkJ6eE9QTVNH?=
 =?utf-8?B?SG5TQ2NLeExib2VCQ2JxNytsWGh4TC9yZXNiZkU0czdDQ0phcWhLVy8xNHBo?=
 =?utf-8?B?TG5lVlV6azdvZ29aV0JITVZ5T3hOeTJhQkpPcklXR2pYdVZwNldETDA0L1dD?=
 =?utf-8?B?WnJDRkdVdGF3NTFSU1d5K1dEaUpINU5lRHQxVFJJUUFRUmYwTkZKU0Zrd1Mz?=
 =?utf-8?B?YTZPeDZGVE9oUkVCSGE5dEoxeHlTZXBrQWxmNE1hVlRQVm9YWmUwK3dDeWNH?=
 =?utf-8?B?b3FvekkvdEhEbVJPelJnRHR4RFFXemd2TS8vZFhhMFJhWUg3N2czeGZzUWNk?=
 =?utf-8?B?ZVk3TFMxbHVRUWRETjlnUnBmL0o1emNTc0ZndFc1enZ5TTdnWEpyN1VFS3l5?=
 =?utf-8?B?Ti9wNWdBZ2ZveTdNUCtKNEN4eUl4cUd4SHF3SFhack5iVDJJc05JakxTdlNw?=
 =?utf-8?B?YnVoMmxmZnMwWjVGL1VaTkh3bUlhcUxRU29iQWZ4WUNYQnFwMnkvNW12S3pq?=
 =?utf-8?B?SHBRd2ZYMkFVZWFJenpyQ2ZWTk9sSmpDUVkydU5hTzFwVFdTNHRBNzE5cHM2?=
 =?utf-8?B?amcvSFRiYnRFYm93d0NPQUNaK0VUTTN1c1F5aFd0WjhVZ25Qci9aZ1h0UlFt?=
 =?utf-8?B?RmF1L09aRWNQaU5reEJjQ1RxQVVlMkxWMjF2WjlXSTArRDNGcnZEL0dqbDBu?=
 =?utf-8?B?VUtSZk4raDNFZTYrT2ZJRDUxQXlPckJtWVJOeG9COTZtS3JtRHJRZEozeGky?=
 =?utf-8?B?cWl4UkY2WXpPRS9ZZ2w3RnowRk8yMHpnRklTcmo3YlZwOGlPVjl3VHBjcUlM?=
 =?utf-8?B?TGtzYnZZNHZJcEFSYUx1ays1UFVVQ0NJTEFicm1kaUFkemFSSDNlZlJ2Y2VM?=
 =?utf-8?B?czgyTkMyMktmQ1VpSHF5d2JoZ21SOVFia0NuWTJOaVd3VjdRejVIS1ZEM2xm?=
 =?utf-8?B?UGl5TC9uTUY3Z2FXT3QxRlFROW15SmxMQ0t4L1VzcjZtUlUxR2I5QVpScG0x?=
 =?utf-8?B?MzlXY1JiWWtLTmtocG4vL0RoMnZySHRsYzFHczNURFg4M2JjZVVSUGxJWnNk?=
 =?utf-8?B?QTN0RDRKWjlrS3A5c3loSEJucVVXakxpRUZVTUVabGRaM1dsRkNkZnMweUpI?=
 =?utf-8?B?Q3B3NmErbzIrbGN0dXUzeTkvNllwK2t1VTBLOTJOTVMxcEtNaHdOenVKNkc3?=
 =?utf-8?B?K2QwVlIrekNqckQ1NkdhL25FTUlNM01zNU04Njl4OHpnT2N0aVFIV2JjL2Fq?=
 =?utf-8?B?TmY2K1JpZ21GRTdSRnprekg4Q3lZQnJVbFlEQnJ4aFp5MFVSeUs1N1AwUTJL?=
 =?utf-8?B?UU1KUWlNenBXdDVjQmRZbnpsWngzdUZ3dmlBRnl0V3lEZkRDdlFzNno4ZEd6?=
 =?utf-8?B?NEdDbU5Cc2tNbno2U3FTeEdHZ0V6Q0FrOGtCNWlOcUJlVkV2bHdGcHhkSnkz?=
 =?utf-8?B?MEN1aEFZSHZWZlZPZWJDVzJmZUZTQ2RFeklPU1V3bTI3dEZTdWlsd0VkKzRU?=
 =?utf-8?B?KzFyYVBEMFZJYWE4akFWRHZGK3ZnSXpUU1VRbkR4TmtXVzRZSVZUSFN3emxi?=
 =?utf-8?B?V2pvWXh4VWwxV3czK3RQOVVVNXlqODQ1UWhLMnJmTkgzenhuZmZCNWlqT2ti?=
 =?utf-8?B?dkc4RE5Gbkt0UWR0OVdyYkJGTnl3aGtZTkN4WDM5WHdCYk0yNUJyS01rdTZI?=
 =?utf-8?Q?o3jic9wYdFCZjHqG5pnB9lE=3D?=
X-OriginatorOrg: virtuozzo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46326523-6c99-4ec1-4d26-08da7a9501e3
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4765.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2022 05:56:02.7985
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Tp1j4HzOtVkp+Z4zeFGWC/dPN4xFSiVGheiN01s3iipDOfBGalCnqYAJH0KCFbJ/YA0dSCfLfGodwueua39xWaEkDuNLZSl/MjOVvx8evbjTA62W1m472veBcawqUJW6
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2646
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9.08.22 13:32, Michael S. Tsirkin wrote:
> On Tue, Aug 09, 2022 at 12:49:32PM +0300, Alexander Atanasov wrote:
>> @@ -153,6 +156,14 @@ static int meminfo_proc_show(struct seq_file *m, void *v)
>>   		    global_zone_page_state(NR_FREE_CMA_PAGES));
>>   #endif
>>   
>> +#ifdef CONFIG_MEMORY_BALLOON
>> +	inflated_kb = atomic_long_read(&mem_balloon_inflated_kb);
>> +	if (inflated_kb >= 0)
>> +		seq_printf(m,  "Inflated(total): %8ld kB\n", inflated_kb);
>> +	else
>> +		seq_printf(m,  "Inflated(free): %8ld kB\n", -inflated_kb);
>> +#endif
>> +
>>   	hugetlb_report_meminfo(m);
>>   
>>   	arch_report_meminfo(m);
> 
> 
> This seems too baroque for my taste.
> Why not just have two counters for the two pruposes?

I agree it is not good but it reflects the current situation.
Dirvers account in only one way - either used or total - which i don't 
like. So to save space and to avoid the possibility that some driver 
starts to use both at the same time. I suggest to be only one value.


> And is there any value in having this atomic?
> We want a consistent value but just READ_ONCE seems sufficient ...

I do not see this as only a value that is going to be displayed.
I tried to be defensive here and to avoid premature optimization.
One possible scenario is OOM killer(using the value) vs balloon deflate 
on oom will need it. But any other user of that value will likely need 
it atomic too. Drivers use spin_locks for calculations they might find a 
way to reduce the spin lock usage and use the atomic.
While making it a long could only bring bugs without benefits.
It is not on a fast path too so i prefer to be safe.

-- 
Regards,
Alexander Atanasov