Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5640838e86add62f7e4bd811391fcc60b7ee42b1.camel@svanheule.net>
Subject: Re: [PATCH v1 1/5] lib/test_cpumask: drop cpu_possible_mask full
 test
From:   Sander Vanheule <sander@svanheule.net>
To:     =?ISO-8859-1?Q?Ma=EDra?= Canal <mairacanal@riseup.net>,
        Yury Norov <yury.norov@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc:     linux-kernel@vger.kernel.org, David Gow <davidgow@google.com>
Date:   Wed, 10 Aug 2022 10:18:55 +0200
In-Reply-To: <15acd7ab-e624-b2ee-cde5-100b69cf7206@riseup.net>
References: <cover.1660068429.git.sander@svanheule.net>
         <30d8882efedea697da20c27563050008d1569b9e.1660068429.git.sander@svanheule.net>
         <15acd7ab-e624-b2ee-cde5-100b69cf7206@riseup.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

Hi Ma=C3=ADra,

On Tue, 2022-08-09 at 19:26 -0300, Ma=C3=ADra Canal wrote:
> On 8/9/22 15:08, Sander Vanheule wrote:
> > cpu_possible_mask is not necessarily completely filled.=C2=A0 That mean=
s
> > running a check on cpumask_full() doesn't make sense, so drop the test.
> >=20
> > Fixes: c41e8866c28c ("lib/test: introduce cpumask KUnit test suite")
> > Link: https://lore.kernel.org/lkml/346cb279-8e75-24b0-7d12-9803f2b41c73=
@riseup.net/
> > Reported-by: Ma=C3=ADra Canal <mairacanal@riseup.net>
> > Signed-off-by: Sander Vanheule <sander@svanheule.net>
>=20
> Tested-by: Ma=C3=ADra Canal <mairacanal@riseup.net>

Thanks for testing again, and sorry for the trouble!

Best,
Sander

>=20
> > Cc: David Gow <davidgow@google.com>
> > ---
> > =C2=A0lib/test_cpumask.c | 1 -
> > =C2=A01 file changed, 1 deletion(-)
> >=20
> > diff --git a/lib/test_cpumask.c b/lib/test_cpumask.c
> > index a31a1622f1f6..4ebf9f5805f3 100644
> > --- a/lib/test_cpumask.c
> > +++ b/lib/test_cpumask.c
> > @@ -54,7 +54,6 @@ static cpumask_t mask_all;
> > =C2=A0static void test_cpumask_weight(struct kunit *test)
> > =C2=A0{
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0KUNIT_EXPECT_TRUE(test,=
 cpumask_empty(&mask_empty));
> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0KUNIT_EXPECT_TRUE(test, cpum=
ask_full(cpu_possible_mask));
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0KUNIT_EXPECT_TRUE(test,=
 cpumask_full(&mask_all));
> > =C2=A0
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0KUNIT_EXPECT_EQ(test, 0=
, cpumask_weight(&mask_empty));