Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 10 Aug 2022 10:01:16 +0200
From:   Michael Walle <michael@walle.cc>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     daniel.lezcano@linexp.org, abailon@baylibre.com,
        anarsoul@gmail.com, baolin.wang7@gmail.com,
        bjorn.andersson@linaro.org, broonie@kernel.org,
        damien.lemoal@opensource.wdc.com, digetx@gmail.com,
        f.fainelli@gmail.com, glaroque@baylibre.com,
        hayashi.kunihiko@socionext.com, heiko@sntech.de, j-keerthy@ti.com,
        jonathanh@nvidia.com, khilman@baylibre.com,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        lukasz.luba@arm.com, matthias.bgg@gmail.com,
        mcoquelin.stm32@gmail.com, mhiramat@kernel.org,
        miquel.raynal@bootlin.com, niklas.soderlund@ragnatech.se,
        rafael@kernel.org, rui.zhang@intel.com, shawnguo@kernel.org,
        talel@amazon.com, thierry.reding@gmail.com, tiny.windzz@gmail.com,
        Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v5 00/33] New thermal OF code
In-Reply-To: <27c03303-9ee5-d9df-b7f2-016491fce9e5@linaro.org>
References: <20220804224349.1926752-1-daniel.lezcano@linexp.org>
 <20220808094216.928018-1-michael@walle.cc>
 <27c03303-9ee5-d9df-b7f2-016491fce9e5@linaro.org>
User-Agent: Roundcube Webmail/1.4.13
Message-ID: <5adfe0882926d8f16c158d453069b37b@walle.cc>
Precedence: bulk

Hi Daniel,

Am 2022-08-09 10:23, schrieb Daniel Lezcano:
>> On my second board
>> (arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dts). I get 
>> the
>> following error:
>> 
>> [    6.292819] thermal_sys: Unable to find thermal zones description
>> [    6.298872] thermal_sys: Failed to find thermal zone for hwmon id=0
>> [    6.305375] lan966x-hwmon e2010180.hwmon: error -EINVAL: failed to 
>> register hwmon device
>> [    6.313508] lan966x-hwmon: probe of e2010180.hwmon failed with 
>> error -22
>> 
>> Again, is there seems to be something missing in the device tree. For 
>> this
>> board a device tree change should be easily doable, as it is still in
>> development.
> 
> Logically with the fixes I've send these errors should have gone. Just
> a pr_info should appear "... not attached to any thermal zone".
> 
> If I'm correct, without or with the changes (new thermal OF code +
> fixes), the hwmon message is the same and the hwmon thermal zone is
> not created. So no regression hopefully.
> 
> Is it possible to check that?

Yes, I'm no more seeing any error messages and the device
is probed successfully. Both on the kswitch board as well as on
the sl28 board.

Thanks,
-michael