Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 Aug 2022 15:23:15 +0530
From:   Siddh Raman Pant <code@siddh.me>
To:     "Piyush Thange" <pthange19@gmail.com>
Cc:     "davem" <davem@davemloft.net>, "edumazet" <edumazet@google.com>,
        "kuba" <kuba@kernel.org>, "pabeni" <pabeni@redhat.com>,
        "shuah" <shuah@kernel.org>,
        "vladimir.oltean" <vladimir.oltean@nxp.com>,
        "idosch" <idosch@nvidia.com>, "petrm" <petrm@nvidia.com>,
        "troglobit" <troglobit@gmail.com>, "amcohen" <amcohen@nvidia.com>,
        "tobias" <tobias@waldekranz.com>,
        "po-hsu.lin" <po-hsu.lin@canonical.com>,
        "netdev" <netdev@vger.kernel.org>,
        "linux-kselftest" <linux-kselftest@vger.kernel.org>,
        "linux-kernel" <linux-kernel@vger.kernel.org>,
        "linux-kernel-mentees" 
        <linux-kernel-mentees@lists.linuxfoundation.org>
Message-ID: <182872c2de1.4461d55242061.8862004854197621952@siddh.me>
In-Reply-To: <20220810093508.33790-1-pthange19@gmail.com>
References: <20220810093508.33790-1-pthange19@gmail.com>
Subject: Re: [PATCH] selftests:net:forwarding: Included install command
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Importance: Medium
User-Agent: Zoho Mail
Precedence: bulk

On Wed, 10 Aug 2022 15:05:08 +0530  Piyush Thange <pthange19@gmail.com>  wrote:
> If the execution is skipped due to "jq not installed" message then
> the installation methods on different OS's have been provided with
> this message.
> 
> Signed-off-by: Piyush Thange <pthange19@gmail.com>
> ---
>  tools/testing/selftests/net/forwarding/lib.sh | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh
> index 37ae49d47853..c4121856fe06 100755
> --- a/tools/testing/selftests/net/forwarding/lib.sh
> +++ b/tools/testing/selftests/net/forwarding/lib.sh
> @@ -152,6 +152,14 @@ require_command()
> 
>  	if [[ ! -x "$(command -v "$cmd")" ]]; then
>  		echo "SKIP: $cmd not installed"
> +		if [[ $cmd == "jq" ]]; then
> +			echo " Install on Debian based systems"
> +			echo "	sudo apt -y install jq"
> +			echo " Install on RHEL based systems"
> +			echo "	sudo yum -y install jq"
> +			echo " Install on Fedora based systems"
> +			echo "	sudo dnf -y install jq"
> +		fi
>  		exit $ksft_skip
>  	fi
>  }
> --
> 2.37.1

This is very specific to `jq` command. What's special with `jq` and not
others? If methods have to be shown, they should be shown for all the
programs which are not installed.

Further, this limits the information to specific package managers and
systems in the userspace. Tomorrow a new system may come, which will
cause this list to grow, not to mention other existing package managers.
The kernel also doesn't have a role in it, so we should try to be generic
as much as possible.

Thanks,
Siddh