Received: by 2002:a05:6358:9392:b0:b2:7f6c:8e3b with SMTP id h18csp7176892rwb; Wed, 10 Aug 2022 03:58:30 -0700 (PDT) X-Google-Smtp-Source: AA6agR7Dq+z6nDldeCgUkrB62jj0BpiKJM1UEtcogG77kUE1GsnZEi3Q1uBSeZbVgYuewXFtQdZw X-Received: by 2002:a17:906:9b0a:b0:730:d37b:4712 with SMTP id eo10-20020a1709069b0a00b00730d37b4712mr18624671ejc.537.1660129109887; Wed, 10 Aug 2022 03:58:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660129109; cv=none; d=google.com; s=arc-20160816; b=aAngEXurWkT7eYxjGVpYEShH/Ylh4+GuU9rwYO0IH9hub0DQNLiDUda0yt9WECEPL7 WX2wSWByCF91XqSnaLuxodRKxQ2W1JHuCT3H/W03ZqYXt8DhTZNSS8MuL7T8aRdQIA39 Dfs80EtiMU4ycpkOpynSLFxh4KGMw2Bd4XIVk03TfVnK4VSIfx5VWPZ5ocTdoC0t8KGu jmMru+uyv0rKb4TcUOwVHviAk/0m/GEQ6el1wexce5tmklobn6sgFJf4weUQ7ZhwVGMV rjGcE8uEvYVKtQrDkhGTNNpRjIqgHb/sgCPVgy+oAant9eeNjVgNqZvYzge0xL5pc9Bb SJ2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=w4+dT3fDyK/K8aBJGdJBcVH2VL1Iayib78PNhYfcNe8=; b=Em1kLnczVZfd28bNi9LQ0eyJlLb7qSNcy5tme2FAa5dyl0YLKwozcZPMAm67jOfZoD 1edicfdJLsKaYjUI2A+QvcWKdcrT0MKTdiwi62l4cTeBo7K7wIU3tDTRnIMakbw5fXLE vel8WGkTNWCgd5+E9qDCqsi4U6xsEkx1z8Upil7TXxQx98x3qiYd0rRtPSZfLcCjkb51 vxy/eerMRP31rQpcN2NXbcjzKfk4cCq+jzmvsLCHRIMo/Lpp+xcgndWpRkGp/GggbIAa 6meH06zL/v97rTj9Ozy8MLxbCq5o6yWdIqxMg0wj5nkj27w+EFJQRyZrXZKP9LxZdnl3 WdLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=dBkxsAB8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sd27-20020a1709076e1b00b007307a4f5102si4413960ejc.830.2022.08.10.03.58.04; Wed, 10 Aug 2022 03:58:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=dBkxsAB8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231374AbiHJKlS (ORCPT + 99 others); Wed, 10 Aug 2022 06:41:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbiHJKlR (ORCPT ); Wed, 10 Aug 2022 06:41:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EC396B665; Wed, 10 Aug 2022 03:41:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A9A2A61199; Wed, 10 Aug 2022 10:41:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7143C433C1; Wed, 10 Aug 2022 10:41:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660128075; bh=CJ+veYLE2yi0irO1SQ0dJ19o4C5fKkXVLX0IMO8dpuI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dBkxsAB8whfxkXG9rTnqrm6ZGXaJHZlv9QVSo4n5v7M9t4NMAI/JJrhYOiSMzfVBI dwvbTf/RhcxkBHkZ0O2+UzCP+2pEOJDeo6O0+c6/mCu9tucgX1mztxq4HpQnOlRWfV /2oFFEMiv8xOnzKB635KgaDMVwOUT5FaMMZ76ViU= Date: Wed, 10 Aug 2022 12:41:12 +0200 From: Greg KH To: Szuying Chen Cc: mika.westerberg@linux.intel.com, andreas.noever@gmail.com, michael.jamet@intel.com, YehezkelShB@gmail.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Yd_Tseng@asmedia.com.tw, Chloe_Chen@asmedia.com.tw, Richard_Hsu@asmedia.com.tw Subject: Re: [PATCH] thunderbolt: thunderbolt: add vendor's NVM formats Message-ID: References: <20220810101743.11214-1-chensiying21@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220810101743.11214-1-chensiying21@gmail.com> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 10, 2022 at 06:17:43PM +0800, Szuying Chen wrote: > The patch add tb_nvm_quirks() contain an array that has functions > pointers to tb_nvm_vendor_apply(). > And tb_nvm_vendor_apply() that recognize supported vendor works in one > of the following cases: > Case NvmUpgradeSuppport: enable nvm's attribute by setting > no_nvm_upgrade flag to create nvm_authenticate file node. > Case NvmAdd:add active/non-active NVM devices. > Case NvmWrite:update firmware to non-ative NVM device. > > Signed-off-by: Szuying Chen > --- > drivers/thunderbolt/nvm.c | 59 ++++++++++++++---------------------- > drivers/thunderbolt/switch.c | 19 +++++++----- > drivers/thunderbolt/tb.h | 18 +++++++---- > 3 files changed, 46 insertions(+), 50 deletions(-) This patch does not apply to any tree that I work with. Please make it against Linus's latest tree right now, or linux-next to be safe. thanks, greg k-h