Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 Aug 2022 12:56:54 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Matti Vaittinen <mazziesaccount@gmail.com>
Cc:     matti.vaittinen@fi.rohmeurope.com,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/7] regulator: Add devm helpers for get and enable
Message-ID: <YvOdBv0edrE3wKsO@sirena.org.uk>
References: <cover.1660127865.git.mazziesaccount@gmail.com>
 <b6058e052b842a19c8bb639798d8692cd0e7589f.1660127865.git.mazziesaccount@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="VEGw3rzY/Fe5v0a/"
Content-Disposition: inline
In-Reply-To: <b6058e052b842a19c8bb639798d8692cd0e7589f.1660127865.git.mazziesaccount@gmail.com>
Precedence: bulk


--VEGw3rzY/Fe5v0a/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 10, 2022 at 02:29:55PM +0300, Matti Vaittinen wrote:
> A few regulator consumer drivers seem to be just getting a regulator,
> enabling it and registering a devm-action to disable the regulator at
> the driver detach and then forget about it.
>=20
> We can simplify this a bit by adding a devm-helper for this pattern.
> Add devm_regulator_get_enable() and devm_regulator_get_enable_optional()

I'm really not keen on the idea of a devm managed enable, it's too prone
to bugs when someone gets round to implementing runtime PM.

--VEGw3rzY/Fe5v0a/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLznQUACgkQJNaLcl1U
h9AIzAf/X+NMPhyskNdOzwuTnf5JL6aMQ/zaJRQZrPj3HWbXUBsD0zo97kgordwT
xkKmtSRvixezeA+CvEOIQcJTc4myiLxOqbNWgpIw2D6bDv5ZzFD18c2GB7MsOf7Z
VKmzH4HK130qf5qvo5FrxC5EIRebiP7q4V49x8wqqVkLxhQdQLJlKZ7ZW5mNS3oE
jwIoux8+lnmNOOEiQQ+GlC7YhhxDcsh/5JcVE/5b+qMnKW12a3coAmiq+hEHoI9/
A78vuODzf9JCgfiSC/4d/ZKIDs+pQsCsMSXRKjisGY2pN9AE6va2pRQeCLprtHqv
FqlouA068TRQb0FlIu7vPYJ4YAuETg==
=7Hrc
-----END PGP SIGNATURE-----

--VEGw3rzY/Fe5v0a/--