Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 Aug 2022 13:37:48 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Neil Armstrong <narmstrong@baylibre.com>
Cc:     linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
        Da Xue <da@libre.computer>
Subject: Re: [PATCH] spi: meson-spicc: save pow2 datarate between messages
Message-ID: <YvOmnDJA+ov49chC@sirena.org.uk>
References: <20220809152019.461741-1-narmstrong@baylibre.com>
 <YvJ84qkuXdvVgXRm@sirena.org.uk>
 <39c2f53b-8f53-ceb1-ae0c-81e5e53d01aa@baylibre.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="2hd26sDiWQtv5ujx"
Content-Disposition: inline
In-Reply-To: <39c2f53b-8f53-ceb1-ae0c-81e5e53d01aa@baylibre.com>
Precedence: bulk


--2hd26sDiWQtv5ujx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Aug 10, 2022 at 11:17:14AM +0200, Neil Armstrong wrote:
> On 09/08/2022 17:27, Mark Brown wrote:
> > On Tue, Aug 09, 2022 at 05:20:19PM +0200, Neil Armstrong wrote:

> > When you say the value set by the clock framework does that mean that
> > the clock driver is adjusting hardware inside the SPI controller IP
> > block which is then getting reset by the SPI driver without the SPI
> > driver knowing about it?  That seems like a bad idea as you're finding
> > here.

> The SPI driver is explicitely triggering a reset at the end of each message
> to get back to a clean HW state, but it does reset the content of the "legacy"
> registers containing the power of 2 divider value, the new registers configuring
> the new clock divider path (only on newer SoCs) doesn't get cleared.

Sure, but that doesn't really address the concern - is this something
that the clk driver programmed or is this the driver forgetting to
restore a register that it programmed itself?  The commit message sounds
like the former which is a much bigger problem.

--2hd26sDiWQtv5ujx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLzppwACgkQJNaLcl1U
h9CP8Qf/cMQYM72jnQkNExfj6dskX5IIOlwCnAVUEnsbYrFpv3QL6BNLxgKx4eqx
cjDy+gszIhOd4rr7/ayE4siN6fjOo/hWNIuydrrCsRWKrjvKTUInWB16AnVv5NrK
JAjl3RZ9vrkKp2UcN/dsaU11B5Xce59ko2nuniDhKYZhubO9F2uYxOPiBLvufQyU
Q20TDeHIgYaClQvbbnVnIBpjkeOYaZxhkpAjZmw/Btip07mzspkcC4ASnTbTKs2j
cCeDY+xkSNPqT+Pie+GxbV0bOeAjLdUOwP7QoXIsrP4BJRzuoHk/aXWC8GzXo13a
3baxwuQr/bFzHeoJRT+a3zrpms9mLA==
=yOBS
-----END PGP SIGNATURE-----

--2hd26sDiWQtv5ujx--