Received: by 2002:a05:6359:322:b0:b3:69d0:12d8 with SMTP id ef34csp186955rwb; Wed, 10 Aug 2022 06:52:25 -0700 (PDT) X-Google-Smtp-Source: AA6agR7phizIEX2fmLAhU52HvGZbCgy+iwXY2rMrrHxBfwVBLt+jnUo9sQmJj0jdxGLnYRLf/pt+ X-Received: by 2002:a17:907:7e94:b0:730:aa9c:cb6a with SMTP id qb20-20020a1709077e9400b00730aa9ccb6amr19345808ejc.257.1660139544934; Wed, 10 Aug 2022 06:52:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660139544; cv=none; d=google.com; s=arc-20160816; b=JwGQPP1BoaBGb4smUpW/S767I0YdQjNwBOZGX68Se6z2WLVT/UEF4eoKs91UHCW+IE Fwqg9ZVe/W416BPN75i0kXZjwV3x4TaOHeVe0AI++EtkYB0aspcWCmoZaiUzn5v9KezF 0W8RZUWF46YV8hZHJ1OhJEB7gvAAQnqwoTCoDo1UNpGOx1meRBdpE6F699E3phsdNkR9 jdX4GdeahpCRon1BA1JeyIG25JJKy0rMvkHrSLCw/mlovu4TMveyNgvOPfs5rpLdpymO 7Xc0ZJFzAVgXtFmWd1oCaJOBtlfYr25ZJqk/P6UD/TyX5NyyoYrymsj+iQfYnMWs4g+C EWKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=Z4Hyw0PpOR6PyJk1gjcDRkxS9uvIdkaJI9TxqqUTdNM=; b=WeQpDSNkBjyYftEaqKFZ2YlYTcP4Tf6oLGDKV+QQrLu6b/j5/pL2NAYpq7fBlyovqq ZMCm3iRbNPG2+EgI+ipwC19YExLryKBCMSgPUP1Zi0YXNk9Igk6Nkc8wuxPXlL4OKQZR fPVzbyosEW3GWoQMS1V89Kg2hNVBvHRqM1Ee5Jl6geoJWyM0c0z1J251iZIZc8vwGHYw Z8iKYTW8ht/Op81qEpVrO0Vje2h2U8QL6A9ZcdPYs0xcRXtnTFxDspOTRCnY6F01uF/l +krvbkR0cf0wSwFwPFRDVgPIQJnM9kCCI+c+ELb3JFYAq3jbsTzhyeF1WWZtbtpi2kAw wjJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EmHL0gXe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z11-20020a1709063acb00b0072af95f96dbsi3959669ejd.70.2022.08.10.06.51.59; Wed, 10 Aug 2022 06:52:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EmHL0gXe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232797AbiHJNgB (ORCPT + 99 others); Wed, 10 Aug 2022 09:36:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232866AbiHJNfo (ORCPT ); Wed, 10 Aug 2022 09:35:44 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5C8849B73 for ; Wed, 10 Aug 2022 06:35:42 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id d14so21229954lfl.13 for ; Wed, 10 Aug 2022 06:35:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=Z4Hyw0PpOR6PyJk1gjcDRkxS9uvIdkaJI9TxqqUTdNM=; b=EmHL0gXeZg/tY6cp1ad7Qz+P8jaNZEWRdP5kE08nJz1GpMYMky8aEjpvMR2NOA6TV+ tAJrgmqDIh9mJkW4ydro1SX9eou5VZ0vfiDDk+5XAkItgg1s1uKFyDYC5v8wvV+FQhD7 vzCUY/Yp1exv0xf0lqZ27CH2tq2U0L8csiDixD0Y/EeyxwPvtamzX0RgW5n0ymDHfAvf eeeraHS+3Z0Ze60G0chUDGXCkDzMiqgE5GFn/yCZuzjMC0603pDPchDW8RPMZTxy9l0e 7zo3OCIzFsX0ScKhl7AsOAjRz9P0Yuouw0UeWrLOFH8wT7KlqmnXe+96q6d7Ci8YOH7w 83Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=Z4Hyw0PpOR6PyJk1gjcDRkxS9uvIdkaJI9TxqqUTdNM=; b=Y1CCahxe4+H71tQVNOP9zn2jb9CMj1wjTzWBqZ22JvV7Nf6n6Wx01vfxjF/Um4cU5n nXfiBAvOm99VfI9himgV6HyflBPsIC7acLMgqcbtyEH9m1zOb/bi4uEpTESLZgxqd1xy L0ZvwJeCFrfIqoq2REUly+nyime3zQon+Nire0UlgkDnuW3HrNz/sfpA4ycZd/r9kx/2 3/+dJB/+YwFHvpAhPCo/HeFa7r11AJOZ8ln4BAbncez7KhRKH0ZZ4h6+7HQiv+yGColb a9kF5N72YkKFY2qC1tcAe1kSOquCETmkiaWgKAUsIDaL0gURrK/I4YP+GOONQyMMqqaU bP4Q== X-Gm-Message-State: ACgBeo1ZymgqvLcNCgklBB7obY97GCiq8/cDwIEBLc0QkEkAfuvcB1mQ jIOGM+DK4sXmT3HhEW9Sah/1VA== X-Received: by 2002:a05:6512:31c5:b0:48b:38cf:51f8 with SMTP id j5-20020a05651231c500b0048b38cf51f8mr9876793lfe.315.1660138541295; Wed, 10 Aug 2022 06:35:41 -0700 (PDT) Received: from [192.168.1.39] ([83.146.140.105]) by smtp.gmail.com with ESMTPSA id a4-20020a056512390400b0048a9356cd63sm353115lfu.11.2022.08.10.06.35.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Aug 2022 06:35:40 -0700 (PDT) Message-ID: Date: Wed, 10 Aug 2022 16:35:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 1/2] dt-bindings: power: supply: Add Lenovo Yoga C630 EC Content-Language: en-US To: Bjorn Andersson , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20220810030500.2793882-1-bjorn.andersson@linaro.org> <20220810030500.2793882-2-bjorn.andersson@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220810030500.2793882-2-bjorn.andersson@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/08/2022 06:04, Bjorn Andersson wrote: > Add binding for the Embedded Controller found in the Qualcomm > Snapdragon-based Lenovo Yoga C630. Thank you for your patch. There is something to discuss/improve. > + > +description: > + The Qualcomm Snapdragon-based Lenovo Yoga C630 has an Embedded Controller > + (EC) which handles things such as battery and USB Type-C. This binding > + describes the interface, on an I2C bus, to this EC. > + > +properties: > + compatible: > + const: lenovo,yoga-c630-ec > + > + reg: > + const: 0x70 > + > + '#address-cells': > + const: 1 Just to clarify: the EC have physically two USB connectors? > + > + '#size-cells': > + const: 0 > + > + interrupts: > + maxItems: 1 > + > +patternProperties: > + '^connector@\d$': > + $ref: /schemas/connector/usb-connector.yaml# unevaluatedProperties:false inside connector (on its level) > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - |+ > + #include > + i2c1 { > + clock-frequency = <400000>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + embedded-controller@70 { > + compatible = "lenovo,yoga-c630-ec"; > + reg = <0x70>; > + > + interrupts-extended = <&tlmm 20 IRQ_TYPE_LEVEL_HIGH>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + connector@0 { > + compatible = "usb-c-connector"; > + reg = <0>; > + power-role = "source"; > + data-role = "host"; > + }; > + > + connector@1 { > + compatible = "usb-c-connector"; > + reg = <1>; > + power-role = "source"; > + data-role = "host"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@1 { > + reg = <1>; > + lenovo_ec_dp_in: endpoint { > + remote-endpoint = <&mdss_dp_out>; You have inconsistent indentation. Use 4-spaces for entire DTS example. Best regards, Krzysztof